From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 511C4C77B7A for ; Thu, 25 May 2023 16:27:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240912AbjEYQ1q (ORCPT ); Thu, 25 May 2023 12:27:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240568AbjEYQ1P (ORCPT ); Thu, 25 May 2023 12:27:15 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E8D8E6E; Thu, 25 May 2023 09:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=spc29Cm0a+oO128y4mo0IaM9JJ5/Y6pCdvJ8tr2Dfag=; b=sEI6Kn0a/+TFGY+DqA8SqsqAMN r7wV/N+GHENm2Gx0P3CUwavLtTrdIDeJfvkRnuCSc3HzFZzTQd67RxcBAT3dA7+CfxrwV85NQuG10 zRwGHZMZ79ECgzmQGchKlnTlACoWCjc7DnZDP+G0S405EljESD4eSB/MtdNl5raXm245Eg0NWlGEf Hz6I5Yc+uVW2wh1GyuVmvu2tBufkFykrDMWiVbr6lPOV1EJhjKd5789WUng75huN0nTLl4IE+AMb0 xJvhIHyFZSAAZIqnh4u87tCrTL07cphpiuPcS3XioCP/E/HEguj6wQubhuKM3Y84R3pHu+rEEvh5q KO5lmlHQ==; Received: from [2601:1c2:980:9ec0::2764] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1q2Dnk-00H5bT-26; Thu, 25 May 2023 16:26:56 +0000 Message-ID: Date: Thu, 25 May 2023 09:26:55 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 1/2] soc: fsl: cpm1: Fix TSA and QMC dependencies in case of COMPILE_TEST Content-Language: en-US To: Herve Codina , Qiang Zhao , Li Yang , Greg Kroah-Hartman , Jiri Slaby Cc: linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Mark Brown , Christophe Leroy , Thomas Petazzoni , kernel test robot References: <20230523085902.75837-1-herve.codina@bootlin.com> <20230523085902.75837-2-herve.codina@bootlin.com> From: Randy Dunlap In-Reply-To: <20230523085902.75837-2-herve.codina@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/23/23 01:59, Herve Codina wrote: > In order to compile tsa.c and qmc.c, CONFIG_CPM must be set. > > Without this dependency, the linker fails with some missing > symbols for COMPILE_TEST configurations that need QMC without > enabling CPM. > > Signed-off-by: Herve Codina > Reported-by: kernel test robot > Link: https://lore.kernel.org/oe-kbuild-all/202305160221.9XgweObz-lkp@intel.com/ Fixes all of my CPM build issues. (with patch 2/2 also applied) Thanks. Acked-by: Randy Dunlap Tested-by: Randy Dunlap # build-tested > --- > drivers/soc/fsl/qe/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig > index 7268c2fbcbc1..e0d096607fef 100644 > --- a/drivers/soc/fsl/qe/Kconfig > +++ b/drivers/soc/fsl/qe/Kconfig > @@ -36,7 +36,7 @@ config UCC > config CPM_TSA > tristate "CPM TSA support" > depends on OF && HAS_IOMEM > - depends on CPM1 || COMPILE_TEST > + depends on CPM1 || (CPM && COMPILE_TEST) > help > Freescale CPM Time Slot Assigner (TSA) > controller. > @@ -47,7 +47,7 @@ config CPM_TSA > config CPM_QMC > tristate "CPM QMC support" > depends on OF && HAS_IOMEM > - depends on CPM1 || (FSL_SOC && COMPILE_TEST) > + depends on CPM1 || (FSL_SOC && CPM && COMPILE_TEST) > depends on CPM_TSA > help > Freescale CPM QUICC Multichannel Controller -- ~Randy