From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E90803E51D8 for ; Mon, 25 May 2026 08:46:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779698765; cv=none; b=EqqdsWxXZWaywQYm773+GDvKcObFIvjEIbL70zCOUv4ZWpiCWQczQ04ZLB8l2j7pgsfrBdCFr8F7vn1/Ud2mdZErASiKgQPrz2XQOmv1C5KuMdl8pwHvGK+71xeFvpIBSMJzkvD95C9X4bzTMgyim6frCGoEwLjvZp+UaQObpS8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779698765; c=relaxed/simple; bh=RVCV0KAzW/3y+rrtGYRGLXcpYLEOUoe3QHZ5Oyu1M0I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YwmgI4MbHKAZysLKF/FLakzjiVwRDOByAIqcfr3JHHgld0isLCBAgKcgNlwjxQSj5CFbW97uZOiinW8komMDHruqLCbUiw8uzzmLzhSn3mt+5CJZQtuxMHZF9FiNbm5Ersc3j0x+me1a5Xk9z8K24eINsJY5NZ/5jPrl8DRN9co= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=IpGgaYUA; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="IpGgaYUA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1779698762; bh=RVCV0KAzW/3y+rrtGYRGLXcpYLEOUoe3QHZ5Oyu1M0I=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=IpGgaYUA6WlJOXP8zbTfoc448+EE+PojNvepQ1agw5wLoubw+H5jaKP92Dzp++ysk l/HLRMRapXzmRiMS/acTqtXxYOUe84ieO0fFJilWgd0fehR5CpY20JkaXN6yBAVMhN xE14um8K1tCmwYIBjrTGIVTm7IJ6qAlIwv8Kf3EpUj8qu2oqFvC+t+9gmXbG6HVGJ0 RLPz0VG9Mkw3J30D4NiHBoYTYJELaQN1aEkYCBrvdRGq0cCyBEvp4E/8FPHTCu3WG5 CD6ap6E5z3XCe2rE6Rs5o9cqu5myFyfEKWAO/iCMBNqYX8Zsn0FTdcjBDw19KlUTtZ bgpPV2xKmnujg== Received: from [100.64.1.21] (unknown [100.64.1.21]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id A7BCA17E0979; Mon, 25 May 2026 10:46:01 +0200 (CEST) Message-ID: Date: Mon, 25 May 2026 10:46:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: mediatek: pwrap: Remove obsolete NEED CONFIRM comments To: Akari Tsuyukusa , matthias.bgg@gmail.com Cc: james.lo@mediatek.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20260522134522.368073-1-akkun11.open@gmail.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20260522134522.368073-1-akkun11.open@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/22/26 15:45, Akari Tsuyukusa wrote: > Remove the obsolete "/* NEED CONFIRM */" comments from the MT8196 s/mt8196/mt8195/g > configuration. These values were previously confirmed during review, > but the placeholder comments were accidentally left behind. > > Link: https://lore.kernel.org/all/2a117e5fe9fe0ece39e9165a463082ef42be973f.camel@mediatek.com/ > Signed-off-by: Akari Tsuyukusa after which... Reviewed-by: AngeloGioacchino Del Regno > --- > drivers/soc/mediatek/mtk-pmic-wrap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c > index 0bcd85826375..87bcbfa2d5f1 100644 > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c > @@ -2396,8 +2396,8 @@ static const struct pmic_wrapper_type pwrap_mt8183 = { > static const struct pmic_wrapper_type pwrap_mt8195 = { > .regs = mt8195_regs, > .type = PWRAP_MT8195, > - .arb_en_all = 0x777f, /* NEED CONFIRM */ > - .int_en_all = 0x180000, /* NEED CONFIRM */ > + .arb_en_all = 0x777f, > + .int_en_all = 0x180000, > .int1_en_all = 0, > .spi_w = PWRAP_MAN_CMD_SPI_WRITE, > .wdt_src = PWRAP_WDT_SRC_MASK_ALL,