From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89559245008; Thu, 30 Jul 2026 02:58:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785380300; cv=none; b=KU7wcXd9sSn49dfRoiqsvB81wNHb6WD1aCalYQoaDaXuizsQUWL1dzWz4onXlK2/5xtCMszyUCR1QFL2nEx7bpwoWRaZaEe8Url5F8ivNa8fG970158oflmM3PDQAG+2LRBGhjIOt8DwsaDbsbqHTdXTGy3YE9nJ2v9trlO+4KQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785380300; c=relaxed/simple; bh=ejt/djUD1baqE1xPyQVBwLUUKUF2GAiv4FO6Ghh+Aqc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=b0HJDCSXcbTNploDWX5Bo2791d5x0XipqP/VP36Y/YE9Dc5lmWa/DVdMwxHYFnsldtbhVmkDLHalG7jtox8ckAo5zwnpgFFPT+WJlRlb94ITmChE4+N08DP386tts5zzYq8y3KMU1nOW0I6OH7Ro8hGu1HNMVYQ0V2D6CLkGHig= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 7f26be5a8bc211f1aa26b74ffac11d73-20260730 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:9c45239c-3174-4d2e-a98c-8a1ea50b75c4,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:e7bac3a,CLOUDID:949d718dcc99109c5e8fe41e75fa643b,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:80|81|82|83|102|865|898,TC:nil,Content:0 |15|52,EDM:-3,IP:nil,URL:99|1,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL: 0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULS X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 7f26be5a8bc211f1aa26b74ffac11d73-20260730 X-User: xiaopei01@kylinos.cn Received: from [10.42.12.251] [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_128_GCM_SHA256 128/128) with ESMTP id 2126702860; Thu, 30 Jul 2026 10:58:09 +0800 Message-ID: Date: Thu, 30 Jul 2026 10:58:07 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ata: pata_parport: Fix use-after-free in new_device_store To: Damien Le Moal , cassel@kernel.org, linux@zary.sk, axboe@kernel.dk, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Cc: shuangpeng.kernel@gmail.com References: <7a9734be161cd051063ccc3bdeb377c55a83c4bf.1785327915.git.xiaopei01@kylinos.cn> <683be1d4-5df2-4426-b5c2-be217758fccf@kernel.org> From: Pei Xiao In-Reply-To: <683be1d4-5df2-4426-b5c2-be217758fccf@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 在 2026/7/30 07:42, Damien Le Moal 写道: > On 7/29/26 21:27, Pei Xiao wrote: >> The function new_device_store() calls driver_find() without any >> protection against concurrent driver unregistration. This can lead >> to a use-after-free (UAF) when a driver is unloaded (via rmmod) >> in parallel with a new device addition via sysfs. >> >> The race window exists because driver_find() returns a pointer to >> the driver's private data, but does not increase its reference >> count. The caller is responsible for ensuring the driver remains >> valid, but new_device_store() did not hold any lock or reference >> during the lookup and subsequent use. >> >> Concurrently, pata_parport_unregister_driver() releases the >> pi_mutex before calling driver_unregister(), allowing new_device_store >> to proceed with a stale pointer after the driver has been freed. >> >> Fix this by expanding the critical section protected by pi_mutex >> in both functions: >> >> - In new_device_store(): acquire pi_mutex before calling driver_find(), >> and keep it held until all uses of the found driver pointer are >> completed. >> - In pata_parport_unregister_driver(): hold pi_mutex throughout the >> entire unregistration process, including the driver_unregister() >> call, so that no concurrent lookup can see a partially removed >> driver. >> >> Thread A (new_device_store) | Thread B (pata_parport_unregister_driver) >> driver_find("aten") | >> | mutex_lock(&pi_mutex) >> | idr_remove(&protocols, id) >> | mutex_unlock(&pi_mutex) >> | driver_unregister(&pr->driver) >> | (frees driver_private) >> /* continues using stale driv */| >> -> UAF! | >> >> Logs: >> BUG: KASAN: slab-use-after-free in driver_find+0xd0/0xd4 >> Read of size 8 at addr ffffff9f970dc690 by task sh/4737 >> Call trace: >> show_stack+0x14/0x1c (C) >> dump_stack_lvl+0x70/0x84 >> print_report+0xf4/0x5a4 >> kasan_report+0xa0/0xe4 >> __asan_report_load8_noabort+0x18/0x20 >> driver_find+0xd0/0xd4 >> new_device_store+0x140/0x30c [pata_parport] >> bus_attr_store+0x5c/0x94 >> sysfs_kf_write+0x1c4/0x25c >> ... >> >> Allocated by task 4734: >> kasan_save_stack+0x28/0x4c >> kasan_save_track+0x1c/0x34 >> kasan_save_alloc_info+0x3c/0x4c >> __kasan_kmalloc+0x98/0xac >> __kmalloc_cache_noprof+0x158/0x3cc >> bus_add_driver+0x70/0x4d8 >> driver_register+0xf0/0x3b0 >> pata_parport_register_driver+0xb8/0x1c4 [pata_parport] >> 0xffffffc07f5ce014 >> do_one_initcall+0xb8/0x36c >> do_init_module+0x230/0x6d4 >> ... >> >> Freed by task 4737: >> kasan_save_stack+0x28/0x4c >> kasan_save_track+0x1c/0x34 >> kasan_save_free_info+0x48/0x8c >> __kasan_slab_free+0x5c/0x84 >> kfree+0x174/0x3e0 >> driver_release+0x1c/0x7c >> kobject_put+0x178/0x47c >> driver_find+0x78/0xd4 >> new_device_store+0x140/0x30c [pata_parport] >> bus_attr_store+0x5c/0x94 >> sysfs_kf_write+0x1c4/0x25c >> ... >> >> Fixes: 72f2b0b21850 ("drivers/block: Move PARIDE protocol modules to drivers/ata/pata_parport") >> Reported-by: Shuangpeng Bai >> Closes: https://lore.kernel.org/lkml/20260728024015.2014674-1-shuangpeng.kernel@gmail.com/ >> Signed-off-by: Pei Xiao >> --- >> drivers/ata/pata_parport/pata_parport.c | 9 ++++----- >> 1 file changed, 4 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/ata/pata_parport/pata_parport.c b/drivers/ata/pata_parport/pata_parport.c >> index 40baeac594a9..34f09192a419 100644 >> --- a/drivers/ata/pata_parport/pata_parport.c >> +++ b/drivers/ata/pata_parport/pata_parport.c >> @@ -3,6 +3,7 @@ >> * Copyright 2023 Ondrej Zary >> * based on paride.c by Grant R. Guenther >> */ >> +#include >> #include >> #include >> #include >> @@ -618,8 +619,9 @@ void pata_parport_unregister_driver(struct pi_protocol *pr) >> break; >> } >> idr_remove(&protocols, id); >> - mutex_unlock(&pi_mutex); >> driver_unregister(&pr->driver); >> + mutex_unlock(&pi_mutex); > > Sashiko had a comment about this that I think is very valid: if rmmod is > executed with devices attached, what happens here? > This entire driver seems to be lacking reference counting on the > modules/drivers, so this all seems very fragile. Ok, I will check this issue then. > >> + >> } >> EXPORT_SYMBOL_GPL(pata_parport_unregister_driver); >> >> @@ -646,6 +648,7 @@ static ssize_t new_device_store(const struct bus_type *bus, const char *buf, siz >> port_wanted = -1; >> } >> >> + guard(mutex)(&pi_mutex); > > Please no. We do not use these annotations anywhere in libata and I personally > consider anything that hides code a *bad* idea. So just move the mutex_lock() > call here and add the missing mutex_unlock() in the !drv case below. Ok. Thanks! Pei. > >> drv = driver_find(protocol, &pata_parport_bus_type); >> if (!drv) { >> if (strcmp(protocol, "auto")) { >> @@ -656,15 +659,12 @@ static ssize_t new_device_store(const struct bus_type *bus, const char *buf, siz >> } else { >> pr_wanted = container_of(drv, struct pi_protocol, driver); >> } >> - >> - mutex_lock(&pi_mutex); >> /* walk all parports */ >> idr_for_each_entry(&parport_list, parport, port_num) { >> if (port_num == port_wanted || port_wanted == -1) { >> parport = parport_find_number(port_num); >> if (!parport) { >> pr_err("no such port %s\n", port); >> - mutex_unlock(&pi_mutex); >> return -ENODEV; >> } >> /* walk all protocols */ >> @@ -677,7 +677,6 @@ static ssize_t new_device_store(const struct bus_type *bus, const char *buf, siz >> parport_put_port(parport); >> } >> } >> - mutex_unlock(&pi_mutex); >> if (!ok) >> return -ENODEV; >> > >