From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0D421D5ADD for ; Thu, 27 Feb 2025 03:39:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740627591; cv=none; b=qEpgpRZHP/xEMO/Bb2X5EuVfKcq9FwBmrpsLU1T/kiy/M6ltq4ZBk64bjBfk0cJDTQ5HogQS+GUy3aCn2yvLnnrDnx4WNNLfRpkXkAcC1VHc8joI8R2Ei3zE4lfjdG0Q1wyV2mvXsUa3/8g3Ka+RA/GaFKFQq23CAbvRcFDTMLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740627591; c=relaxed/simple; bh=8NZQRl+nsIrBQgX3n3RDpAkQuhuYznIhsac/14r1q9s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RKlf2vepVlO8o/qQUT+VfSzkKHCmd+0V4O1rZYjSWP50pxndNNBpG9Mc+73fdADl6o46znCn4VSvAaQq0iKleL2gJrUuIykMqDKN0IECUX2tJY2JEGJutoewsfWp8nBMDksDhdPzvJOcMbaGYA2uawkgQvJWSfMfvVyJ/PeYaWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IKrgYt4R; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IKrgYt4R" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51QJToOV011784 for ; Thu, 27 Feb 2025 03:39:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BiPDf3NLW+yGvrT10OYje340P3sXo9W1cFDbMr7u/kk=; b=IKrgYt4RXPdwtHLo 019UhXiNsIh7Ywm6PsYSD9KV4DMzC91oytVuorNMysWTLuyBMcCsnEALSi6u7lqm LKc9nC3xN0XwfsFPk9WTzyIYcgysRXKBr1ygEqAZbZHcKze+shwkcXhCT50iVfaJ kdi8XG6IxDMstE7d80Rjws4vl3fzBr+AzWBV9tICiFgkeX8DRdMu0cxCDXPy/MJX DUTLcg2xLIdGZhoulxr8BOkFJYkyncNoC875tOb5jG4idpK4xdHbkE5Z6h/6L3t5 yLcBlT/KpTVcT8h5F3NfPx0Luw3GV1tvmX8W+MbDcyJbj08IvTfkpToU3L8OLD68 eIItpw== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 451prmm5a3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 27 Feb 2025 03:39:48 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-2f81a0d0a18so1211323a91.3 for ; Wed, 26 Feb 2025 19:39:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740627588; x=1741232388; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BiPDf3NLW+yGvrT10OYje340P3sXo9W1cFDbMr7u/kk=; b=qzhgVesTBI8oNUCX6BY+KK/CanKgaNVGZqJMw8dzn1mJSP4wEGqQStt5Bjr/h/3tz4 +bGou9biryUKEo/+MT6JCba6ztGY7RmQfkdBQcPhmkkqtZCloT7zT13ok6rHvY4tstU+ FvDNF0RPNWSqbHsgrFv00zwn5s2PqVtkHIk8nwtk++CBQLXo+zPI5EVzpF77TPx0B+WG gm1mTa6gilA7JvpnE++8PNRxgOEQCoRTQEWxlyulatkjfdrw4SHYJRczm8YjjZI/DBlR Fuf/gb/D16UGA5IPSyX7/SVRzKRMOzOp3v6E9JUUPJL3uFcqnFmpiESxVpzEv1F0DDZx R1eg== X-Forwarded-Encrypted: i=1; AJvYcCVtLA9nNeQqS65OCTRc6unuh42fHAn2S5b1gaJQhCtpie1CB5QA+WHSf01v0Fx3Wd8q7hwFOkQWOUUzir0=@vger.kernel.org X-Gm-Message-State: AOJu0YxRbjE1lpXc8C5PciB+shXZm9Jy7zJtvSWq/pULQQKpXEDFBiHj Ch7+DQ+EWmRPi1WZdfnKG6h3kfsc7R18K3HTp3pVWDFpedVz+j1jb0wiqYctpYtAkvIhYkJsb0U GsX3CTTzQ8jNbu86bP9etInUdmDXxJQ9YT7L8yv1JL7RBoVVTaJcwee5timy3NWs= X-Gm-Gg: ASbGnctwRzYtR3kG8G6IVGwXsENfo14/l9k6wgk/xC0aB1sswtjA9YET6Cpm7JKaGFj bCVMuO6v5F+9mJK7mmZEGGGfXERBYus07Yfsx+zX21CVQXCl3o3VB422x20NFzBhjMbb6rFwBxR 9Z1a7ExcMraOjGGbGsvDPRaKl4kweGJtIKyVF14ZGHbaUcY8E5Gvvm7mqnI/wSRzEVBTvC1F45H cMNMl9FApMP4t4OVJA0mktfaLaHrmtt1PQn6lOrFWz/+vdcTVANoP5rbZcfHw2ISq1kQaykLPYe 5IYlX+7m+Ee4tL9HPQzrDfjBpV0lJwWSNg35HWKy9tnu X-Received: by 2002:a17:90b:540c:b0:2ee:f80c:6889 with SMTP id 98e67ed59e1d1-2fe68d064a4mr16813419a91.33.1740627587934; Wed, 26 Feb 2025 19:39:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IG+W4t33FA3KMwH1ikkC71nGMT26WMp7/JlR/4/dLA43Wj2y4kkKdxpe47SOg4q/G/BiHuvwg== X-Received: by 2002:a17:90b:540c:b0:2ee:f80c:6889 with SMTP id 98e67ed59e1d1-2fe68d064a4mr16813385a91.33.1740627587569; Wed, 26 Feb 2025 19:39:47 -0800 (PST) Received: from [10.92.199.34] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22350531a43sm4162105ad.238.2025.02.26.19.39.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Feb 2025 19:39:46 -0800 (PST) Message-ID: Date: Thu, 27 Feb 2025 09:09:38 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v4 09/10] dt-bindings: PCI: qcom,pcie-sc7280: Add 'global' interrupt Content-Language: en-US To: Krzysztof Kozlowski , Bjorn Andersson Cc: Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , chaitanya chundru , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, Jingoo Han , Bartosz Golaszewski , quic_vbadigan@quicnic.com, amitk@kernel.org, dmitry.baryshkov@linaro.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, jorge.ramirez@oss.qualcomm.com References: <20250225-qps615_v4_1-v4-0-e08633a7bdf8@oss.qualcomm.com> <20250225-qps615_v4_1-v4-9-e08633a7bdf8@oss.qualcomm.com> <20250226-enlightened-chachalaca-of-artistry-2de5ea@krzk-bin> From: Krishna Chaitanya Chundru In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: OSoOvXcYWdbZl-s2Mv1Q24sB6_TIA6z1 X-Proofpoint-GUID: OSoOvXcYWdbZl-s2Mv1Q24sB6_TIA6z1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-27_02,2025-02-26_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 impostorscore=0 adultscore=0 mlxlogscore=708 spamscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2502270026 On 2/27/2025 3:03 AM, Krzysztof Kozlowski wrote: > On 26/02/2025 17:29, Bjorn Andersson wrote: >>>> @@ -54,7 +54,7 @@ properties: >>>> >>>> interrupts: >>>> minItems: 8 >>>> - maxItems: 8 >>>> + maxItems: 9 >>>> >>>> interrupt-names: >>>> items: >>>> @@ -66,6 +66,7 @@ properties: >>>> - const: msi5 >>>> - const: msi6 >>>> - const: msi7 >>>> + - const: global >>> >>> Either context is missing or these are not synced with interrupts. >>> >> >> I think the patch context ("properties") is confusing here, but it looks >> to me that these are in sync: interrupts is defined to have 8 items, and >> interrupt-names is a list of msi0 through msi7. > > interrupt-names has minItems 9 in this case, so they are not synced. > That's my concern > Ok I will update the minItems to 9 as suggested. - Krishna Chaitanya. > > Best regards, > Krzysztof