From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751450AbdAVL0M (ORCPT ); Sun, 22 Jan 2017 06:26:12 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:39881 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884AbdAVL0C (ORCPT ); Sun, 22 Jan 2017 06:26:02 -0500 Subject: Re: [PATCH] Input: max11801_ts - drop call to input_set_drvdata() To: Dmitry Torokhov , linux-input@vger.kernel.org References: <20170122073846.GA30131@dtor-ws> Cc: Zhang Jiejing , linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: Date: Sun, 22 Jan 2017 03:25:57 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170122073846.GA30131@dtor-ws> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/21/2017 11:38 PM, Dmitry Torokhov wrote: > Nobody calls input_get_drvdata() so setting it is not required. > > Signed-off-by: Dmitry Torokhov Acked-by: Guenter Roeck Surprisingly, there is about a dozen of those. I'll send a series of coccinelle generated patches later. Guenter > --- > drivers/input/touchscreen/max11801_ts.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/input/touchscreen/max11801_ts.c b/drivers/input/touchscreen/max11801_ts.c > index d87b89da114e..a595ae5284e3 100644 > --- a/drivers/input/touchscreen/max11801_ts.c > +++ b/drivers/input/touchscreen/max11801_ts.c > @@ -199,7 +199,6 @@ static int max11801_ts_probe(struct i2c_client *client, > __set_bit(BTN_TOUCH, input_dev->keybit); > input_set_abs_params(input_dev, ABS_X, 0, MAX11801_MAX_X, 0, 0); > input_set_abs_params(input_dev, ABS_Y, 0, MAX11801_MAX_Y, 0, 0); > - input_set_drvdata(input_dev, data); > > max11801_ts_phy_init(data); > >