From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966187AbYD1WC2 (ORCPT ); Mon, 28 Apr 2008 18:02:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965832AbYD1WCN (ORCPT ); Mon, 28 Apr 2008 18:02:13 -0400 Received: from an-out-0708.google.com ([209.85.132.244]:14858 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965828AbYD1WCK (ORCPT ); Mon, 28 Apr 2008 18:02:10 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=xdAYApj6o9zbfp4rDqpCgCQMnYuxsWDXNNvI6nSDp6FdLbhEr5GJf8BjJ/A3kZahjIWK/KU6+M1IH8bvt1wmGQQsncuKTloAeo0nxiwBUKfqxnbCTpEWt8allcGO5XW7CIIan4E3exfrZd8442cstuMaQnBb4M3A0nWC0aQMGf8= Message-ID: Date: Mon, 28 Apr 2008 22:02:06 +0000 From: "Justin Mattock" To: "Venki Pallipadi" Subject: Re: spinlock lockup on CPU#0 Cc: "Bob Copeland" , "Ingo Molnar" , "Andrew Morton" , "Linux Kernel Mailing List" , hugh@veritas.com In-Reply-To: <20080428203824.GA14044@linux-os.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080426112907.77613dee.akpm@linux-foundation.org> <20080426191432.GA2927@elte.hu> <20080428203824.GA14044@linux-os.sc.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 28, 2008 at 8:38 PM, Venki Pallipadi wrote: > On Sat, Apr 26, 2008 at 09:48:55PM +0000, Justin Mattock wrote: > > On Sat, Apr 26, 2008 at 9:06 PM, Bob Copeland wrote: > > > On Sat, Apr 26, 2008 at 3:14 PM, Ingo Molnar wrote: > > > > > Can you add this please, see if it triggers? > > > > > > > > there's fixes pending in this area. The main fix would be the one below. > > > > > > > > Ingo > > > > > > > > ----------------> > > > > Subject: idle (arch, acpi and apm) and lockdep > > > > > > FWIW, I was seeing the same lockdep trace with eventual hangs, and > > > this patch (applied with some fuzz) fixed the problem. > > > > > > -- > > > Bob Copeland %% www.bobcopeland.com > > > > > > > Just out of curiosity I put the kernel back to it's original state, > > were the freezing occurs, then booted with nohz=off, then added > > WARN_ON(!irqs_disabled()); to sched.c only to the kernel, no other > > patches, upon rebooting > > I received different results: The screen from what I could tell was > > spitting out the spinlock messages, but instead of printing that out, > > and going on to the next task it just keep't printing, from what I > > could tell something with ehci, uhci, agpgart, ieee1394 etc... too > > fast to really make anything out, the numbers on the left side keept > > moving upward, the fans started hauling ass, I waitied a few minuetes > > hopeing this would stop > > so I can grab dmesg, but it would'nt. is there a way to use the boot > > param to write date to a file? so I could capture this event. > > regards > > > > OK. Hunted this bug down to > commit 3b22ec7b13cb31e0d87fbc0aabe14caaaad309e8 > > which for some reason enables interrupt in mwait_idle_with_hints(), which > eventually causes interrupts to be enabled in acpi idle call, resulting in > sched_clock_idle_wakeup_event() with interrupts enabled. This bug > was only in x86 32 bit version. > > Peter's patch below which is already in git fixes this. So we don't need any > additional fixes here... > > Thanks, > Venki > > Alright, I was concerned about having additional fixes. regards; -- Justin P. Mattock