From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761723AbYFGPsU (ORCPT ); Sat, 7 Jun 2008 11:48:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758494AbYFGPsB (ORCPT ); Sat, 7 Jun 2008 11:48:01 -0400 Received: from an-out-0708.google.com ([209.85.132.249]:17374 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758388AbYFGPsA (ORCPT ); Sat, 7 Jun 2008 11:48:00 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=SlCIki3YApa016nNtACiCcwpnAO/5d854KDAhvgLFgYQmDgcz+sCqwwpJROyHr61Q7 Uo1TbKG6eqjX700mYjIRd+9pT1uny5ApFvWFa8QuR1H3+v24oj9PnunhPeealqSNwZeI VauaGAwLw7ZMfJy3nhw9gugXXRip07RChF2dU= Message-ID: Date: Sat, 7 Jun 2008 15:47:57 +0000 From: "Justin Mattock" To: "Andrew Morton" Subject: Re: ACPI: EC: GPE storm detected, disabling EC GPE Cc: "Rafael J. Wysocki" , "Linux Kernel Mailing List" , linux-acpi@vger.kernel.org, "Alexey Starikovskiy" In-Reply-To: <20080606235526.783acc83.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080606235526.783acc83.akpm@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 7, 2008 at 6:55 AM, Andrew Morton wrote: > On Sat, 7 Jun 2008 06:21:54 +0000 "Justin Mattock" wrote: > >> Well; I was hoping it was going to be just an easy fix, but unfortunately >> changing >> if (atomic_read(&ec->irq_count) > 5) { >> to >> if (atomic_read(&ec->irq_count) > 20) { >> does seem to make the message disappear, for a while, probably at >> around three hours,(for me at least) then the message appeared again. >> :-( >> So leaving me back to the beginning of try to have a go at this. >> regards; > > I removed bugzilla from cc - that only works if there's [Bug 1234] in > the Subject:. > > I added linux-acpi to cc - this is an acpi problem. > > What Justin is mysteriously referring to here is: > > > : From: "Justin Mattock" > : To: "Linux Kernel Mailing List" > : Cc: "Rafael J. Wysocki" > : Subject: GPE storm detected, disabling EC GPE > : Date: Thu, 5 Jun 2008 21:01:55 +0000 > : Sender: linux-kernel-owner@vger.kernel.org > : > : FWIW I noticed a post where the person had changed 5 to 20, and it > : seemed to work for them; > : So with that in mind I decide to give that a go, here is the location: > : drivers/acpi/ec.c > : @@ -527,47 +488,51 @@ static u32 acpi_ec_gpe_handler(void *data) > : { > : acpi_status status = AE_OK; > : struct acpi_ec *ec = data; > : u8 state = acpi_ec_read_status(ec); > : > : pr_debug(PREFIX "~~~> interrupt\n"); > : atomic_inc(&ec->irq_count); > : - if (atomic_read(&ec->irq_count) > 5) { > : + if (atomic_read(&ec->irq_count) > 20) { > : pr_err(PREFIX "GPE storm detected, disabling EC GPE\n"); > : ec_switch_to_poll_mode(ec); > : goto end; > : } > : > : Now I don't know if this will work for other brands, but for > : me(Macbook Pro ATI chipset) I have not received the > : GPE storm detected, disabling EC GPE message, but it's only been an > : hour, maybe after two or three this might appear. > : Also is this good or bad to set 5 to 20 for the system? > > Could someone from acpi land please help here? > > Justin, has this machine always had this problem or is it something > which earlier kernels handled correctly? > > Thanks. > This issue just recently started, 2.6.25-rc9 and below don't give me this message. -- Justin P. Mattock