From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752297AbZDORnz (ORCPT ); Wed, 15 Apr 2009 13:43:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751770AbZDORnp (ORCPT ); Wed, 15 Apr 2009 13:43:45 -0400 Received: from rv-out-0506.google.com ([209.85.198.229]:25964 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751503AbZDORno convert rfc822-to-8bit (ORCPT ); Wed, 15 Apr 2009 13:43:44 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=QhRtmcXQvVwVk2oY2lujFDMiCD1e1xz+xBJgxdCAFQGZV0sm+tF0ZuG28APSp6uv63 MWrXGV930/N1EHdzq43L48vqKZoqp6gQcFt/eBCqrcS7ntmAGbrsQ2RBcuNNm6SkNVY/ kfRi9ZMNPzRIm9J1JUwt9uDLWr0FkNwKAOg8Q= MIME-Version: 1.0 In-Reply-To: <49E603A9.2010004@oracle.com> References: <49E603A9.2010004@oracle.com> Date: Wed, 15 Apr 2009 10:43:43 -0700 Message-ID: Subject: Re: [alsa-devel] [PATCH] add missing definitions(letters) to HD-Audio.txt From: Justin Mattock To: Randy Dunlap Cc: Takashi Iwai , Linux Kernel Mailing List , alsa-devel@alsa-project.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 15, 2009 at 8:56 AM, Randy Dunlap wrote: > Justin Mattock wrote: >> On Wed, Apr 15, 2009 at 4:03 AM, Takashi Iwai wrote: >>> At Tue, 14 Apr 2009 14:31:21 -0700, >>> Justin Mattock wrote: >>>> impact: Add missing definitions(letters). >>>> >>>> Signed-off-by: Justin P. Mattock >>> Thanks, applied now. >>> >>> (BTW, your patch couldn't be applied cleanly, partly because of >>>  a wrong format and partly because of your MUA breaking the lines...) >>> >>> >>> Takashi >>> >>>> --- >>>>  Documentation/sound/alsa/HD-Audio.txt | 3 +++ >>>>  1 files changed,3 insertions(+),0 deletions(-) >>>> >>>> =========================================================================================== >>>> ---- Documentation/sound/alsa/HD-Audio.txt        2009-04-14 >>>> 17:03:14.000000000 -0700 >>>> ++++ Documentation/sound/alsa/HD-Audio.txt        2009-04-14 >>>> 21:15:22.000000000 -0700 >>>> @@ -162,7 +162,7 @@ >>>>  What `model` option values are available depends on the codec chip. >>>>  Check your codec chip from the codec proc file (see "Codec Proc-File" >>>>  section below).  It will show the vendor/product name of your codec >>>> -chip.  Then, see Documentation/sound/alsa/HD-Audio-Modelstxt file, >>>> +chip.  Then, see Documentation/sound/alsa/HD-Audio-Models.txt file, >>>>  the section of HD-audio driver.  You can find a list of codecs >>>>  and `model` options belonging to each codec.  For example, for Realtek >>>>  ALC262 codec chip, pass `model=ultra` for devices that are compatible >>>> @@ -170,7 +170,7 @@ >>>> >>>>  Thus, the first thing you can do for any brand-new, unsupported and >>>>  non-working HD-audio hardware is to check HD-audio codec and several >>>> -different `model` option values.  If you have a luck, some of them >>>> +different `model` option values.  If you have any luck, some of them >>>>  might suit with your device well. >>>> >>>>  Some codecs such as ALC880 have a special model option `model=test`. >>>> >>>> -- >> >> I went diff -u file.old file.new >> (I'm not sure how to generate the >> 1 files changed,2 etc... stuff) > > It's listed in Documentation/SubmittingPatches:  /diffstat/ > along with the expected patch format etc. > Please read/use it. > >> And yes I will be honest I didn't test the patch. >> (figured it wasn't that complicated, and I was tired). >> >> If I find more I'll let you know. >> (back to trying to get sound working on my imac). > > > -- > ~Randy > alright. -- Justin P. Mattock