mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Justin Mattock <justinmattock@gmail.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Matthew Wilcox <matthew@wil.cx>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux PCI <linux-pci@vger.kernel.org>
Subject: Re: pci 0000:01:00.0: BAR 6: no parent found for of device  [0xfffe0000-0xffffffff]
Date: Wed, 24 Jun 2009 13:41:03 -0700	[thread overview]
Message-ID: <dd18b0c30906241341r387dcaaaie437df2ff28ae1d8@mail.gmail.com> (raw)
In-Reply-To: <20090624130441.1c25c40e@jbarnes-g45>

On Wed, Jun 24, 2009 at 1:04 PM, Jesse Barnes<jbarnes@virtuousgeek.org> wrote:
> On Wed, 24 Jun 2009 13:50:30 -0600
> Matthew Wilcox <matthew@wil.cx> wrote:
>
>> On Wed, Jun 24, 2009 at 09:30:07PM +0200, Rafael J. Wysocki wrote:
>> > (Adding CC to linux-pci)
>>
>> Thanks Rafael.
>>
>> > On Wednesday 24 June 2009, Justin Mattock wrote:
>> > > (just pulled the latest git)
>> > > And am seeing this:
>> >
>> > Where pci 0000:01:00.0 and 0000:02:00.0 are what?
>> >
>> > > [    0.696001] pci 0000:01:00.0: BAR 6: no parent found for of
>> > > device [0xfffe0000-0xffffffff]
>>
>> So the message is coming from pci_claim_resource, and
>> if you bother to bisect, you'll track it back to my commit
>> a76117dfd687ec4be0a9a05214f3009cc5f73a42 .  What's going on here,
>> since this is BAR 6, is we have a ROM which has been mapped high, and
>> then not unmapped.  The BAR doesn't fit in the parent's window, so
>> the code is rightly declining to allocate the BAR.
>>
>> Before my patch, we silently didn't allocate the BARs.  Now we print
>> a message.  I wonder what to do ... we could silence this warning in
>> pci_claim_resource (patch below).  Or we could declare this to be a
>> bug, and fix it by disabling the ROM BAR (by clearing bit 0).
>>
>> I'm agnostic ... anyone have any preferences?
>
> Well, given that sometimes the ROM is important, it seems like an
> error.  Really we should be smarter about re-allocating things as
> necessary...
>
> --
> Jesse Barnes, Intel Open Source Technology Center
>

I guess the easiest would be to silence the problem,
(but personally I don work that way)
So I opt for the second choice:
we could declare this to be a
bug, and fix it by disabling the ROM BAR (by clearing bit 0).

So If and when, I can test out a patch.

-- 
Justin P. Mattock

  reply	other threads:[~2009-06-24 20:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-24 17:27 Justin Mattock
2009-06-24 19:30 ` Rafael J. Wysocki
2009-06-24 19:50   ` Matthew Wilcox
2009-06-24 20:04     ` Jesse Barnes
2009-06-24 20:41       ` Justin Mattock [this message]
2009-06-24 19:32 ` Jesse Barnes
2009-06-24 19:42   ` Justin Mattock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd18b0c30906241341r387dcaaaie437df2ff28ae1d8@mail.gmail.com \
    --to=justinmattock@gmail.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®