From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52A8FC43462 for ; Wed, 31 Mar 2021 15:09:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F17161019 for ; Wed, 31 Mar 2021 15:09:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235787AbhCaPJN (ORCPT ); Wed, 31 Mar 2021 11:09:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:50192 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236245AbhCaPIr (ORCPT ); Wed, 31 Mar 2021 11:08:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617203327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A/QE8tuUwF3/9UG7nfFS4bNTclmFVRAAjghkmKZ6ca4=; b=dRrW3mY1K6e85LI7eazhut3zD6ZnAwK4ucPfQ46ueeUfvanSCAT+xnV/ZttGZWXKLHgc8M NUc+NtiY4VmNWdRohp5SUUT2B9psOiM5FKAwELrP9ndZyJ3rnsdOUVfCV5n3L7rDUkr6uZ 9/MPRu6c13VK4XTc2QQWxH1Ld8irZI4= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-74-0-SSaoLVNRyAtChz0NeFdg-1; Wed, 31 Mar 2021 11:08:45 -0400 X-MC-Unique: 0-SSaoLVNRyAtChz0NeFdg-1 Received: by mail-wr1-f71.google.com with SMTP id n16so1168351wro.1 for ; Wed, 31 Mar 2021 08:08:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=A/QE8tuUwF3/9UG7nfFS4bNTclmFVRAAjghkmKZ6ca4=; b=pqOhvTvV44CiJKgheL3mDytBhSG1w2hARGnH1S4OSIHEwzvzLBzuTpc/v/2ijSsbLV d5EGGZCbDKsuJo5SfxqEU9TO3L2juwk2mAfdnyl1GwMFSliWnMQTNpUFjfrFBouOi6+v eWvZurfpD5eQ59NPUSktkSfww6XSWjYIe3eixwFK+/TAiRbxxKy70B2ZhovpwksP5e1N 7gW2KYJWNxhjiFDnPgDudMGjNAo8ZvVCybsrNBGmX/C573IaTgNqGiJhFhhVxgILVpq+ 3c491HJpW5fwpmhl0TW98DZ+K8pDuoqx+7EdAqNGaTs/JnvG5mQAfVs//XOoMTXfuaXl HvBA== X-Gm-Message-State: AOAM5330BDEDHQZw0j6uNa+NTWn20F36H87JvIsGi4a1surCycekXMIt LUf6OwStJoGi5NLO1QAo02rzffzzRl6ksCkJwhe5c9+rZn52cnIYw8uqGUTY3ELpMejZA+X6OMq EOP0ZQ3Iem5ilp3Cg/99z6j3IgJ1oLe9JlHe3UJUb5gToBkKkyA89xTkA2NZfJNNSDFMCrnXV2s jT X-Received: by 2002:adf:d1c5:: with SMTP id b5mr4239838wrd.126.1617203323577; Wed, 31 Mar 2021 08:08:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBkZdQOSyP0wfJpEJ/0RVQ91TnwGDMX5iv06fUFsp5bXFQ/A/sgCOP8epfRCPLQhWJUgT55Q== X-Received: by 2002:adf:d1c5:: with SMTP id b5mr4239816wrd.126.1617203323381; Wed, 31 Mar 2021 08:08:43 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id h25sm5837358wml.32.2021.03.31.08.08.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Mar 2021 08:08:42 -0700 (PDT) Subject: Re: [PATCH v3 0/2] KVM: x86: hyper-v: Fix TSC page update after KVM_SET_CLOCK(0) call To: Vitaly Kuznetsov , kvm@vger.kernel.org Cc: Sean Christopherson , Wanpeng Li , Jim Mattson , Marcelo Tosatti , linux-kernel@vger.kernel.org References: <20210331124130.337992-1-vkuznets@redhat.com> From: Paolo Bonzini Message-ID: Date: Wed, 31 Mar 2021 17:08:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210331124130.337992-1-vkuznets@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/03/21 14:41, Vitaly Kuznetsov wrote: > Changes since v2: > - Fix the issue by using master_kernel_ns/get_kvmclock_base_ns() instead of > get_kvmclock_ns() when handling KVM_SET_CLOCK. > - Rebase on Paolo's "KVM: x86: fix lockdep splat due to Xen runstate > update" series and use spin_lock_irq()/spin_unlock_irq() [Paolo] > > Original description: > > I discovered that after KVM_SET_CLOCK(0) TSC page value in the guest can > go through the roof and apparently we have a signedness issue when the > update is performed. Fix the issue and add a selftest. > > Vitaly Kuznetsov (2): > KVM: x86: Prevent 'hv_clock->system_time' from going negative in > kvm_guest_time_update() > selftests: kvm: Check that TSC page value is small after > KVM_SET_CLOCK(0) > > arch/x86/kvm/x86.c | 19 +++++++++++++++++-- > .../selftests/kvm/x86_64/hyperv_clock.c | 13 +++++++++++-- > 2 files changed, 28 insertions(+), 4 deletions(-) > Queued, thanks. Paolo