mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vasant Hegde <vasant.hegde@amd.com>
To: Ruoyu Wang <ruoyuw560@gmail.com>, Joerg Roedel <joro@8bytes.org>,
	Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
	Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Jason Gunthorpe <jgg@ziepe.ca>, Wei Huang <wei.huang2@amd.com>
Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/amd: Fix PCI device reference leak in PPR handling
Date: Sat, 22 Aug 2026 19:39:54 +0530	[thread overview]
Message-ID: <dd1d8d3b-030f-45bd-aaa7-e8760268b2dd@amd.com> (raw)
In-Reply-To: <20260814133938.1385879-1-ruoyuw560@gmail.com>



On 8/14/2026 7:09 PM, Ruoyu Wang wrote:
> [You don't often get email from ruoyuw560@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> pci_get_domain_bus_and_slot() takes a reference on the returned PCI
> device. iommu_call_iopf_notifier() fails to release it after either
> reporting a valid PPR fault or completing a rejected request. Each
> handled request therefore leaks a reference and can prevent the PCI
> device from being released.
> 
> Call pci_dev_put() after the final use of the lookup reference on both
> paths.

This was recently fixed by commit af3b69b16383.

-Vasant


  parent reply	other threads:[~2026-08-22 14:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14 13:39 Ruoyu Wang
2026-08-16 14:48 ` Markus Elfring
2026-08-22 14:09 ` Vasant Hegde [this message]
2026-08-23  6:20   ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd1d8d3b-030f-45bd-aaa7-e8760268b2dd@amd.com \
    --to=vasant.hegde@amd.com \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@ziepe.ca \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=ruoyuw560@gmail.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=wei.huang2@amd.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®