From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E9CC30EF88 for ; Tue, 13 Jan 2026 19:51:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768333913; cv=none; b=NSWqRk2uEQd5jo1Mez3C/kH9fMV+FgISwS2Nos02D6nKzgfX7SA+4P14PVJnqnp1Tw1FJG7rqQLlpQf+asjEa/5h8/Qggj0+q4W9ylWVNBx3o14dLlWuTQLsp/jGNIGrrVpVJwACraT09DXmbqXRFyRDz4yYftNwa++TC/xFLOw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768333913; c=relaxed/simple; bh=zRIffyaOvjED6xMKcvOp8Na2Lv842tUD9UTt3e8ABQ4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BsGOxmmt0d+z86WqyC1RkBfR4bKJCkEbHSWGOS2EAljDTBYydoHkD69mksC0W0wT7cvdH2XsPZFagxRw+kAGwSXqDhPxP4U+hRab68GYsqFhs/7jJk/1Qv1EGPcmRNIsmoDgX6G/kUdkOhfjQv59T1hy8eZEIHV8SWJVmPotp4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Sp1hX+da; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Sp1hX+da" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-477619f8ae5so59330215e9.3 for ; Tue, 13 Jan 2026 11:51:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1768333910; x=1768938710; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=FMbDmZKI5cb2u07kpKeASbvMWOPA0DZS64gMvOkNgOU=; b=Sp1hX+daa8eFzNfWwfF6gHr6ly+wufSmt2ROXMY8+3lSCgBQ37wk5q+hwrr/D9VXHN 8vnqmEfowOAp8lPZx9TmWV7AmE6FphphzBvR+eYaEHUCuZgvMDSrtXi/V7BOB9f07cLm qFv2RY6sDNxuMFjgUkdLVxyYS0RZDsFdzsG371Ol/VOhhMqWIm1/W4xIFWirXckJlOWD Y8hpU1/GkvTcfvoWEFhjOCvFrjxM3FPuSYbklerWtFmj056NuO0VNFOgUDGYf2vB3uUZ DZCHnIfLLP3IRwP+ivt9FtrnF+T/M4B7sVlYIlj3oCNDsPogn0xW5GlBDk46NF9QaJZk rqkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768333910; x=1768938710; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FMbDmZKI5cb2u07kpKeASbvMWOPA0DZS64gMvOkNgOU=; b=IlrnAzopc7UoxPIKpFt0K9wtWOY6KccLwi0xE9RC5WJRqggWSG+EieS/9aH9jWFFNj Q0oY3AY9oIkXXenQS0nuWGGtc4OCebAo5zuUdJfHbecY+d7PDLpG1DUw2VuZWOmF0BYL 0FJjwp7VpY5fyzLEmfgQzjZYWMS9Q9uz+P8PtbfLqWUKXv0koGr3gaLSDHKMPWiegSEV wybG7B8Sr1nF2+g18Jsup/SlkqURUCwkpQ3i2a4lOLMZsPuuzlDhDWNTVD8yPN6KcHQC IPPoKHcYk+w8xs0+4ubz+yvdB90XoiLu2GoU7pKhTk4/cKv4xPO7wBEXadyuKz5peYA0 Ierw== X-Forwarded-Encrypted: i=1; AJvYcCVkq2YN7ZdAvRbiBsN3W2BGQzbsdg/oASUtTsuRAIkCbXEQjA8OOBeK5rpQssMx+84IuDaDHWLYhDATZjw=@vger.kernel.org X-Gm-Message-State: AOJu0YzwUWL/mXgOKm3vRnsUO9DRKw5cAV2ipJjIGnwO6hQwSojOjIm6 nN5am4X5mXMNHnM/cMB0RuvbUrtBvEWm7ZhhoURZcowcFd23tWYsTuv3pZaLDbwsahM= X-Gm-Gg: AY/fxX79jDpuggkiLpi94SKUlqrOXbOIvAvEmf+ZtEzW3Af3/+IHPwU+ajD4vaki6na XjHfVHvDduCmIG8NFG54hklmWRJV1AAJ2wXdFB6ygBAOW83tEsPr7bIxXOJroYzfuvX0A4ZJm8W FT1lfCz7J9DyIVWesCsiZkmJgkJR1G0sTh2VmIaUaOUZPvPK58xfCU4D/ej+qRbZqMSn/avRfea NxIIMijMVfDlOtgzurWh9kabhUHMCWBcbNs/PB3aswMViQcH8kdkIQZ5w2TtOIfdrSNSj9guVqH THx/BksQSozV+ePCIjpxydyNbXfkcTl3BYGJVZ9VtTqLQOf2fGE/forTaIj/rVHPTeUy4GRVH30 6VkWwYJ7T+mLji/k5ZpHeuUJbjR28EJKXvNqz5WdFAcNuj9D1mryKwWqAdMwtfrFd60pR+3Tfh/ Hdkgr9ImoB6HB0s6oBMr6BWfRspw17sRsMHsOH X-Received: by 2002:a05:600c:8506:b0:477:1bb6:17de with SMTP id 5b1f17b1804b1-47ee33a646emr3823215e9.30.1768333909936; Tue, 13 Jan 2026 11:51:49 -0800 (PST) Received: from [192.168.0.20] (nborisov.ddns.nbis.net. [85.187.217.240]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47eda93feb3sm53176345e9.13.2026.01.13.11.51.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 11:51:49 -0800 (PST) Message-ID: Date: Tue, 13 Jan 2026 21:51:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: =?UTF-8?B?UmU6IOetlOWkjTog562U5aSNOiDnrZTlpI06IFvlpJbpg6jpgq7ku7Zd?= =?UTF-8?Q?_Re=3A_=5BPATCH=5D_x86/mce=3A_Fix_timer_interval_adjustment_after?= =?UTF-8?Q?_logging_a_MCE_event?= To: Borislav Petkov Cc: "Luck, Tony" , "Li, Rongqing" , Thomas Gleixner , Ingo Molnar , Dave Hansen , "x86@kernel.org" , "H . Peter Anvin" , Yazen Ghannam , "Zhuo, Qiuxu" , Avadhut Naik , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" References: <268e2f0512db435685af987a2ba6893c@baidu.com> <20260113095111.GHaWYVj4Crd2z8oLp-@fat_crate.local> <39cfb093256f4da78fe0bc9e814ce5d0@baidu.com> <20260113124837.GHaWY_JVdFi53mh6oO@fat_crate.local> <20260113191351.GQaWaZb6yzj4a9I_0Z@fat_crate.local> <6feff2b3-6088-412c-b0c6-1d32aa5a9d50@suse.com> <20260113193327.GCaWaeB1rp7HCFJBHV@fat_crate.local> <20260113194438.GRaWagpmRGD0qGx9az@fat_crate.local> From: Nikolay Borisov Content-Language: en-US Autocrypt: addr=nik.borisov@suse.com; keydata= xsFNBGcrpvIBEAD5cAR5+qu30GnmPrK9veWX5RVzzbgtkk9C/EESHy9Yz0+HWgCVRoNyRQsZ 7DW7vE1KhioDLXjDmeu8/0A8u5nFMqv6d1Gt1lb7XzSAYw7uSWXLPEjFBtz9+fBJJLgbYU7G OpTKy6gRr6GaItZze+r04PGWjeyVUuHZuncTO7B2huxcwIk9tFtRX21gVSOOC96HcxSVVA7X N/LLM2EOL7kg4/yDWEhAdLQDChswhmdpHkp5g6ytj9TM8bNlq9I41hl/3cBEeAkxtb/eS5YR 88LBb/2FkcGnhxkGJPNB+4Siku7K8Mk2Y6elnkOctJcDvk29DajYbQnnW4nhfelZuLNupb1O M0912EvzOVI0dIVgR+xtosp66bYTOpX4Xb0fylED9kYGiuEAeoQZaDQ2eICDcHPiaLzh+6cc pkVTB0sXkWHUsPamtPum6/PgWLE9vGI5s+FaqBaqBYDKyvtJfLK4BdZng0Uc3ijycPs3bpbQ bOnK9LD8TYmYaeTenoNILQ7Ut54CCEXkP446skUMKrEo/HabvkykyWqWiIE/UlAYAx9+Ckho TT1d2QsmsAiYYWwjU8igXBecIbC0uRtF/cTfelNGrQwbICUT6kJjcOTpQDaVyIgRSlUMrlNZ XPVEQ6Zq3/aENA8ObhFxE5PLJPizJH6SC89BMKF3zg6SKx0qzQARAQABzSZOaWtvbGF5IEJv cmlzb3YgPG5pay5ib3Jpc292QHN1c2UuY29tPsLBkQQTAQoAOxYhBDuWB8EJLBUZCPjT3SRn XZEnyhfsBQJnK6byAhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJECRnXZEnyhfs XbIQAJxuUnelGdXbSbtovBNm+HF3LtT0XnZ0+DoR0DemUGuA1bZAlaOXGr5mvVbTgaoGUQIJ 3Ejx3UBEG7ZSJcfJobB34w1qHEDO0pN9orGIFT9Bic3lqhawD2r85QMcWwjsZH5FhyRx7P2o DTuUClLMO95GuHYQngBF2rHHl8QMJPVKsR18w4IWAhALpEApxa3luyV7pAAqKllfCNt7tmed uKmclf/Sz6qoP75CvEtRbfAOqYgG1Uk9A62C51iAPe35neMre3WGLsdgyMj4/15jPYi+tOUX Tc7AAWgc95LXyPJo8069MOU73htZmgH4OYy+S7f+ArXD7h8lTLT1niff2bCPi6eiAQq6b5CJ Ka4/27IiZo8tm1XjLYmoBmaCovqx5y5Xt2koibIWG3ZGD2I+qRwZ0UohKRH6kKVHGcrmCv0J YO8yIprxgoYmA7gq21BpTqw3D4+8xujn/6LgndLKmGESM1FuY3ymXgj5983eqaxicKpT9iq8 /a1j31tms4azR7+6Dt8H4SagfN6VbJ0luPzobrrNFxUgpjR4ZyQQ++G7oSRdwjfIh1wuCF6/ mDUNcb6/kA0JS9otiC3omfht47yQnvod+MxFk1lTNUu3hePJUwg1vT1te3vO5oln8lkUo9BU knlYpQ7QA2rDEKs+YWqUstr4pDtHzwQ6mo0rqP+zzsFNBGcrpvIBEADGYTFkNVttZkt6e7yA LNkv3Q39zQCt8qe7qkPdlj3CqygVXfw+h7GlcT9fuc4kd7YxFys4/Wd9icj9ZatGMwffONmi LnUotIq2N7+xvc4Xu76wv+QJpiuGEfCDB+VdZOmOzUPlmMkcJc/EDSH4qGogIYRu72uweKEq VfBI43PZIGpGJ7TjS3THX5WVI2YNSmuwqxnQF/iVqDtD2N72ObkBwIf9GnrOgxEyJ/SQq2R0 g7hd6IYk7SOKt1a8ZGCN6hXXKzmM6gHRC8fyWeTqJcK4BKSdX8PzEuYmAJjSfx4w6DoxdK5/ 9sVrNzaVgDHS0ThH/5kNkZ65KNR7K2nk45LT5Crjbg7w5/kKDY6/XiXDx7v/BOR/a+Ryo+lM MffN3XSnAex8cmIhNINl5Z8CAvDLUtItLcbDOv7hdXt6DSyb65CdyY8JwOt6CWno1tdjyDEG 5ANwVPYY878IFkOJLRTJuUd5ltybaSWjKIwjYJfIXuoyzE7OL63856MC/Os8PcLfY7vYY2LB cvKH1qOcs+an86DWX17+dkcKD/YLrpzwvRMur5+kTgVfXcC0TAl39N4YtaCKM/3ugAaVS1Mw MrbyGnGqVMqlCpjnpYREzapSk8XxbO2kYRsZQd8J9ei98OSqgPf8xM7NCULd/xaZLJUydql1 JdSREId2C15jut21aQARAQABwsF2BBgBCgAgFiEEO5YHwQksFRkI+NPdJGddkSfKF+wFAmcr pvICGwwACgkQJGddkSfKF+xuuxAA4F9iQc61wvAOAidktv4Rztn4QKy8TAyGN3M8zYf/A5Zx VcGgX4J4MhRUoPQNrzmVlrrtE2KILHxQZx5eQyPgixPXri42oG5ePEXZoLU5GFRYSPjjTYmP ypyTPN7uoWLfw4TxJqWCGRLsjnkwvyN3R4161Dty4Uhzqp1IkNhl3ifTDYEvbnmHaNvlvvna 7+9jjEBDEFYDMuO/CA8UtoVQXjy5gtOhZZkEsptfwQYc+E9U99yxGofDul7xH41VdXGpIhUj 4wjd3IbgaCiHxxj/M9eM99ybu5asvHyMo3EFPkyWxZsBlUN/riFXGspG4sT0cwOUhG2ZnExv XXhOGKs/y3VGhjZeCDWZ+0ZQHPCL3HUebLxW49wwLxvXU6sLNfYnTJxdqn58Aq4sBXW5Un0Q vfbd9VFV/bKFfvUscYk2UKPi9vgn1hY38IfmsnoS8b0uwDq75IBvup9pYFyNyPf5SutxhFfP JDjakbdjBoYDWVoaPbp5KAQ2VQRiR54lir/inyqGX+dwzPX/F4OHfB5RTiAFLJliCxniKFsM d8eHe88jWjm6/ilx4IlLl9/MdVUGjLpBi18X7ejLz3U2quYD8DBAGzCjy49wJ4Di4qQjblb2 pTXoEyM2L6E604NbDu0VDvHg7EXh1WwmijEu28c/hEB6DwtzslLpBSsJV0s1/jE= In-Reply-To: <20260113194438.GRaWagpmRGD0qGx9az@fat_crate.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 13.01.26 г. 21:44 ч., Borislav Petkov wrote: > On Tue, Jan 13, 2026 at 09:37:13PM +0200, Nikolay Borisov wrote: >> Yes, and why is Li's approach not working, i.e if mc_poll_banks() returns a >> value signalling "i found an MCE" we halve, otherwise we double it? > > It might be "working" but I don't like that "bool logged" thing and > marshalling it back'n'forth. This should be waaay simpler. > >> That's certainly doable, but why should the interval setting be coupled to >> the initial notifier and not to mc_poll_banks? > > What's the difference who notifies the timer? The banks polling will call the > notifier if it finds an error to log. > > But before we do any of that, we need to figure out what commit broke this so > that we fix stable. > > Thx. > grepping around points to your 011d82611172 ("RAS: Add a Corrected Errors Collector"). Because looking at the commit log of my 6447828875b7 ("x86/mce/inject: Remove call to mce_notify_irq()") I mention that mce_need_notify got introduced in your commit and it was called "notify_user" before that. Before your commit in mce_log there was an explicit set_bit(mce_need_notify) call .