From: David Laight <David.Laight@ACULAB.COM>
To: 'Guenter Roeck' <linux@roeck-us.net>, Tom Rix <trix@redhat.com>,
"Michael Walle" <michael@walle.cc>, Xu Yilun <yilun.xu@intel.com>,
Jean Delvare <jdelvare@suse.com>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH v3 1/2] hwmon: introduce hwmon_sanitize_name()
Date: Tue, 5 Apr 2022 08:20:09 +0000 [thread overview]
Message-ID: <dd24d0ecc84e4576bfde16d80d971f88@AcuMS.aculab.com> (raw)
In-Reply-To: <25517c15-30f6-fbc5-5731-44c41ef904c7@roeck-us.net>
From: Guenter Roeck
> Sent: 05 April 2022 00:31
...
> >> /**
> >> * hwmon_is_bad_char - Is the char invalid in a hwmon name
> >
> > This still needed in *.h ?
> >
>
> Yes, because it is used by out-of-tree drivers. We can only move
> that into hwmon.c after all users are gone.
And drivers might want to 'sanitize' a copy of the name without
reallocating it.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2022-04-05 10:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 18:43 [PATCH v3 0/2] hwmon: introduce hwmon_sanitize() Michael Walle
2022-04-04 18:43 ` [PATCH v3 1/2] hwmon: introduce hwmon_sanitize_name() Michael Walle
2022-04-04 23:14 ` Tom Rix
2022-04-04 23:31 ` Guenter Roeck
2022-04-05 8:20 ` David Laight [this message]
2022-04-04 18:43 ` [PATCH v3 2/2] hwmon: intel-m10-bmc-hwmon: use devm_hwmon_sanitize_name() Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd24d0ecc84e4576bfde16d80d971f88@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=jdelvare@suse.com \
--cc=kuba@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®