From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B054C18AE2 for ; Mon, 6 Apr 2026 07:29:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775460592; cv=none; b=ipPXFFeu6plF4u0npopivb6ZbBdZoWOPafQH3UDVKlmPMhT/aLi4jQzbI13YHQ6BCXN29TdwOYC1qO34fti4KDKfG5++EgVzDjs/iw3/ikAhJPADVo+MgXmVblFDnAFtfh7Ds8SAqKTQIX1vJ+TF9mRDzu0u/imEGXCG7aY2PsY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775460592; c=relaxed/simple; bh=QN5KldYd1+uFod0woVvjfeFZ8kyDw7udiJjsHsGxIlU=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=OpeSAosp7RVQuKvVqH0bUvBtvonqSNVp5pXDkDI7oQ2aeXYAmak54hxcNzL9X3X7ibnsMqcOPLYfTY1MuFJ67GSv0CYhuD1TX8ovkJRwXTeRyrW5fI1FfPGjROpEhkWoG4MX7wGDuHnb5W6hngFOEvk+Q0Ygay62I7sMG1PGQmY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DyQWfkVD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DmM6ysUY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DyQWfkVD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DmM6ysUY" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 635L6H103631110 for ; Mon, 6 Apr 2026 07:29:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= G80EJy28BYwA6nOEe/oB2Z2qDbtqNvwKYFonsnpZaRc=; b=DyQWfkVDsqqkZ5en e0RGDHs7955n4mQY5R8aeMJNerMpRSjvFXpQP+FCLmV2H+zXMU1F2wdSrFl0jn8p v1cbLYw6F1at06DL6S6JgaORnlSnpP+9O8FilmVXnZtxZBFtizgnYcLeQkYNjHqU GfYG3iSY8pudAlElFYyhlsiQqiLfnhZcB4EmVFDMSsbTwYuM6PUAnR+UXV1c79Nd K5URqptdWxHfCRzw0XxOfKthu3kiAYoEVQF/Cilg3hSMNbZVmciiAGSo3R1wpb1S xydqhqnW8H+FoOcfcFseAegVN4VH3QevKTdJjN1xmkXcrvR+G2/XGe/j94MqRNi9 JOL8SQ== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dau14v9ys-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Apr 2026 07:29:49 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-35daf3d3030so3571396a91.1 for ; Mon, 06 Apr 2026 00:29:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775460588; x=1776065388; darn=vger.kernel.org; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=G80EJy28BYwA6nOEe/oB2Z2qDbtqNvwKYFonsnpZaRc=; b=DmM6ysUYwDV+Iwp7MaEuJlU4HsG/96gxfBB1bW7C04r/QKH43UErLhdSMwL6gLh5Zh 1608eiZmyy1VeZ0Nqn6WPtn0X32o4vMr2WDkO9ndpJm6G7PQBM2dqzDF8R6RG2un7oWa /jeKxgUV/z1c22XGCTsXG8c9RcXxrMNAn+7o8dO9GNCb45l0gZkG7GL7EpHq14Vr/kbM zuw3acmp37rLpQcZlHA+hJOejIukmz64WeCUXJ9PmP3ccTQTCJQpynoRXwUFC7Lljm4D 3GZrmniQr3lwpnwf/eHy2rQGMbdgk77S4WCE3kSFVie7fAH1gEJOQEqi5S1/3CT/UQLG 0EkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775460588; x=1776065388; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G80EJy28BYwA6nOEe/oB2Z2qDbtqNvwKYFonsnpZaRc=; b=oH/6NXcegOP9Va0iif9nrAVzdH+4YekR2tKfLyzjBPvouKdq4cZF9Ape96HGfWju0L AN2cJdFbC8lc2X4gpAf5IYeADrsbuQgFcSz1AyinkmF1NbyVWwbFtYxa8DGKoMl9+ixx mmkfxclGJCUeCm+gi1baCQ9bS+VxQ86ExfHnrZbw2Y/GiKanxDKm8x1N5mwiUCYWSOtX 9QS8OekdM0W7B7/tGOW2p7fpe5Qgtik2T7VpnF6578me7ikC9OkCRkC0sk/kUFI8yM84 feM4CtxXRk8QFYe1tw6umzw85aAO+weqVXhnNLPshIKHag3ISx4l1Fyr4sQqDQ1X9aK6 PehQ== X-Forwarded-Encrypted: i=1; AJvYcCUDjDOxWpcmWdBRPgCafiJXljoJQGi5CRMMxa9F5c08fNSCszRWygKAqVQFrNAUw+oP2SQEF+fcou37rtg=@vger.kernel.org X-Gm-Message-State: AOJu0YyiLC2d2aLXO+dkAW42QbIeatFq8MiJwdkXYlcP41IyjFMoXyK8 iZ9FA+KgGYw19LvdcwdEccXCT7tgzR+WefE3VGek80QriO3FDqbd/3EwFUMkb3S/D8yatsNqfrs 9Do2hSILaq2Sbdc3qGCgHphfzFIuw7G2waoNsquM1oH52v6aDVOapQsMECFR7uV80PEM8vpHkrK 0= X-Gm-Gg: AeBDieujJuWyzWn3/YQfR64wqF0mMYoPfcZNhdljoP5EWllRSh/r5GQMemH9qNfX5KX XD51SbDs44yubRhWSGl7p987XnbIZe+wa6DvUKwAbfaY5yG5X+aJPLHdTaXK2N63xclZCBWxVAw /LDoNYEsVCvnKrjNTI/8Km6ptHeSmM8rmPmn9EYbeDMctzSJiuw9abl7eAMDdqhUq+NJo+mWNYO 9yPAleHhHpRskp/tH8hPtwa+VzuTgBO+EeTvskD3y18O2oPxPDOuz+hxBvZT+YZdBYqLfJwwOSG 2cSaWOIR5WXERLWrwMmgTxusMNh/sJjO0gi5g7BVdiuVDiv2y5VkZ/OXfF/omZHTGI+yQurSKOv MFGJhliDJ//SNsOto1j29J/EY5/UDdc13MRHO1zftLmgIR3IyRg== X-Received: by 2002:a17:902:e845:b0:2ae:54b2:27c7 with SMTP id d9443c01a7336-2b28186dd62mr122048435ad.39.1775460588282; Mon, 06 Apr 2026 00:29:48 -0700 (PDT) X-Received: by 2002:a17:902:e845:b0:2ae:54b2:27c7 with SMTP id d9443c01a7336-2b28186dd62mr122048245ad.39.1775460587778; Mon, 06 Apr 2026 00:29:47 -0700 (PDT) Received: from [10.217.222.63] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2a488caa2sm17627745ad.14.2026.04.06.00.29.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Apr 2026 00:29:47 -0700 (PDT) Subject: Re: [PATCH] mmc: host: sdhci-msm: Fix the wrapped key handling To: Dmitry Baryshkov Cc: adrian.hunter@intel.com, ebiggers@kernel.org, abel.vesa@linaro.org, ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260403105949.1007447-1-neeraj.soni@oss.qualcomm.com> From: Neeraj Soni Message-ID: Date: Mon, 6 Apr 2026 12:59:43 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA2MDA3MCBTYWx0ZWRfXzrGg1etih48N +ARggXyvdUJNOlOxKwabRPvuktoIv0yfEBwjNnjd/2D63vmvvF8ED+uXgdq4t4yTwPI+5frbT86 i9x05qFIsuL1FliYeskvD8RgUR3hcB1QKRmlUXj4z6cL59frU4vt73lUJ7ASfC0Z1SzubaZf4No 5HvD+4gasL5XlWAuHb5KQ6gvIsJBM5+Xf2dPXftRw3qlRpFfhhFlFWBC39XKiPbDUZXc4kSVnW8 IydLV1NPhx/t6Ai/Vi9/AA3PIk0E+FU1NBB4G0SZBVXTsiTokYOYk/ZJXgKpmT73sUdlbTw+3V0 g8JJZ/6tx5TKKWCYi+2EzNia+1Xjp46xY0xSDTjRhvPd+kt2Gqytii4fvIAfx7OA/dS571Dr7Wh lJ8NQ7eBWriCHJstHOU7O5rEvRRIvWDakS4XCH0bf/+Wx4wlFGIXyVhyUMYtUKXE1JAUvhmnFSM H92Xey9Ars/0np/kViA== X-Proofpoint-ORIG-GUID: 0eLQ7CuBw-_4Kjx6YZ657ticyGnbNUbQ X-Proofpoint-GUID: 0eLQ7CuBw-_4Kjx6YZ657ticyGnbNUbQ X-Authority-Analysis: v=2.4 cv=Q9HfIo2a c=1 sm=1 tr=0 ts=69d360ed cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=8ToHcDrqECIu-RMY5UQA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-06_02,2026-04-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604060070 On 4/4/2026 1:30 AM, Dmitry Baryshkov wrote: > On Fri, Apr 03, 2026 at 04:29:49PM +0530, Neeraj Soni wrote: >> This change was originally intended to land with the patch series: >> "mmc: host: sdhci-msm: Add support for wrapped keys". The fix was present >> till v4 but was accidentally dropped in v5 while rebasing. > > Don't describe what is being changed or what was intended. Please > describe, why you are performing the change. I.e. what is broken. > Ack. > Also, likely you missed the Fixes tag. > The SHA-1 ID for "mmc: host: sdhci-msm: Add support for wrapped keys" is not yet available in tree so i did not add the "Fixes:" tag: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-changes >> >> Signed-off-by: Neeraj Soni >> >> --- >> The patch serirs "mmc: host: sdhci-msm: Add support for wrapped keys" >> was originally discussed here: https://lore.kernel.org/all/CAPDyKFqRG1_1aYavfrA0Ss85B0kcTnjVBeqLgq8PUJUcSx5LUg@mail.gmail.com/ >> --- >> drivers/mmc/host/sdhci-msm.c | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c >> index da356627d9de..df0a038269d4 100644 >> --- a/drivers/mmc/host/sdhci-msm.c >> +++ b/drivers/mmc/host/sdhci-msm.c >> @@ -1926,11 +1926,6 @@ static int sdhci_msm_ice_init(struct sdhci_msm_host *msm_host, >> if (IS_ERR_OR_NULL(ice)) >> return PTR_ERR_OR_ZERO(ice); >> >> - if (qcom_ice_get_supported_key_type(ice) != BLK_CRYPTO_KEY_TYPE_RAW) { >> - dev_warn(dev, "Wrapped keys not supported. Disabling inline encryption support.\n"); >> - return 0; >> - } >> - >> msm_host->ice = ice; >> >> /* Initialize the blk_crypto_profile */ >> -- >> 2.34.1 >> > Regards, Neeraj