From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4091C197A0 for ; Thu, 16 Nov 2023 17:21:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345203AbjKPRVC (ORCPT ); Thu, 16 Nov 2023 12:21:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231294AbjKPRU7 (ORCPT ); Thu, 16 Nov 2023 12:20:59 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A308F101; Thu, 16 Nov 2023 09:20:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=kK3KutISbyzM/gZLq4IFiwimjsmvHKjNrd1uA1A3zdk=; b=Cymw9iWCOK3pJBrbiAyPOtls8Y RFFPgN0hIKnaOnVu0b2o52K1veB+NB7Y5os8q3N+Ckf55ZTL9qZQWPMg5k5FBMNcaMX4XuT0Bfy9H 2W/x9f6h+sD3gqaoJ+tnwhp7MsWCEspFf9oK0sx7AZKfHXZuGLTOyjDzBGsJEQd89F4g=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1r3g2p-000NKU-Pf; Thu, 16 Nov 2023 18:20:47 +0100 Date: Thu, 16 Nov 2023 18:20:47 +0100 From: Andrew Lunn To: Jie Luo Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk, robert.marko@sartura.hr, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_srichara@quicinc.com Subject: Re: [PATCH 3/9] net: mdio: ipq4019: Enable GPIO reset for ipq5332 platform Message-ID: References: <20231115032515.4249-1-quic_luoj@quicinc.com> <20231115032515.4249-4-quic_luoj@quicinc.com> <33246b49-2579-4889-9fcb-babec5003a88@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33246b49-2579-4889-9fcb-babec5003a88@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > FYI, here is the sequence to bring up qca8084. > a. enable clock output to qca8084. > b. do gpio reset of qca8084. > c. customize MDIO address and initialization configurations. > d. the PHY ID can be acquired. This all sounds like it is specific to the qca8084, so it should be in the driver for the qca8084. Its been pointed out you can get the driver to load by using the PHY ID in the compatible. You want the SoC clock driver to export a CCF clock, which the PHY driver can use. The PHY driver should also be able to get the GPIO. So i think the PHY driver can do all this. Andrew