From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 133CEC04A6A for ; Mon, 7 Aug 2023 18:47:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229759AbjHGSrX (ORCPT ); Mon, 7 Aug 2023 14:47:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229494AbjHGSrV (ORCPT ); Mon, 7 Aug 2023 14:47:21 -0400 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46265171E for ; Mon, 7 Aug 2023 11:47:20 -0700 (PDT) Received: by mail-io1-xd32.google.com with SMTP id ca18e2360f4ac-780c89d1998so35461439f.1 for ; Mon, 07 Aug 2023 11:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1691434039; x=1692038839; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=+GHKAJRl9DdfBSMeyUURA1mbZ2wW50qlxotvyYewsAY=; b=OpkH8wumhnTMobl2+rFAWi6k/fNOlCrequUDfSB75wsgjy99E5Z0E6xhCCQQs+lAg+ LK3DxfHuSKPFvBzO3xPcxBQbsoNu7bWK3Z7WPZ32OBnbeettCfc09sLDapUmxYfrKwl3 J7HVA8L6mFHoGp7w/jTUpOBNGPEO1EwEc0hDc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691434039; x=1692038839; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+GHKAJRl9DdfBSMeyUURA1mbZ2wW50qlxotvyYewsAY=; b=D/O+oERDnzoIPZukhZyICpiSN0zLO7Uu1drd8hUhiII8M3mDi2R6hK8q6Bgn6wLX/R L0c62rBO6WzVfdkjgRugDvxfsE8mJhJXXr073Kb757YpV6bS01964X2KI1qAWsfkgyyH o6HrzhPWMI8Lyl3UJCQAoOkbsblHysic/0JOPu2YR//dUyt7kyMyVHCDzHBEHNVQHKW4 W5NgNQEWYMyjM8VQZI5hpBfOqOPFY0uBGUmdbH1BqY+VR63ZuvrX8MWjsqcYpBJtUXOD g28mSDXseJQV5eb+Ot+SPvZuA/V3qGc25vUibi2Dqi9LYTt1AmY1f1ptowp9eyVRdMYG rUlg== X-Gm-Message-State: AOJu0Yz1P5OVxkye/4lcUd4b7cdhfAm+05YjZfJjp00e2FVW96wHqjAU yA6Znkdl8RKOfz0z25TRs0heUg== X-Google-Smtp-Source: AGHT+IHEzbBWbyVa4jckC+DLAXiDracNAkcR8q327mXbiqHsYo+E0XfewTfbdlzUq/xZyHPxLJR8Bg== X-Received: by 2002:a92:dc84:0:b0:349:67b0:6045 with SMTP id c4-20020a92dc84000000b0034967b06045mr3887892iln.3.1691434039647; Mon, 07 Aug 2023 11:47:19 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id fr2-20020a056638658200b0042b0f3f9367sm2695724jab.129.2023.08.07.11.47.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Aug 2023 11:47:19 -0700 (PDT) Message-ID: Date: Mon, 7 Aug 2023 12:47:18 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v5 12/19] selftests/resctrl: Remove "malloc_and_init_memory" param from run_fill_buf() To: Reinette Chatre , =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= , linux-kselftest@vger.kernel.org, Shuah Khan , Shaopeng Tan , Fenghua Yu , Maciej Wieczor-Retman , linux-kernel@vger.kernel.org, Shuah Khan References: <20230717131507.32420-1-ilpo.jarvinen@linux.intel.com> <20230717131507.32420-13-ilpo.jarvinen@linux.intel.com> <7bba4db8-eaac-238d-b764-89d0ae2a9bba@linuxfoundation.org> <856ad175-26f8-90ea-d801-c722d2b19b2e@intel.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <856ad175-26f8-90ea-d801-c722d2b19b2e@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/25/23 09:26, Reinette Chatre wrote: > Hi Shuah, > > On 7/25/2023 7:49 AM, Shuah Khan wrote: >> WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 >> #233: FILE: tools/testing/selftests/resctrl/resctrl_tests.c:276: >> +        strcpy(benchmark_cmd[3], "0"); >> >> WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 >> #234: FILE: tools/testing/selftests/resctrl/resctrl_tests.c:277: >> +        strcpy(benchmark_cmd[4], ""); >> >> total: 0 errors, 2 warnings, 142 lines checked >> >> I am applying the patch set to linux-kselftest next - please fix >> the aboe and send a patch on top of linux-kselftest next > > Is strscpy() available to userspace? I found lib/strscpy_kunit.c > that makes me think this is currently only available to kernel code. > Very likely. You can ignore the comment. I already applied the series anyway. thanks, -- Shuah