From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29E0235DCF9 for ; Tue, 27 Jan 2026 15:28:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769527682; cv=none; b=Bbw+Z3+Lt+BRf5res2mNQ1PUyuNkHqMUAtSRQlKf+A83Zf7y94wx7tpd7mFEf+iTSADvv4eSGIuYXWWUmOukik5fHr3D3saPpk14JTihjEdpvVzRqkZYz3AVNHG7Q3ehUE1GUja/smUeueFtt26eHxSC7Or9bsssbJ138KwvcRY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769527682; c=relaxed/simple; bh=mA3lfUIVfHLOVf+ho8hZHEdeqNa4qFJDUf/4MtfcM1U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=axWGyAF7/yTkZGUTn7lBKiL/RfnC5haJy7v25iDzpH1z6c4tubhXSeSKyuE9jE2yHnCjIm63f2wTkcKnPEgV71WAXpSL96nl4xvFFTlu2I6PyUqgdM/ifCbRrI4P5K/YgOwRJrx3vO0HQTH4Cxm5x4IyrWvdjTC5vmi7xwu6RnA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=qrVBg0Ur; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="qrVBg0Ur" Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 60R2UM4S010558; Tue, 27 Jan 2026 15:27:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=TsIgwA BdSEhKUkUoppt8SzQBzP5f9/tmAP54E0NTvtY=; b=qrVBg0UrZOEAhPF+UkaCdB K9w1B5A9xuaGTqPRERIMkG8mvNlmAzZsaLVxoNpqUXqAJSe/XolY4SOVwkur/mid 9p8qwQR49e4X7Uxl8fY2YJz7bYVQ3sy6Owc2mGlkTmypSCu2GkOtGGw+zqiKRuyE gIa7li8mWt5GppmNGTLAA827sZ0+8yTIGTypekZEHObRMGoEbILf57pwPTa3Iq9o CHO3VMEqmfxHbbnpRzM+rDKQPpvKDcg8WVY2QGFunHPUsQ7gT7uRZEqDAEFEyR6n BbZgJcDsQSjAxdhqSSi5yEFvzeXVi7f9gprJpNtXsrXaNL+LotC49Uld1igAtATQ == Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4bvnrte353-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jan 2026 15:27:57 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 60RD5seQ031040; Tue, 27 Jan 2026 15:27:56 GMT Received: from smtprelay04.wdc07v.mail.ibm.com ([172.16.1.71]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4bw8dsh8mr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Jan 2026 15:27:56 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay04.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 60RFRto750135358 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Jan 2026 15:27:56 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B1D5A58056; Tue, 27 Jan 2026 15:27:55 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8933B58052; Tue, 27 Jan 2026 15:27:55 +0000 (GMT) Received: from [9.61.135.234] (unknown [9.61.135.234]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 27 Jan 2026 15:27:55 +0000 (GMT) Message-ID: Date: Tue, 27 Jan 2026 09:27:55 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 09/13] fsi: master: Convert to fsi bus probe mechanism To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= Cc: Ninad Palsule , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <17686d71b4ad3f7ebb63e92453273095a5dd09ea.1765279318.git.u.kleine-koenig@baylibre.com> Content-Language: en-US From: Eddie James In-Reply-To: <17686d71b4ad3f7ebb63e92453273095a5dd09ea.1765279318.git.u.kleine-koenig@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: H5LuQQnOHb78kIbCayusxHmIGztOKF0E X-Authority-Analysis: v=2.4 cv=Uptu9uwB c=1 sm=1 tr=0 ts=6978d97d cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=IpJZQVW2AAAA:8 a=b5RV9PlWv53PPLVq1LwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IawgGOuG5U0WyFbmm1f5:22 X-Proofpoint-ORIG-GUID: H5LuQQnOHb78kIbCayusxHmIGztOKF0E X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI3MDEyMSBTYWx0ZWRfXzbBUBcXOdfLh caj+78GRoKX9ikU9aRrALnDLIKtuBYSoSQxQMvV/7N/QN3c/iX/E4DFlUNSzaLnMY5G/M1MpIxP BPZ1xi1ZLdWSzWa4kch8NpGx3s+Ai5+FSxz2QULbP5rDAVcYLThN7YzkMcGtTdZK1eJlq9KuG2h uo6jRVTI25bqexI4f/sXloF8ZEaqMlsR4sbnCQ0z65h52dvh5qx7X7Xmoo0H1I8gRBFo5pePGyg CKMEfqgTq/ZmVrmTDLJQ/W1C6kJsR1KXXYYvsk/nWtvIWo7GOMYpBQ/9b2XYYBzAW5xhCnvF33L vGP7IZtqBAGy+E8VtsNjC1IfNZTO8EUjWRTsQwjjbARQTXaRONQrr6usoX6PUX3Lq3Tb0LIJ+h4 rPk17owD/YFQtcpstZkb6dLc3Q4q925LP9GvR49pPDHvrwWqyx2j3Y34ijCfIwX72WEuzhNBw6z qCbh2YsWPF1T8+xBahw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-27_03,2026-01-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 phishscore=0 adultscore=0 impostorscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2601150000 definitions=main-2601270121 On 12/9/25 5:40 AM, Uwe Kleine-König wrote: > The fsi bus got a dedicated probe function. Make use of that. This fixes > a runtime warning about the driver needing to be converted to the bus > probe method. Acked-by: Eddie James > > Signed-off-by: Uwe Kleine-König > --- > drivers/fsi/fsi-master-hub.c | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) > > diff --git a/drivers/fsi/fsi-master-hub.c b/drivers/fsi/fsi-master-hub.c > index d389856d18ac..a84955bb23b1 100644 > --- a/drivers/fsi/fsi-master-hub.c > +++ b/drivers/fsi/fsi-master-hub.c > @@ -192,9 +192,9 @@ static int hub_master_init(struct fsi_master_hub *hub) > return fsi_device_write(dev, FSI_MRESB0, ®, sizeof(reg)); > } > > -static int hub_master_probe(struct device *dev) > +static int hub_master_probe(struct fsi_device *fsi_dev) > { > - struct fsi_device *fsi_dev = to_fsi_dev(dev); > + struct device *dev = &fsi_dev->dev; > struct fsi_master_hub *hub; > uint32_t reg, links; > __be32 __reg; > @@ -235,7 +235,7 @@ static int hub_master_probe(struct device *dev) > hub->master.send_break = hub_master_break; > hub->master.link_enable = hub_master_link_enable; > > - dev_set_drvdata(dev, hub); > + fsi_set_drvdata(fsi_dev, hub); > > hub_master_init(hub); > > @@ -259,9 +259,9 @@ static int hub_master_probe(struct device *dev) > return rc; > } > > -static int hub_master_remove(struct device *dev) > +static void hub_master_remove(struct fsi_device *fsi_dev) > { > - struct fsi_master_hub *hub = dev_get_drvdata(dev); > + struct fsi_master_hub *hub = fsi_get_drvdata(fsi_dev); > > fsi_master_unregister(&hub->master); > fsi_slave_release_range(hub->upstream->slave, hub->addr, hub->size); > @@ -272,8 +272,6 @@ static int hub_master_remove(struct device *dev) > * the hub > */ > put_device(&hub->master.dev); > - > - return 0; > } > > static const struct fsi_device_id hub_master_ids[] = { > @@ -286,10 +284,10 @@ static const struct fsi_device_id hub_master_ids[] = { > > static struct fsi_driver hub_master_driver = { > .id_table = hub_master_ids, > + .probe = hub_master_probe, > + .remove = hub_master_remove, > .drv = { > .name = "fsi-master-hub", > - .probe = hub_master_probe, > - .remove = hub_master_remove, > } > }; >