From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EDB9242D65 for ; Mon, 14 Sep 2026 06:32:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789367565; cv=none; b=rd7qYZ5NujWrOnrG4bPVVS1f65dpDPh6IaA+2t0HhIALsZ7sJ4mRhpFibCsIMV/QHN28o+3nJTllUYSoTR8wxMgASJWaN8eVKex9zlOvUerFXzGgQCbkN73pJjBJCNUuMzcusd25CWTUysAxz8FzgN5UqtoHAkNVulV7kFh3k8Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789367565; c=relaxed/simple; bh=8P8agGseUBV/hQkxI7eBNwnlBJEbrU4dhhrXvN8aPPc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NiYdKCiji2iFY8is2/P9UP9cSCuURUIK7VxTc8d2lrMz9kZtACkltp3/Zr/0d5gRY79WaU0vRG+jx/2GvxDn8l10n2nOWem1fbeISMIy9KLGlTVHjDCzp7IeG+onwWl+m9i16S2wiIrYbzHbnkmz22SLjYNYBA0BHCuwFkM/6xg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=H6IzJbIy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=K5/xNmHe; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="H6IzJbIy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="K5/xNmHe" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68E5is6X4058214 for ; Mon, 14 Sep 2026 06:32:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Yxpww4PsWrQfLBdJ0//BJx7bMEXgGPZ3hXMqdr6a/8Q=; b=H6IzJbIyyEs2fDiW czjRwtavp+EgRixByOuyThU185VwMjb9guaErkjcMXQvPxn8MB/wrboXUuK9+UnG FhvKyaEcP300I9o/JMzR0GTjEUIvHCs1Ph2pdrM4zXVjjFZLqnPBxoj4Cgk0iyas K6sKbahwGAm10tJLHnHrgR4r1I3o1z0Ge5D9afzZ/U97f0x8oQvm4gDzgOJ/ltt2 gifOJpQ50wjsCC1KyBdbawizsrGETzDgEejWvTQFzp+djvRUDoKAoZmVvsBadMlA oKjSJYKQWZ7QWrwBRPpW/2WNHZDtheGpbqbi6XQxX3szETXcLDyiizNWCn+oY+a9 OpwIjQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gp3hss5ex-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 14 Sep 2026 06:32:42 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-3968bb86fb7so3585930a91.2 for ; Sun, 13 Sep 2026 23:32:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789367562; x=1789972362; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Yxpww4PsWrQfLBdJ0//BJx7bMEXgGPZ3hXMqdr6a/8Q=; b=K5/xNmHeFbr3D78ddnY51WmRmnytBI/wgAOxZz1q35RgzUn5gYo1gZT8SpkhVS+8Dj 9hzXNd6NkjJhrJteLDTsCXlkvcPJUiazBnyu3KY9vnHzpTKTOK2NtUdLb2dehzDtXW/q oe1Yd1LtqSi9TDMljhMYqWruJbbkmTpMD9uRzzED9PzVlLs2hY0BZ2sYnLWTq7EGa/sV CNHrRZ9GEUwr+n95yzZKOOEck0D3UO8ide8DdtusXeRD+jsNZyxj1nJEjrED0U2s3lqu 8LFPHvTBjHrs0bKRy7Nrb42lhgdzts9WrRIP+0TxoXUHrjpihicd0P8QlNn+3Psafr5s J/qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789367562; x=1789972362; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Yxpww4PsWrQfLBdJ0//BJx7bMEXgGPZ3hXMqdr6a/8Q=; b=gbvB3DBKM6bqPLY7Y+DWhseh9AtjE6dAVnSkQIPMBEh35nYZC7MSOASKsG3USYZAdw UP4OKVK26rsr/5n+b8WKAqa0MmiNiX5xdVvnsnMQE9MhEj8PVF/YWS004zTjmToNvFuh 3Dtq6zs46EGRGsYj67Q7wAJl1kHxivfKN9LT9e06hWec4Lhb2gUOs04EEBFDdq6L8C4s pci/hxFiwcps5ENaMdkPYaxkxfdwXo/jCBCckgCK7PE2OTfHHtsz4n+Ufv++kPu7ryf9 ukDacCWTizW43M8HFWnRzgJgJEp0yZ318mgrtt/k0e241++KBVEQ67rr6tmeLhuz1INl NRsA== X-Forwarded-Encrypted: i=1; AKwUvBy9Z714OVYCGwL/FvEMfmBNRMmeBfBpPUqSkP3iN2twZ22jtgS61nKGctEjsaiEChXI2YqERBKfnQcrHnw=@vger.kernel.org X-Gm-Message-State: AFuF++mOmhPimb6wHFgEPvRFDQ9ta2O2vHIBHm2HUiR66vhzQDHV/ABB pFQpFezy3yIv/AQSnwu0UdFuoGcDKB/ATdVrstcLVEGc31WtuBOsKKxB7hWpYusH92Gb4kTq8xR dHoSIcLV3b3/rLh/AeKQrxhRozUWEj5TUHraD/r+RaJ6apvRvnmNLZejQnNABEsqCd1Q= X-Gm-Gg: AYBFou0BnA6BZWxsWjFPPwYYhcGkMITBRr4Rkh1CBogZJ4GxyQ/2kMvLNbwh2y8dPGB xPlAmo7OWmFNzHiqPdptBvQuGdGL7Uk1oklPWs0jpQ/ElOPtFLCplPaq6wI6ElFNBZh7FyJAflo kmDcAqZSkUabUja0VutuWqRKHbNL/oEOhBZ2K88bn+SGAfFbwITNNmfz0XEd4UYluJ4/YBAuXu7 RIQUS8JA3c98gQhypkTo3YNzZFEap7C0Cyi4cG2EdO3U0s5MX1k3vk4zowojtH4XpKjDdayG1W4 0kKInAQCQWj/R72H5NTAvTvpH2V29GRauJTNwT0Nodh0I7+UHnqX022ESwswzVR78TFEo+lDn9p iw1N5OjMXvClApYsVzxc3FNoi1r2splcrw+7hQJPOMAaUfQbtx1VSvP4y85oT/DXwomiiuwZo X-Received: by 2002:a17:90b:35d1:b0:39d:f189:48d6 with SMTP id 98e67ed59e1d1-39df1894982mr783854a91.4.1789367561873; Sun, 13 Sep 2026 23:32:41 -0700 (PDT) X-Received: by 2002:a17:90b:35d1:b0:39d:f189:48d6 with SMTP id 98e67ed59e1d1-39df1894982mr783801a91.4.1789367561416; Sun, 13 Sep 2026 23:32:41 -0700 (PDT) Received: from [10.133.33.62] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39dada5c76asm17463531a91.12.2026.09.13.23.32.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Sep 2026 23:32:41 -0700 (PDT) Message-ID: Date: Mon, 14 Sep 2026 14:32:37 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ath-next v2 2/2] wifi: ath11k: disable interrupts during firmware crash recovery To: Marek Szyprowski , Julius Bairaktaris , jjohnson@kernel.org Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, vasanthakumar.thiagarajan@oss.qualcomm.com, rameshkumar.sundaram@oss.qualcomm.com References: <20260726221908.104873-1-julius@bairaktaris.de> <20260726221908.104873-3-julius@bairaktaris.de> From: Baochen Qiang Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE0MDA5MCBTYWx0ZWRfX3uLCrV17uH0p X7JtqO+JGkno09Yd1OZyqGkNsC4a5+zMU4Y0ogWHMMNmKxz80iPUsrm0TB7QJ+NxUP/rBphYfE2 4niKLCajBkJnus3QI6A2y5uP7I7mQI2qfu6EMGWxLf5amzhqUTLgNKkcyCBXYCPZUO1QnGOdBR8 pTIOZyS6tddxx7e35HaWkJrhmDvHYdanH0ljMKZiqLDlv/OdIzIu8wfwf53BfwTXWCH3/mA9YTW 4P1sNQSq3vXvstmNo6BPUMktr37RT7av/Y3756gDTBIMFI14BWpxqTGLxqKPPplLlNixeMmBhvw cpy5NZbPtjFhczMzMOIVJNSOEq5rGQuVG7RZpVsdsPCnQs8ITeBp2gmoJ7ro80TUKsjRXb2/IzK eK4MePro2OIPfbggIig5Mq489Hu2782BIYNdglesrBgrLKPwXIaqen6JesioGhhOD2o2KYbOvR4 UX+rcA0+668m7E/1Xng== X-Authority-Analysis: v=2.4 cv=IZwSymqa c=1 sm=1 tr=0 ts=6aa7950a cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=KAfsIobKxm3l_v_usUoA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: OZ4v3GTdcH_r5ts5gLdlYoKI69Vb1pd5 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE0MDA5MCBTYWx0ZWRfXwlZZwcAFQMwd KqYhPkE215py5u0FThEksZe+OZ9wEJREgJHXobKI1Lg5ok2NOQH/MB+/JHgy3GYgXnNYGekxfXH +fdmh/U7PLbgNDVrLhgYGlgiaeaxhyw= X-Proofpoint-ORIG-GUID: OZ4v3GTdcH_r5ts5gLdlYoKI69Vb1pd5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-14_02,2026-09-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 impostorscore=0 malwarescore=0 phishscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609140090 On 9/11/2026 3:53 PM, Marek Szyprowski wrote: > On 27.07.2026 00:19, Julius Bairaktaris wrote: >> On IPQ8074 a firmware assert reboots the SoC: >> >> Unable to handle kernel read from unreadable memory at virtual address 0 >> pc : ath11k_hal_srng_access_begin+0xc/0x60 [ath11k] >> lr : ath11k_dp_rx_process_mon_status+0x15c/0xd84 [ath11k] >> Call trace: >> ath11k_hal_srng_access_begin+0xc/0x60 [ath11k] >> ath11k_dp_rx_process_mon_rings+0xa0/0x5d4 [ath11k] >> ath11k_dp_service_srng+0x1f4/0x348 [ath11k] >> ath11k_ahb_ext_grp_napi_poll+0x34/0xd4 [ath11k_ahb] >> __napi_poll+0x38/0x188 >> net_rx_action+0x120/0x2c0 >> >> ath11k_core_reconfigure_on_crash() tears the data path down with >> ath11k_dp_pdev_free(), ath11k_dp_free() and ath11k_hal_srng_clear(), >> which memsets the ring list. The DP NAPI is still running while that >> happens, so it services a ring whose address pointer has just been >> cleared. >> >> That function used to disable the interrupts first, until >> commit d455e805de70 ("wifi: ath11k: rearrange IRQ enable/disable in reset path") >> moved the disable into ath11k_core_reset(). reset_work is only queued >> from mhi.c and from the debugfs hw-restart handler, so AHB parts never >> run it on a real firmware crash. Their recovery goes QMI server exit -> >> restart_work -> ath11k_core_reconfigure_on_crash() -> >> ath11k_core_qmi_firmware_ready(), and nothing disables the interrupts >> anywhere along it. >> >> Disable them again on the crash path. The reset path has already done >> so by the time it gets here, hence the ab->is_reset check. >> >> This is also why the debugfs hw-restart trigger never showed the >> problem: it goes through ath11k_core_reset(), the one path that still >> had the disable. >> >> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.12-01460-QCAHKSWPL_SILICONZ-1 >> >> Fixes: d455e805de70 ("wifi: ath11k: rearrange IRQ enable/disable in reset path") >> Assisted-by: Claude:claude-opus-5 >> Signed-off-by: Julius Bairaktaris > > > This patch landed recently in linux-next as commit f7a74e131d3f ("wifi: ath11k: > disable interrupts during firmware crash recovery"). In my tests I found that it > causes a regression on QCOM RB5 board during system suspend/resume cycle > (s2idle): Hi @Marek, can you please try if below diff can fix this regression? Also, @Julis, can you please also confirm if it can address your original issue as well? diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c index d2ed6a0ea7e3..1ad0a47653de 100644 --- a/drivers/net/wireless/ath/ath11k/core.c +++ b/drivers/net/wireless/ath/ath11k/core.c @@ -1275,9 +1275,6 @@ int ath11k_core_suspend_late(struct ath11k_base *ab) if (ab->actual_pm_policy == ATH11K_PM_WOW) return 0; - ath11k_hif_irq_disable(ab); - ath11k_hif_ce_irq_disable(ab); - ath11k_hif_power_down(ab, true); return 0; @@ -2333,17 +2330,9 @@ static int ath11k_core_reconfigure_on_crash(struct ath11k_base *ab) int ret; mutex_lock(&ab->core_lock); + ath11k_hif_irq_disable(ab); + ath11k_hif_ce_irq_disable(ab); ath11k_thermal_unregister(ab); - - /* - * ath11k_core_reset() already disabled the interrupts on the reset - * path; only the firmware crash path reaches here with them live. - */ - if (!ab->is_reset) { - ath11k_hif_irq_disable(ab); - ath11k_hif_ce_irq_disable(ab); - } - ath11k_dp_pdev_free(ab); ath11k_cfr_deinit(ab); ath11k_spectral_deinit(ab); @@ -2605,9 +2594,6 @@ static void ath11k_core_reset(struct work_struct *work) time_left = wait_for_completion_timeout(&ab->recovery_start, ATH11K_RECOVER_START_TIMEOUT_HZ); - ath11k_hif_irq_disable(ab); - ath11k_hif_ce_irq_disable(ab); - ath11k_hif_power_down(ab, false); ath11k_hif_power_up(ab); -- 2.34.1