From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6C2D39901A for ; Mon, 13 Apr 2026 08:29:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776068982; cv=none; b=C6Sg8ZfQx1jtQifSQH1IfMYL4CB50/+jEh3jwiJPrJkZd9knJw6yvW/ElbYj9RToNW78/LADHal1HoB5uuLrrncEPSi/G1yL+xUWpMjLuP+Q/M1ZJHMLcM7B0a/dkAgvTwcE9lKtOW7FiB2GjNJEPC+Tr8RdhQygGFEDw892XgE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776068982; c=relaxed/simple; bh=TJzulDCerfcNW6Rn2c6DZX7y/CO0U9cq3MJmwJSy5/A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZQysSG1xDWCKCE/FmHjFWc58aMFitvUJoMVuMHYcJq7oD3S5zm1Zj2O97ij1FdhNZQ3yWbwGv+tnDsZMw8bIM1JNKS+VwlumxP+QhUXeBetCWLUrKGp6KkndUrYq2c/OoMNBPGmBy0k8Oh4BWqsEYVzKYDYGlOKoOdtKP5tm+UI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iDwKkfDm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kXXpDrhm; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iDwKkfDm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kXXpDrhm" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63D790Gi479867 for ; Mon, 13 Apr 2026 08:29:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NZ8sf0ggPk1h1s1lmsOsg44DsYWsUVjfMtXc3A7gmWs=; b=iDwKkfDmV+yafUeV 52KlJYPkBhp0h3cej3HIMU8lE1n1iJ8n7LqdRC97GJX5ieIOESfiXBCDZTiTvV3q 2/i8dg+e/3wPdAqtWWkDHL0wxbNgw5U5UGgG08M06xA0DKbtdBqnksBrhKGIO1du 4yJaBaQ/ahGOkmfy4/NkASFXVDocFiR80SfHFZAZBxDP/d7z8BZ0dhWioms6pVK+ A8Bl0DP0vXUnaYWq28ZS2zGwZg+5smxpWCOhV/1He3oEWk9FUhr657qKmomIdUZo VKdR/ESzBta4MrY6NPPYxkyoz9ORNpfp7g+Cn7IEm1JFdtTUdUU/Onm/LrDb+4rc k+NcXw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dguuj88kr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Apr 2026 08:29:41 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50db373cf13so6198371cf.1 for ; Mon, 13 Apr 2026 01:29:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776068980; x=1776673780; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NZ8sf0ggPk1h1s1lmsOsg44DsYWsUVjfMtXc3A7gmWs=; b=kXXpDrhmZWtl/BiPMVf7z0h01ZrBSLITAtSCAUt6g7ZhdiTi5aoMrUGx4M2bTlROZo EGvO6L3W0i9Q/kxfBV1qi+Dg+oc1fM4HVo8zd0xMzPgN6xZQNM5XUD957xNA7jUWp8AX tr2DezWrUOryjw9nnMmudhylvgMl9QonK1lOamogLhg0H+CK7Eaxfl50Oz7Bu9hJ+Kc3 WYmZCbvi75XDH2vCWkJZIgbyiuKPMXg4O6IOVon75gGXUbZ97uJO5OViVuMbd8KLVHHw DA9CSQm8iDQ4DTjaKru6l/gHsbiFUwdjFuP2PoAMVIME+Td4aGDpXMQe1eukZ0+chlF7 jgGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776068980; x=1776673780; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NZ8sf0ggPk1h1s1lmsOsg44DsYWsUVjfMtXc3A7gmWs=; b=aFhnarMWlmIX4xlDKm0vUJNN2AEvm30mUYefWBHiYN6/lRqMnRGMTIABOA1jsDT/dw gFBmTpGBqCxSV7LM3Uua9RJ0PkNqFTQWIPkYJHEhLdf6FddBNoHOfznYcGjBmSIO+rE9 J5mgBcxnKtoV5gFRzE3n1wUuA6sc3eNZBWk2v6QDfj8Fxzn2VW4rIFfH/Lpp97qHJK2r aBrNHS8UVn6Q2wOWuyfOmoNgwKNTnNjwSZsGJeYCpDhG9H4jXMu8uDVgxPLG8Iw87/TI Oq9WYiDo6j+f6cZ6EQjWyaZPKDGbGocOe2rTu41RsmZtV4meZsjGohL+7ihB33Ra0pLk 08Nw== X-Forwarded-Encrypted: i=1; AFNElJ9CpWPzhVNc8O/g+78L+wCIcv5W6VIkl2GSOHE7mqZvySOTO8IzqAy3kIeLRoxss05lnBom52gVu8B9nyA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+sv/QYgHB5e2fX+v5xIsv0xuAlMFUBUQISwnA2FMGtqeNd3Ws jptFgIwFdQega2o8LC8L7PU3oGcjiaNg5Q2zWqvaMqMdiQC6byD+Thl1S0ttz7JL80jKH+r0sjb 851CLnWWSirhbVeQG8yJfQKU43zt5x2HLY/hIe29nA3UKoz/O1DsmjckEQwFZb/1mkQc= X-Gm-Gg: AeBDievMB9TVRdcayDFpNjJxTJWXyShhL2IPnQGOLosQgJje7ks3OVDrK1V6XSQCza1 KhphIsug1MaXWVICuli5Cd9fG7R7py1Z13K/O0URK+w8X5nNIgYABrOH0fUdXtjAb5q/NSHBk46 PEPGHX//Pp2smE1+GCseQ13Zr6yAoRrxFlYYWQsQfG6bSL42uwBFLTPh6e0pSBN6vsoCYDZX7Cn Wr/pzrNEfiFko6YYyEH96xVUry27l6bUcoQUuRcivRFyf4O2hDDHihsIgus9aE8d1MBOij+9j1t fGDMVmz+/bkpvXAsqs9muPhau3JNdM46ymWzOYAHIxhyNjNsct0jfVj7qfEV8WF3G+8jOKhfFJI yp2WhzCnjzUnI4IxHR9yNHv5V47MfSpflLGD0fVkee6BSbw+3wFFot+666+SzW6lyhQeRxiHRYy WTMo4= X-Received: by 2002:a05:622a:1827:b0:509:a3c:e390 with SMTP id d75a77b69052e-50dd8236028mr119803781cf.4.1776068980147; Mon, 13 Apr 2026 01:29:40 -0700 (PDT) X-Received: by 2002:a05:622a:1827:b0:509:a3c:e390 with SMTP id d75a77b69052e-50dd8236028mr119803611cf.4.1776068979780; Mon, 13 Apr 2026 01:29:39 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-67070815733sm2544788a12.21.2026.04.13.01.29.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Apr 2026 01:29:39 -0700 (PDT) Message-ID: Date: Mon, 13 Apr 2026 10:29:35 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/35] irqchip/qcom-pdc: Add PDC_VERSION() macro to describe version register fields To: Mukesh Ojha , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260410184124.1068210-1-mukesh.ojha@oss.qualcomm.com> <20260410184124.1068210-6-mukesh.ojha@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260410184124.1068210-6-mukesh.ojha@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDEzMDA4MSBTYWx0ZWRfXwZKDhP2MOldy Y9ePFGejiARrqXe/Zc9HqRZTRadHtpBtvqt5gP+K48TffaeLb/P7yT3VqUOgwa2GFIWiSQqn0vM eG90tCOnCXPSyoSBqHdo3axFd/ynTjXAiT7QlY7JGziUNuIwIBOwolyNDR7MUnEbG6Sah2rbV9i satiW0hlO+FODb1dc/4IUbdF/JU2FAYBhyjjVXTQQekjL3jdKEM34qKy08f9+u5ixCc2iNbnSJy D/U1h1acViuyZMTuDfMp+e1HtoWLrTqQomQLdk+kqeOMX+16NMLZOyQZRZ76AtLrcd/KsNoYKPW Xx+Coh+MVtgSGZjmJzTGfobe49ziuRWAEzGISzOwjDvrZ7Eon8VEi/beBIiXDr9evEIflUw+GhS TRCvnJH2zISUIwsrXn/mV3Z1iHXSbq5lKMoEE+JuvU45dxYiCMr08wSRHsLOAQEA9ys/XTs7RoD 81BcVCifZJ0pyUCJfpQ== X-Authority-Analysis: v=2.4 cv=c/ibhx9l c=1 sm=1 tr=0 ts=69dca975 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=VbrZmljE2wxRSAa9tscA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: avLovxZzvsDv1cpnw82gbeEEYvUUIGI9 X-Proofpoint-ORIG-GUID: avLovxZzvsDv1cpnw82gbeEEYvUUIGI9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-13_02,2026-04-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604130081 On 4/10/26 8:40 PM, Mukesh Ojha wrote: > The PDC hardware version register encodes major, minor and step fields > in byte-sized fields at bits [23:16], [15:8] and [7:0] respectively. > The existing PDC_VERSION_3_2 constant was a bare magic number (0x30200) > with no indication of this encoding. > > Add GENMASK-based field definitions for each sub-field and a > PDC_VERSION(maj, min, step) constructor macro using FIELD_PREP, making > the encoding self-documenting. Replace the magic constant with > PDC_VERSION(3, 2, 0). > > Signed-off-by: Mukesh Ojha > --- Reviewed-by: Konrad Dybcio Konrad