From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751254AbeEPSaZ (ORCPT ); Wed, 16 May 2018 14:30:25 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60460 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750759AbeEPSaX (ORCPT ); Wed, 16 May 2018 14:30:23 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AD0F7601D4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [RFC PATCH] efi/fb: Convert PCI bus address to resource if translated by the bridge To: linux-pci@vger.kernel.org, timur@codeaurora.org Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peter Jones , Bartlomiej Zolnierkiewicz , "open list:EFIFB FRAMEBUFFER DRIVER" , "open list:FRAMEBUFFER LAYER" , open list References: <1526495029-25783-1-git-send-email-okaya@codeaurora.org> From: Sinan Kaya Message-ID: Date: Wed, 16 May 2018 14:30:20 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1526495029-25783-1-git-send-email-okaya@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/16/2018 2:23 PM, Sinan Kaya wrote: > + if (win_start <= base && win_end >= base + win_size - 1) { > + base += window->offset; > + break; > + } I should probably add window->offset!=0 to the if statement in order not to break non-translating case. Any other comments? -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.