From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Aaron Erhardt <aer@tuxedocomputers.com>
Cc: Werner Sembach <wse@tuxedocomputers.com>,
Hans de Goede <hansg@kernel.org>,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86/tuxedo: Handle LampUpdateFlags in LampRangeUpdateReport
Date: Thu, 19 Nov 2026 17:09:14 +0200 (EET) [thread overview]
Message-ID: <dd592477-6f29-6d13-20b4-1c92d804866b@linux.intel.com> (raw)
In-Reply-To: <20261029-nb04-fixes-v1-1-614da83bd60f@tuxedocomputers.com>
On Thu, 29 Oct 2026, Aaron Erhardt wrote:
> According to HID Usage Tables v1.7 "Lighting And Illumination Page", the
> LampUpdateComplete flag marks an update report as the last of a batch. A
> device must apply all prior changes at once when it receives a report
> with this flag set.
>
> The handler for LampMultiUpdateReport already honors LampUpdateFlags,
> but the handler for LampRangeUpdateReport did not. It always set
> LampUpdateComplete on the final chunk, so every range update flushed the
> internal color state regardless of what the host requested. This reduced
> efficiency and caused unwanted intermediate states for software that
> batches updates using the flag.
>
> While splitting the update into several LampMultiUpdateReports, forward
> the flags from the range report on the final chunk. Intermediate chunks
> continue to carry no flags.
>
> Fixes: cfd84b3f419b ("platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices")
> Cc: stable@vger.kernel.org
> Signed-off-by: Aaron Erhardt <aer@tuxedocomputers.com>
> ---
> Tested userspace software:
> - OpenRGB (aac7e55114)
> - lampctl (https://github.com/tuxedo-aer/lampctl 5da2aff)
> ---
> drivers/platform/x86/tuxedo/nb04/wmi_ab.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/tuxedo/nb04/wmi_ab.c b/drivers/platform/x86/tuxedo/nb04/wmi_ab.c
> index 3e5ba524fe58..300af12e5f8a 100644
> --- a/drivers/platform/x86/tuxedo/nb04/wmi_ab.c
> +++ b/drivers/platform/x86/tuxedo/nb04/wmi_ab.c
> @@ -724,7 +724,7 @@ static int handle_lamp_range_update_report(struct hid_device *hdev,
> lamp_multi_update_report.lamp_update_flags =
> i + LAMP_MULTI_UPDATE_REPORT_LAMP_COUNT_MAX >=
> rep->lamp_id_end + 1 ?
> - LAMP_UPDATE_FLAGS_LAMP_UPDATE_COMPLETE : 0;
> + rep->lamp_update_flags : 0;
Fits to previous line.
--
i.
prev parent reply other threads:[~2026-11-19 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 10:11 Aaron Erhardt
2026-11-19 15:09 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd592477-6f29-6d13-20b4-1c92d804866b@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=aer@tuxedocomputers.com \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®