From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D34F9C433E2 for ; Thu, 10 Sep 2020 21:34:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5120221E2 for ; Thu, 10 Sep 2020 21:34:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727984AbgIJVe0 (ORCPT ); Thu, 10 Sep 2020 17:34:26 -0400 Received: from foss.arm.com ([217.140.110.172]:36620 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730951AbgIJNuJ (ORCPT ); Thu, 10 Sep 2020 09:50:09 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 429D011B3; Thu, 10 Sep 2020 06:43:27 -0700 (PDT) Received: from [192.168.1.79] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 14D603F66E; Thu, 10 Sep 2020 06:43:25 -0700 (PDT) Subject: Re: [PATCH] drm/panfrost: Ensure GPU quirks are always initialised To: Daniel Vetter , David Airlie , Rob Herring , Tomeu Vizoso Cc: Neil Armstrong , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alyssa Rosenzweig , "Marty E. Plummer" References: <20200909122957.51667-1-steven.price@arm.com> From: Steven Price Message-ID: Date: Thu, 10 Sep 2020 14:42:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200909122957.51667-1-steven.price@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/09/2020 13:29, Steven Price wrote: > The GPU 'CONFIG' registers used to work around hardware issues are > cleared on reset so need to be programmed every time the GPU is reset. > However panfrost_device_reset() failed to do this. > > To avoid this in future instead move the call to > panfrost_gpu_init_quirks() to panfrost_gpu_power_on() so that the > regsiters are always programmed just before the cores are powered. > > Fixes: f3ba91228e8e ("drm/panfrost: Add initial panfrost driver") > Signed-off-by: Steven Price Applied to drm-misc-next Steve