From: Swamil Jain <s-jain1@ti.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: <jyri.sarha@iki.fi>, <tomi.valkeinen@ideasonboard.com>,
<airlied@gmail.com>, <simona@ffwll.ch>,
<maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
<tzimmermann@suse.de>, <robh@kernel.org>, <krzk+dt@kernel.org>,
<conor+dt@kernel.org>, <aradhya.bhatia@linux.dev>,
<dri-devel@lists.freedesktop.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devarsht@ti.com>,
<praneeth@ti.com>, <h-shenoy@ti.com>, <u-kumar1@ti.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: display: ti,am65x-dss: Add am62p dss compatible
Date: Thu, 27 Nov 2025 14:51:37 +0530 [thread overview]
Message-ID: <dd6820fc-0537-4daa-8dba-4589c80d5f67@ti.com> (raw)
In-Reply-To: <20251127-quizzical-mussel-of-discourse-bfeaab@kuoka>
On 11/27/25 13:15, Krzysztof Kozlowski wrote:
> On Tue, Nov 25, 2025 at 10:29:40PM +0530, Swamil Jain wrote:
>> TI's AM62P SoC contains two instances of the TI Keystone Display
>> SubSystem (DSS), each with two video ports and two video planes. These
>> instances support up to three independent video streams through OLDI,
>> DPI, and DSI interfaces.
>>
>> DSS0 (first instance) supports:
>> - Two OLDI transmitters on video port 1, configurable in dual-link or
>> single-link mode.
>> - DPI output on video port 2.
>>
>> DSS1 (second instance) supports:
>> - One OLDI transmitter on video port 1 (single-link mode only).
>> - DSI controller output on video port 2.
>>
>> The two OLDI transmitters can be configured in clone mode to drive a
>> pair of identical OLDI single-link displays. DPI outputs from
>> DSS0 VP2, DSS1 VP1, and DSS1 VP2 are multiplexed, allowing only one
>> DPI output at a time.
>>
>> Add the compatible string "ti,am62p-dss" and update related
>> description accordingly.
>>
>> AM62P has different power domains for DSS and OLDI compared to other
>> Keystone SoCs. Therefore, add 'minItems' and set to 1 and 'maxItems'
>> field in the power-domains property to 3 for the "ti,am62p-dss"
>> compatible entry to reflect this hardware difference.
>>
>> Signed-off-by: Swamil Jain <s-jain1@ti.com>
>> ---
>> .../bindings/display/ti/ti,am65x-dss.yaml | 25 +++++++++++++++++++
>> 1 file changed, 25 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>> index 361e9cae6896..3945ae048b8f 100644
>> --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>> +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
>> @@ -24,6 +24,19 @@ description: |
>> DPI signals are also routed internally to DSI Tx controller present within the
>> SoC. Due to clocking limitations only one of the interface i.e. either DSI or
>> DPI can be used at once.
>> + The AM62P has two instances of TI Keystone Display SubSystem, each with two
>> + video ports and two video planes. These instances can support up to 3
>> + independent video streams through OLDI, DPI, and DSI interfaces.
>> + DSS0 (first instance) supports:
>> + - Two OLDI TXes on video port 1, configurable in dual-link or
>> + single link clone mode
>> + - DPI output on video port 2
>> + DSS1 (second instance) supports:
>> + - One OLDI TX on video port 1 (single-link mode only)
>> + - DSI controller output on video port 2
>> + The two OLDI TXes can be configured in clone mode to drive a pair of
>> + identical OLDI single-link displays. DPI outputs from DSS0 VP2, DSS1 VP1,
>> + and DSS1 VP2 are muxed, allowing only one DPI output at a time.
>>
>> properties:
>> compatible:
>> @@ -31,6 +44,7 @@ properties:
>> - ti,am625-dss
>> - ti,am62a7-dss
>> - ti,am62l-dss
>> + - ti,am62p-dss
>> - ti,am65x-dss
>>
>> reg:
>> @@ -197,6 +211,17 @@ allOf:
>> properties:
>> endpoint@1: false
>>
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: ti,am62p-dss
>> + then:
>> + properties:
>> + power-domains:
>> + minItems: 1
>> + maxItems: 3
>
> This is conflicting with top-level constraints. You need to update these
> and then narrow each variants. See also writing schema (Property Schema
> chapter).
Thanks Krzysztof, will update it in the next revision.
Regards,
Swamil
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2025-11-27 9:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 16:59 [PATCH v2 0/3] Add Display support for AM62P SoC Swamil Jain
2025-11-25 16:59 ` [PATCH v2 1/3] dt-bindings: display: ti,am65x-dss: Add am62p dss compatible Swamil Jain
2025-11-27 7:45 ` Krzysztof Kozlowski
2025-11-27 9:21 ` Swamil Jain [this message]
2025-11-25 16:59 ` [PATCH v2 2/3] drm/tidss: Power up attached PM domains on probe Swamil Jain
2025-12-01 12:40 ` Tomi Valkeinen
2025-12-29 5:48 ` Swamil Jain
2025-11-25 16:59 ` [PATCH v2 3/3] drm: tidss: tidss_drv: Add support for AM62P display subsystem Swamil Jain
2025-12-01 12:39 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd6820fc-0537-4daa-8dba-4589c80d5f67@ti.com \
--to=s-jain1@ti.com \
--cc=airlied@gmail.com \
--cc=aradhya.bhatia@linux.dev \
--cc=conor+dt@kernel.org \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=h-shenoy@ti.com \
--cc=jyri.sarha@iki.fi \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=praneeth@ti.com \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=u-kumar1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®