From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73BE3341076 for ; Sat, 7 Mar 2026 18:02:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772906560; cv=none; b=LnynfX3LfKq/5Tl2OzvVWjQujx4tao5/R1gcozlzu4ZJojp1jbs2PJpQA1RiK9HedOF8q/5xS4qWLBARC4osQju0/WG+WYUHpInTP5k8rlugWrjDxIAwxC/4tT+xe23VyapuGGnZfwIiOjsnKF9nbPNE+bef0q9kkbrppZUqf+w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772906560; c=relaxed/simple; bh=vaLz+rt/ppzH5g7k6DJKadf8T92lGpmIK9IC5qGWNAs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QfMdHEPGlR0oJ5iPyqIN3CIUdhubbGEsygTaJLG3axOpbginR2CXNg6YgZjj39sPaaILCXKnilatt3AWS43Gja5HpIxu8+/4J+HCHQKmHy8JMJGYkfGSufscOrYcoH9Sdoo+bI8vwldT96nVwIHy487T0iBTSDDsh9V8KT/8etU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=kE9KEkN6; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="kE9KEkN6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1772906550; bh=vaLz+rt/ppzH5g7k6DJKadf8T92lGpmIK9IC5qGWNAs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kE9KEkN6s8uo1NWVAg8HrWJWOA1LGq8RnCGxu2qlFpw3tvM5EzR5IrN2cXXYJF62y vLD04tbMCJXx+REFGxIpf7ShTm6FcuGmYPkObGQlkULLDcjkfUi9gW2t3he5E1DK3G YqhKJu0K9J33AC/VaNhqclDfs3U9954hL3eIZzfE= Date: Sat, 7 Mar 2026 19:02:30 +0100 From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: david.laight.linux@gmail.com Cc: Willy Tarreau , linux-kernel@vger.kernel.org, Cheng Li Subject: Re: [PATCH v4 next 00/23] Enhance printf() Message-ID: References: <20260302101815.3043-1-david.laight.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260302101815.3043-1-david.laight.linux@gmail.com> Hi David, On 2026-03-02 10:17:52+0000, david.laight.linux@gmail.com wrote: > From: David Laight (...) I am happy with the patches of this series. > David Laight (23): > tools/nolibc: Add _NOLIBC_OPTIMIZER_HIDE_VAR() to compiler.h > tools/nolibc/printf: Move snprintf length check to callback > selftests/nolibc: Return correct value when printf test fails > selftests/nolibc: check vsnprintf() output buffer before the length > selftests/nolibc: Use length of 'expected' string to check snprintf() output > selftests/nolibc: Check that snprintf() doesn't write beyond the buffer end > selftests/nolibc: Let EXPECT_VFPRINTF() tests be skipped > selftests/nolibc: Rename w to written in expect_vfprintf() Unfortunately b4 chokes on these patches because this patch is missing the 'v4' tag in the subject prefix. Given that the one below needs some changes anyways, I was lazy and applied the series only up until here. (Patch 1 is also not applied, as there was no user yet for _NOLIBC_OPTIMIZER_HIDE_VAR() ). Could you rebase the series on nolibc-next, add the error handling to strerror_r(), fix the wording nitpicks from Willy and resend the patches? I can also try to fix this up locally, but that would be more work on my side than it would be for you I reckon. Let me know if this is an issue and I'll try to make it work. Willy: I interpreted your mail [0] as Acked-by for the whole series. [0] https://lore.kernel.org/lkml/aawDlqLdpgsfGI4r@1wt.eu/ > tools/nolibc: Implement strerror() in terms of strerror_r() > tools/nolibc: Rename the 'errnum' parameter to strerror() > tools/nolibc/printf: Output pad characters in 16 byte chunks > tools/nolibc/printf: Simplify __nolibc_printf() > tools/nolibc/printf: Use goto and reduce indentation > tools/nolibc/printf: Use bit-masks to hold requested flag, length and conversion chars > tools/nolibc/printf: Add support for length modifiers tzqL and formats iX > tools/nolibc/printf: Handle "%s" with the numeric formats > tools/nolibc/printf: Prepend sign to converted number > tools/nolibc/printf: Add support for conversion flags space and plus > tools/nolibc/printf: Special case 0 and add support for %#x > tools/nolibc/printf: Add support for left aligning fields > tools/nolibc/printf: Add support for zero padding and field precision > tools/nolibc/printf: Add support for octal output > selftests/nolibc: Use printf variable field widths and precisions > > tools/include/nolibc/compiler.h | 3 + > tools/include/nolibc/stdio.h | 501 ++++++++++++++----- > tools/testing/selftests/nolibc/nolibc-test.c | 157 +++--- > 3 files changed, 469 insertions(+), 192 deletions(-)