From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 858EE32B131 for ; Tue, 19 May 2026 11:25:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779189923; cv=none; b=SyRMszgoOa+UcUsN7rtcgSpG/zCXsYeP5JRkLSi9gCsrFh/F8vuTZ4ZDUbXJL/PWjc9vjcnm2/jjAE2YgBe3UHzYqECKd7x6yIE3kaiQyaZCtLSEePeMOPmF/Hag6FIsNIimdsQnJIYry3U67ykoDrWp8xNhxGlW92JRYgicOFA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779189923; c=relaxed/simple; bh=DdlYAH7YYC/uFEG6PShPTwU3kyoumx8Dw/obSoed2pE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V3qx+x10UwAMe3I7ahGJUhEXcNHpPg20JRhT07qpxz2vQI9rK276DgQm7ORyIeqZZmBvpUIN8H3GMursWUnYs9zSE8XBDXXgf8V0bqkzyP4MquruFNbYJnxvHp/0AefW88W4Ofa7Gf1a1VEwsFHsimlpJwrsDaBLxvrtVICjBxE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QIfAg4ZC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SZFffMB/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QIfAg4ZC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SZFffMB/" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64J8EFNH3612442 for ; Tue, 19 May 2026 11:25:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= avHDZ/dhsbqUN2QfuautlreNoMotY+jG0kwbtZGQxPY=; b=QIfAg4ZCaWfbcV68 Y89gr/Y80ttsyMuKvNpnNp0gB5vV+wla1PSODH/FEwCHlLUpPslTMBYmbgL7F3Vi c9y7uhnQN6jeUONiABBP8H0Ip9w6MrKirrCY0LKMkjnuO0JjKcusvjcnZFQNfY2M x+zaEQDitQTahSCzeVoSteZeQbHj1/CTRTmXLvJW6ui8y7mkpZbrv0xLPACS5CEl 2xG6cK0/JshtSTBCPjGMwBa+rTVep3HTkFsHUb/sug5QiV5QJgbKRpRajYdtwQjw 5nu0nsaUdxBY62ymVH6Uxmm1TxNri8SQAmrNNluihOlIdsjTy4/mZH+dn6tDpRtX 5cUHmQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e8m64rsr6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 19 May 2026 11:25:20 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50e62562b6aso11475981cf.2 for ; Tue, 19 May 2026 04:25:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779189920; x=1779794720; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=avHDZ/dhsbqUN2QfuautlreNoMotY+jG0kwbtZGQxPY=; b=SZFffMB/7m8SKieBZaHqeZ4wn4rxldBOX76LODD6DV6HbFFa92DEzO8X+jqnnI/DRu hQazO4T5VKXjeG/OuLRDAh3MBvU6HMZwYPsChBX4gIuukO84ZJYs5fv+I503pDe8Pa88 KsZHNvJSsHtD3dUwc4mf9LoAYRJP8EoabXDxBuDf0ZYjhHdjMlXX67HeKcpB+rPQZ2gG vcFNyF/QZ9zRK4xzfJaQY88PZAzFl9lWx/qzyBSiWbUVUNXKjb8/aR7g/uXRKZLyT5sH a234gMMQEuBtZb2cmAMJnprcdCu4YeEvGp2VqbGZS/WXcoIEYbwdgQYmHEOQtQJfBsXR Y8KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779189920; x=1779794720; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=avHDZ/dhsbqUN2QfuautlreNoMotY+jG0kwbtZGQxPY=; b=PqSEsRcLxmbi33JPcHrMrh+Avk5d1+ZYgCzsnpIF/ymbzseyzMAHWBGLJXqHJhoeTJ XDhjVgOhtxF2rL2kdspznmUefx4njJMyrIB7EMM4GCIVV+NXkiPJDgEQDnCbqwqUjd8y 108MepzgL8gZ9Lh+NTUM5+QhG9EJddki0COar88ym4fr/wB+BgU+NJZ8LCRvPfuAsNUV JXGQKPV7eyFHo7DLs4K22lEfclqmdUjW7J8nP2wuM4U0mF08KRWJoHfZKCxmlxp5MsHL iZ23taV1fbbelth7GRj7b7pUUBkbRkEzc0Uy3HIlhZMif3IxdoMvdgkaVyLNpvB4BRj/ cxoA== X-Forwarded-Encrypted: i=1; AFNElJ9ghdunYjKUeB6HJMb1bShLy/HrDnu0KRmFIg7scVo6OmJUmdPAVyP1h9Ko5bO3hU84A+Eyf87sSRfE7Y0=@vger.kernel.org X-Gm-Message-State: AOJu0YyRYczfQxXNIBrDgaP7x+wXHMmhrlEM08IStZc9kSlGMeuen+yK seE3yNxTVcXsKZ8CulR8yZyjjTQBND/0nQPKj60cj3Xaq+X+TL1H7R3NP9r19tpsCGGsSPjSqpR iiz0QSXC1L1rdRgTm7BtkytL5CeXfcejSuD9QkUZ0SGNcP8E9tDSpVKAIxHxWoX8ueUU= X-Gm-Gg: Acq92OHiULvo5YVzHD6prB4aAL8eRDJVn9BKKHUjVkzpj+5fpVnyUnrDxs4TcSaC14J SMDkeHlU1dpulWS3ahi/NMGDhV9siRxP4FhPt5Sijsfl5+93CMFXliG/25Mbro9lET6Ub6FFEkJ Wmnzky2yRULzkq3V7SoUQe55KbInTY4xv7nUlBPwlhNkubBtu/SjmySBE0SPeYd79lHbruJn8BQ tZvXu+sJr1LALndfRwDjYcoUtnZkz6+9p3bCu0XJpNkq0WR3aH6DwV5fcQ95Bs0xR6CVsbVWelt aaex4CEBGfDPuxkXLrQ6PkcV3JYPPfu3v7Cscd22nTfedb+XVH3VCguDHS43mJGx+9uoegv4Ava D3XESMd60WkDMkZAyMvGtq7GhBw2o5Fct1DFAe11UMT/faJHHEt6JuMR/Knsel/iGEBeCPkKDeH KCJKM= X-Received: by 2002:ac8:594d:0:b0:50e:df3b:80 with SMTP id d75a77b69052e-5165a26c9fbmr197475381cf.8.1779189919919; Tue, 19 May 2026 04:25:19 -0700 (PDT) X-Received: by 2002:ac8:594d:0:b0:50e:df3b:80 with SMTP id d75a77b69052e-5165a26c9fbmr197474941cf.8.1779189919482; Tue, 19 May 2026 04:25:19 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bd4f4e21235sm687291866b.43.2026.05.19.04.25.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2026 04:25:18 -0700 (PDT) Message-ID: Date: Tue, 19 May 2026 13:25:16 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/6] usb: typec: tcpm: qcom: prefer VBUS supply from the connector node To: Dmitry Baryshkov , Bryan O'Donoghue , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heikki Krogerus , Liam Girdwood , Mark Brown , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260519-fix-tcpm-vbus-v1-0-14754695282d@oss.qualcomm.com> <20260519-fix-tcpm-vbus-v1-2-14754695282d@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260519-fix-tcpm-vbus-v1-2-14754695282d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE5MDExMiBTYWx0ZWRfX7hADrZhp9zaC 6VvGBTbG1RPlYQ9BYIlpKO6/swVW2VYxP1KFFbYe5nfHrJ4rRtqU2wGOmCQGRrtf1dSzoh4Pn1V 5br0qySgfKthmD6SUtr2T3a4xld4RswV7gvhWolskkwVKrWZFWPmkPQxJbKTCjYfalzi18/htON KOM54rU+XQDZsfp17Dp9mBD2Sath3E36o+3Wo6TlG1U3N68MFSOeE4IbjAMudSZQYSBWjAh2nm+ cBzqOhmc1HvQxo6xSqN84JKyCWw9Cz1+pNACw5Qcke+gyh2zT0447iodJZ9ZOhORNbKZ2suVPHb z2/jhkWvXruWk9jLKcJxiWYk/bzG7EuParzE2UzLthO4Q6sc8D+Mp2GUs5J1waaOAGsu236NWN1 06guVPaYG1VM5YXAQH5/yLlu8ib21O76y8gdpUONA8hOWKw/Pg7Sw0jUgJVyGbzXL/Z6+NzxYI5 a2ifEDXWsZxrPytTEFQ== X-Proofpoint-GUID: epa6loAA-Z0KxUv0wWUQrHOyW6pPP5r9 X-Proofpoint-ORIG-GUID: epa6loAA-Z0KxUv0wWUQrHOyW6pPP5r9 X-Authority-Analysis: v=2.4 cv=J8aaKgnS c=1 sm=1 tr=0 ts=6a0c48a0 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=K9uqyr9RctTKKMavoioA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-19_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 impostorscore=0 malwarescore=0 adultscore=0 spamscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605190112 On 5/19/26 12:48 PM, Dmitry Baryshkov wrote: > Current way of specifying VBUS supply (via the device's vdd-vbus-supply > property) is not ideal. In the end, VBUS is supplied to the USB-C > connector rather than the Type-C block in the PMIC. Follow the standard > way of specifying it (via the connector node) and fallback to the old > property if there is no vbus-supply in the connector node. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c > index 8051eaa46991..429bd42a0e62 100644 > --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c > +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -704,6 +705,7 @@ int qcom_pmic_typec_port_probe(struct platform_device *pdev, > struct device *dev = &pdev->dev; > struct pmic_typec_port_irq_data *irq_data; > struct pmic_typec_port *pmic_typec_port; > + struct fwnode_handle *connector; > int i, ret, irq; > > pmic_typec_port = devm_kzalloc(dev, sizeof(*pmic_typec_port), GFP_KERNEL); > @@ -720,7 +722,15 @@ int qcom_pmic_typec_port_probe(struct platform_device *pdev, > > mutex_init(&pmic_typec_port->vbus_lock); > > - pmic_typec_port->vdd_vbus = devm_regulator_get(dev, "vdd-vbus"); > + connector = device_get_named_child_node(dev, "connector"); > + if (!connector) > + return -EINVAL; > + > + pmic_typec_port->vdd_vbus = devm_of_regulator_get_optional(dev, > + to_of_node(connector), > + "vbus"); > + if (pmic_typec_port->vdd_vbus == ERR_PTR(-ENODEV)) > + pmic_typec_port->vdd_vbus = devm_regulator_get(dev, "vdd-vbus"); One could decipher this by reading the code, but please leave a comment hinting why this is a thing Reviewed-by: Konrad Dybcio Konrad