From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E53FC2D0E6 for ; Wed, 25 Mar 2020 20:05:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 461342074D for ; Wed, 25 Mar 2020 20:05:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585166735; bh=KQrQobMfXnFgSLgQMvsALc1syatq3RUPZzn2UmwaMVw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=JuC2E0Ddt2O+350IQCRxQKEnJOUZp4O0gb3sA8FZZTYqcUZiMtZfrmAelVbfLy3fK O6bRTLowuoQVG6zDKrPt6JcKM42p/RBgmXK47nyJD2sq4PAZXo9AUMmZuAUldcyIHb ZfOZLkL92zaiQOv3HsQsmI482fej7g/Iflde4M7E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727420AbgCYUFe (ORCPT ); Wed, 25 Mar 2020 16:05:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:43348 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727236AbgCYUFe (ORCPT ); Wed, 25 Mar 2020 16:05:34 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4542620658; Wed, 25 Mar 2020 20:05:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585166733; bh=KQrQobMfXnFgSLgQMvsALc1syatq3RUPZzn2UmwaMVw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=GV5JghfmqxWq3tY+RJacwokQxZRZmQbmJvX4q4IR9JKa+SwqragqcX5Y9e8cMtR7l xUOZj63b50DHIQeQTeZeYljtcmpe5aKFwQN3m0tm0/a6tjog6aJmnxYzgMDoAM7kEQ rv97ZvcPtzgSJdD3QMYQ96KFBwR3kD8UDDvoVTjk= Subject: Re: [PATCH v7 kunit-next 3/4] kunit: subtests should be indented 4 spaces according to TAP To: Alan Maguire , brendanhiggins@google.com, frowand.list@gmail.com, gregkh@linuxfoundation.org Cc: corbet@lwn.net, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, shuah References: <1584110682-3837-1-git-send-email-alan.maguire@oracle.com> <1584110682-3837-4-git-send-email-alan.maguire@oracle.com> From: shuah Message-ID: Date: Wed, 25 Mar 2020 14:05:32 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <1584110682-3837-4-git-send-email-alan.maguire@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/13/20 8:44 AM, Alan Maguire wrote: > Introduce KUNIT_INDENT macro which corresponds to 4-space indentation, > and use it to modify indentation from tab to 4 spaces. > > Suggested-by: Frank Rowand > Signed-off-by: Alan Maguire > Reviewed-by: Frank Rowand > --- > include/kunit/test.h | 7 +++- > lib/kunit/assert.c | 79 +++++++++++++++++++------------------ > lib/kunit/test.c | 6 +-- > tools/testing/kunit/kunit_parser.py | 10 ++--- > 4 files changed, 54 insertions(+), 48 deletions(-) > > diff --git a/include/kunit/test.h b/include/kunit/test.h > index f7b2ed4c..d49cdb4 100644 > --- a/include/kunit/test.h > +++ b/include/kunit/test.h > @@ -84,6 +84,10 @@ struct kunit_resource { > /* Size of log associated with test. */ > #define KUNIT_LOG_SIZE 512 > > +/* TAP specifies subtest indentation of 4 spaces. */ > +#define KUNIT_INDENT " " > +#define KUNIT_INDENT2 KUNIT_INDENT KUNIT_INDENT Sorry for a late comment on this. What's the reason to do it this way? Why wouldn't you define it as 8 spaces long string? Also can you please make sure to run checkpatch --strict on the patches you send? thanks, -- Shuah