From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D896919994D for ; Thu, 19 Sep 2024 09:12:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726737136; cv=none; b=g6LcJlKiSsUl39xaLSNMid9aBhZze2DmEPG8C6HpNDjgn8OQSrWkzd7K94kbtapVg1J1Wq5wSa0W/OaxZ4m6nqyJaFHg5exXPm1jILR7XGGAxRd3Htfqw4bqlrvxf7G1JwvmhTPs/JFLl+r6if+TIfb1W+H8r13rLV95yyfrzPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726737136; c=relaxed/simple; bh=GVQ0O2R1uWNT+xiUn1NlNaE8AFa47yPX2wZPeJVfj+o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ItyDyV9pwMDuO6CUJXk4Yu319RHhxISN3Sr5y837ltGzcWg3dLXoqNm2PP+ME4iKgwpG6Jr1T4mJDgDhfAsEljK3COJEcFZyK1gfnQPPFaH/GSttMRTwxuLWVJzHMe8kXYfVWUD27H7Bx2KOO0LRDd2aXS67/OzoecaTdKJD6PU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Zh/+xn3G; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zh/+xn3G" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726737132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LCElEKBH0phTZF2fIQuSy/+s0JOFGaYopSCTxfI0dVI=; b=Zh/+xn3GrA294Ko9zsGph91Djs6j8hcLToH6UCkeQkrM/l7myAm0H0P+tjCYz6CS/A2sbA qe29Z8nghyTQNU/wRibZU+YsjDeRDsqOdRBJubBIskcw01ViG3GNZkioOPaac0G5FqEHTF bu6ehkDg3xFloTF5jMc9KSs7iRG/Oco= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-450-UGP8jRnQO6ej7uMwXS6_bg-1; Thu, 19 Sep 2024 05:12:10 -0400 X-MC-Unique: UGP8jRnQO6ej7uMwXS6_bg-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-378929f1a4eso326004f8f.1 for ; Thu, 19 Sep 2024 02:12:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726737129; x=1727341929; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LCElEKBH0phTZF2fIQuSy/+s0JOFGaYopSCTxfI0dVI=; b=hrLaYFZGHtKpxTJn8FRByA9m28hYE+dDS0v6sJHuzhOAqZoaY46g3l3We+jY3bgF9o pv/esvFtpfTs+JPlbMo2/UZxpPav7WSjmqzEnZCCytP6J7gYaVdntuRZJFFuiFX8Yzf/ 69gDK0L1D+kNAy8lG81Slf7cCBtSwlyjtT/0axzIXuaKzWw9KMKvcw05ii/HXtND++54 lDAZ58W3A32xBqUtZYpFczvEpJxiB3TkN8lScPxHXb5/0KKMa7MW42NWCpKATDNWgdEs NzKKdez10n/8GpjCsgohi0I/qgFiKIHBOuUntqi9A97iaKprIw5VB5f1iwrOTToNcJKi oiYQ== X-Forwarded-Encrypted: i=1; AJvYcCVCQNkbQD1icRQ4NvMQIHjlRVlgTIEsDjsd08fv9xcXU8N7ku3iIhfud/ncoMxNIp6LFR9Yk4TVLE4FF+0=@vger.kernel.org X-Gm-Message-State: AOJu0YwgpNvSlfGyG3RudC8pMc53yzIUDrZYIooZAUr8eipsrsNeYMxX 5KFP6M70L+Ek03G9F22c3uAOUHBFVwXxhtHLmInUpWo+u7ZFcNRvSNZy7Xh2mLVWO325598M9aw YRLDnymw/zNWHVLL9Uv+eKHiLdt+7KjxTQuKodSAKzA6jluJMbqlr40F5Is73gw== X-Received: by 2002:a05:6000:1815:b0:368:65ad:529 with SMTP id ffacd0b85a97d-378c2d06172mr13926651f8f.17.1726737128715; Thu, 19 Sep 2024 02:12:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHiP7Zyv2OHT77WQZsp/MpXZUyd+Js26zDK1QxecEwwjKk/DBBeqSWHEiTWMF4+k3n/zDLpFw== X-Received: by 2002:a05:6000:1815:b0:368:65ad:529 with SMTP id ffacd0b85a97d-378c2d06172mr13926622f8f.17.1726737128263; Thu, 19 Sep 2024 02:12:08 -0700 (PDT) Received: from [192.168.88.100] (146-241-67-136.dyn.eolo.it. [146.241.67.136]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e75468765sm16452365e9.44.2024.09.19.02.12.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Sep 2024 02:12:07 -0700 (PDT) Message-ID: Date: Thu, 19 Sep 2024 11:12:04 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v4 0/2] bpf: devmap: provide rxq after redirect To: Florian Kauer , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , David Ahern , Hangbin Liu , Mykola Lysenko , Shuah Khan Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Jesper Dangaard Brouer , linux-kselftest@vger.kernel.org References: <20240911-devel-koalo-fix-ingress-ifindex-v4-0-5c643ae10258@linutronix.de> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20240911-devel-koalo-fix-ingress-ifindex-v4-0-5c643ae10258@linutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/11/24 10:41, Florian Kauer wrote: > rxq contains a pointer to the device from where > the redirect happened. Currently, the BPF program > that was executed after a redirect via BPF_MAP_TYPE_DEVMAP* > does not have it set. > > Add bugfix and related selftest. > > Signed-off-by: Florian Kauer > --- > Changes in v4: > - return -> goto out_close, thanks Toke > - Link to v3: https://lore.kernel.org/r/20240909-devel-koalo-fix-ingress-ifindex-v3-0-66218191ecca@linutronix.de > > Changes in v3: > - initialize skel to NULL, thanks Stanislav > - Link to v2: https://lore.kernel.org/r/20240906-devel-koalo-fix-ingress-ifindex-v2-0-4caa12c644b4@linutronix.de > > Changes in v2: > - changed fixes tag > - added selftest > - Link to v1: https://lore.kernel.org/r/20240905-devel-koalo-fix-ingress-ifindex-v1-1-d12a0d74c29c@linutronix.de > > --- > Florian Kauer (2): > bpf: devmap: provide rxq after redirect > bpf: selftests: send packet to devmap redirect XDP > > kernel/bpf/devmap.c | 11 +- > .../selftests/bpf/prog_tests/xdp_devmap_attach.c | 114 +++++++++++++++++++-- > 2 files changed, 115 insertions(+), 10 deletions(-) Alex, Daniel: this will go directly via the bpf tree, right? Thanks, Paolo