From: ChenXiaoSong <chenxiaosong@chenxiaosong.com>
To: Daijiamu <3058704216@qq.com>,
linkinjeon@kernel.org, sergey.senozhatsky@gmail.com,
tom@talpey.com
Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ksmbd: use clear_and_wake_up_bit() directly
Date: Fri, 2 Oct 2026 09:56:39 +0800 [thread overview]
Message-ID: <dd85c8b1-075b-47a3-8a88-6b55e5adb224@chenxiaosong.com> (raw)
In-Reply-To: <tencent_464A86FF7A38FD3620EBF1C6062745316307@qq.com>
Reviewed-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
On 10/1/26 23:06, Daijiamu wrote:
> clear_and_wake_up_bit() was introduced by commit 8236b0ae31c8 ("bdi:
> wake up concurrent wb_shutdown() callers.") to replace the open-coded
> clear_bit_unlock() + smp_mb__after_atomic() + wake_up_bit() sequence.
>
> Replace the sequence and drop the now-trivial wake_up_oplock_break()
> wrapper, calling the helper directly at each call site.
>
> Suggested-by: ChenXiaoSong<chenxiaosong@chenxiaosong.com>
> Signed-off-by: Daijiamu<3058704216@qq.com>
--
ChenXiaoSong <chenxiaosong@chenxiaosong.com>
Chinese Homepage: https://chenxiaosong.com
English Homepage: https://chenxiaosong.com/en
next prev parent reply other threads:[~2026-10-02 1:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260930183758.32342-1-3058704216@qq.com>
2026-10-01 15:06 ` Daijiamu
2026-10-02 1:56 ` ChenXiaoSong [this message]
2026-10-02 13:07 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd85c8b1-075b-47a3-8a88-6b55e5adb224@chenxiaosong.com \
--to=chenxiaosong@chenxiaosong.com \
--cc=3058704216@qq.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®