From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Abel Vesa <abel.vesa@linaro.org>, Stephen Boyd <sboyd@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Srini Kandagatla <srinivas.kandagatla@linaro.org>,
Johan Hovold <johan@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/4] dt-bindings: spmi: Add PMIC ARB v7 schema
Date: Thu, 22 Feb 2024 13:14:35 +0100 [thread overview]
Message-ID: <dd86117e-0196-499b-b8b3-efe4013cbc07@linaro.org> (raw)
In-Reply-To: <20240221-spmi-multi-master-support-v5-1-3255ca413a0b@linaro.org>
On 21/02/2024 13:52, Abel Vesa wrote:
> Add dedicated schema for PMIC ARB v7 as it allows multiple
> buses by declaring them as child nodes. These child nodes
> will follow the generic spmi bus bindings.
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> +
> +description: |
> + The SPMI PMIC Arbiter v7 is found on Snapdragon chipsets. It is an SPMI
> + controller with wrapping arbitration logic to allow for multiple on-chip
> + devices to control up to 2 SPMI separate buses.
> +
> + The PMIC Arbiter can also act as an interrupt controller, providing interrupts
> + to slave devices.
> +
> +properties:
> + compatible:
> + const: qcom,spmi-pmic-arb-v7
I dislike the versioning. Previous PMIC ARB binding said "it will cover
everything" and now it turns out that everything is not everything. I
would suggest SoC specific compatibles.
> +
> + reg:
> + items:
> + - description: core registers
> + - description: tx-channel per virtual slave regosters
> + - description: rx-channel (called observer) per virtual slave registers
> +
> + reg-names:
> + items:
> + - const: core
> + - const: chnls
> + - const: obsrvr
> +
> + ranges: true
> +
> + '#address-cells':
> + const: 2
> +
> + '#size-cells':
> + const: 2
> +
> + qcom,ee:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 0
> + maximum: 5
> + description: >
> + indicates the active Execution Environment identifier
> +
> + qcom,channel:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 0
> + maximum: 5
> + description: >
> + which of the PMIC Arb provided channels to use for accesses
We should probably deprecate qcom,bus-id in qcom,spmi-pmic-arb.yaml.
> +
> +patternProperties:
> + "spmi@[0-1]$":
> + type: object
> + $ref: /schemas/spmi/spmi.yaml
On this level:
unevaluatedProperties: false
> +
> +required:
> + - compatible
> + - reg-names
> + - qcom,ee
> + - qcom,channel
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + spmi: arbiter@c400000 {
> + compatible = "qcom,spmi-pmic-arb-v7";
> + reg = <0x0c400000 0x3000>,
> + <0x0c500000 0x4000000>,
> + <0x0c440000 0x80000>;
> + reg-names = "core", "chnls", "obsrvr";
> +
> + qcom,ee = <0>;
> + qcom,channel = <0>;
> +
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + spmi_bus0: spmi@0 {
> + reg = <0 0x0c42d000 0 0x4000>,
> + <0 0x0c4c0000 0 0x10000>;
> + reg-names = "cnfg", "intr";
> +
> + interrupt-names = "periph_irq";
> + interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-controller;
> + #interrupt-cells = <4>;
> +
> + qcom,bus-id = <0>;
Please drop. Same in second instance.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-22 12:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 12:52 [PATCH v5 0/4] spmi: pmic-arb: Add support for multiple buses Abel Vesa
2024-02-21 12:52 ` [PATCH v5 1/4] dt-bindings: spmi: Add PMIC ARB v7 schema Abel Vesa
2024-02-21 14:05 ` Dmitry Baryshkov
2024-02-22 12:14 ` Krzysztof Kozlowski [this message]
2024-02-21 12:52 ` [PATCH v5 2/4] spmi: pmic-arb: Make the APID init a version operation Abel Vesa
2024-02-21 12:52 ` [PATCH v5 3/4] spmi: pmic-arb: Make core resources acquiring " Abel Vesa
2024-02-21 12:52 ` [PATCH v5 4/4] spmi: pmic-arb: Add multi bus support Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd86117e-0196-499b-b8b3-efe4013cbc07@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®