From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4286C77B6F for ; Wed, 12 Apr 2023 14:33:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231603AbjDLOd2 (ORCPT ); Wed, 12 Apr 2023 10:33:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230520AbjDLOdS (ORCPT ); Wed, 12 Apr 2023 10:33:18 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE84D170A for ; Wed, 12 Apr 2023 07:33:01 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id e11so14934257lfc.10 for ; Wed, 12 Apr 2023 07:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681309980; x=1683901980; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LG9QX7rNR4lnpHDRoSRNn8CKFWnNVQXJufT8nFTW6qA=; b=LxOtPXIZmAVyKNxB9F3VeDQmA5bIN5pmpUVIz5xLTRzKmk3oC3H1OncmyqZdjjkCaU HWldwVsHvIiJdPitXYyyE/MBA34w+FwXzNScxArgGQh5+5kWrPs/2ZFY0VQ7b67EOOqJ KeFEf6wciQglkj68ZpKNl/VvaFGaClYsgab6aBWI47e+hKukymHlUtMUtOCnipwZVm5c JmIzcBaIrL50zGMerkDhERxtxDCbPCWa8u22jIcsV5YvRNRRGkeuqKbwkXLLj0rClsNM KvgP4rDorAig9U44igtuG/E9kk8sxJUMPJ7zhTwLN1fRaDfdE3Rnkw6UhhWY97QKHG8W 5PbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681309980; x=1683901980; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LG9QX7rNR4lnpHDRoSRNn8CKFWnNVQXJufT8nFTW6qA=; b=CH0z+ndAvNDlSADIH9m9iVlbEe2C0awJvCx/RTDwcFmgdvqB+jlXukzsXP47wfrF5s ee794qC8li9wehWH1L92/C8LVWqPE8GqZxUr5XS/5/VD1Ki/WCLtolmONlyygSyYLvwU zqK8pFt+GX9BiPvub5K76S5AHTGLkwmerUEUnQl0Brt3OUoSK9aAJgW5ufe23dTg3UrL sSSYj234oDNCsxkmoifXqybfhbBHq3gMQvhkzzWXbGCojH4HC/FMdpPIlyFIpNW+5bWN sQEOBCacit+g3ns9fjDh1YZ5w1HtO5i+RA5UlU0C0kxRW5b/8IAXF/i4hkH3Zd7UUnbI 4hCw== X-Gm-Message-State: AAQBX9fRNKXx9vJWWdfoxudvy+RTopHTWwp9jt0NVdT9HuiV+SH5c67K 6pNGfz7ZPBAethpejVsiuRbo8g== X-Google-Smtp-Source: AKy350ZNsIAk014vVyiA+ENqpAdTjA4YnCOsxvPnckQXB3hSs5cif9j2X311ZrDe+GsZi/AQz0EZOw== X-Received: by 2002:ac2:550b:0:b0:4e8:893f:8079 with SMTP id j11-20020ac2550b000000b004e8893f8079mr4108605lfk.64.1681309979982; Wed, 12 Apr 2023 07:32:59 -0700 (PDT) Received: from [192.168.1.101] (abxj23.neoplus.adsl.tpnet.pl. [83.9.3.23]) by smtp.gmail.com with ESMTPSA id w20-20020ac24434000000b004cb14fa604csm3047038lfl.262.2023.04.12.07.32.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 07:32:59 -0700 (PDT) Message-ID: Date: Wed, 12 Apr 2023 16:32:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 1/2] dt-bindings: soc: qcom: Add RPM Master stats Content-Language: en-US To: Rob Herring Cc: Andy Gross , Bjorn Andersson , Krzysztof Kozlowski , Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230405-topic-master_stats-v2-0-51c304ecb610@linaro.org> <20230405-topic-master_stats-v2-1-51c304ecb610@linaro.org> <20230412142232.GA2305202-robh@kernel.org> From: Konrad Dybcio In-Reply-To: <20230412142232.GA2305202-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.04.2023 16:22, Rob Herring wrote: > On Thu, Apr 06, 2023 at 04:49:17PM +0200, Konrad Dybcio wrote: >> The RPM MSG RAM contains per-RPM-master (e.g. APPS, ADSP etc.) sleep >> statistics. They let one assess which core is actively preventing the >> system from entering a true low-power mode. > > Just curious, is that a debug thing or something the OS uses? Debug, pretty much the only way of knowing how deep the sleep was other than shoving a multimiter under the chip and checking if the power rails went off.. :/ > >> >> Signed-off-by: Konrad Dybcio >> --- >> .../bindings/soc/qcom/rpm-master-stats.yaml | 53 ++++++++++++++++++++++ > > qcom,rpm-master-stats.yaml Ack Konrad > >> 1 file changed, 53 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/soc/qcom/rpm-master-stats.yaml b/Documentation/devicetree/bindings/soc/qcom/rpm-master-stats.yaml >> new file mode 100644 >> index 000000000000..d2d6a2a39fef >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/soc/qcom/rpm-master-stats.yaml >> @@ -0,0 +1,53 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/soc/qcom/rpm-master-stats.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Technologies, Inc. (QTI) RPM Master Stats >> + >> +maintainers: >> + - Konrad Dybcio >> + >> +description: >> + Per-RPM-Master (e.g. APSS, ADSP, etc.) sleep statistics. >> + >> +properties: >> + compatible: >> + const: qcom,rpm-master-stats >> + >> + qcom,rpm-msg-ram: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + description: Phandle to an RPM MSG RAM slice containing the master stats >> + minItems: 1 >> + maxItems: 5 >> + >> + qcom,master-names: >> + $ref: /schemas/types.yaml#/definitions/string-array >> + description: RPM Master name >> + minItems: 1 >> + maxItems: 5 >> + >> +required: >> + - compatible >> + - qcom,rpm-msg-ram >> + - qcom,master-names >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + stats { >> + compatible = "qcom,rpm-master-stats"; >> + qcom,rpm-msg-ram = <&apss_master_stats>, >> + <&mpss_master_stats>, >> + <&adsp_master_stats>, >> + <&cdsp_master_stats>, >> + <&tz_master_stats>; >> + qcom,master-names = "APSS", >> + "MPSS", >> + "ADSP", >> + "CDSP", >> + "TZ"; >> + }; >> +... >> >> -- >> 2.40.0 >>