From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f225.google.com (mail-dy1-f225.google.com [74.125.82.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7FF7374160 for ; Tue, 17 Feb 2026 18:47:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.225 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771354049; cv=none; b=AevWQruwUSZYiRLNt62B8bovfZ8uQEa+zwkuHXGTeI5SASWEv/t1/w/mxjJuCWjkj9QHOd439qnjWHao/Lj0EqAavw9G8NepmV2vU07SZ6EVhiI0w4sAAoCAvqbD+vAI7IkQKHYXuX5//qGGNVFPazmmCPGJD+z83tWvnjl/eRU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771354049; c=relaxed/simple; bh=fDbglYiqsCTg4EPvuE+VxHQYlVs3a8fvqgDhDZPkEc8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nGTEaSkrxE0HnMI6Z+NuQPukBeEYmUj0KDeylrra49E+SSlTw9lnPbQFjBTvg3liUNN/Mgvn7nZTkYhLRrGLeGKQnQdtmYYMCSZTAovFU+RmAlsbYpSbehDevZ/f047fmVua3c02YqGGKR2aL9gMZ7hyYRDywWJV4WFLKCdCYEc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=dm5U4vKc; arc=none smtp.client-ip=74.125.82.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="dm5U4vKc" Received: by mail-dy1-f225.google.com with SMTP id 5a478bee46e88-2ba68df3687so7799767eec.1 for ; Tue, 17 Feb 2026 10:47:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771354048; x=1771958848; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=bsx/C/z6cBL786ltmFv1u8SmaC8UkSjwOZGPBi68EIc=; b=WragTwmbeT8pR/bUP65aI9MHYSf1SvTwJw+4lX0Gx0lL52nyECFaNAQwRgYNrfiofz E7H6kk1dmOTJV6shRIqvxeRUWCInKVdmoXOZ4WwYjEwI0RWonBrHD5HfOE6GBpOdpc03 wvP7g7bBrp6nALq66OSxgnESlYFyl2XlafE+NS0ygdteY7WWrig6ai9FvM7gdR+FUiWF H+8pR+sHyy3WpkO7Fe7ps1jFRRbdUuHExWZHqaQ2xCUgH7gxukJGWNoHth9+WOAkx9kr WUG8x5Zv05V52dkwTbTO++T/Qg67ZCUkIFPlp5A73BkoszT0/DVGK93zMDbpSK4cHJ93 PElw== X-Forwarded-Encrypted: i=1; AJvYcCX0yQIsE5fJcyy0dfRwrspcd/cbxJ1RGs48rx/MCaWLTvAoLQwxYzvZt0FdVqVxyy0HTI7fZoTQu/BediQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxpvkDItXZuzpbjjSCH18ZIcB37dzcVjTiqtYb9cpYYuNO3/s7F 67URNlski99IWAEV28YTLxNl6oEICdIgql9xjylsq8DdG9/bJbeImrMb8ujR85dABldHcZ0zcVf Wv9UJSF4S7xIHHkn9ptsEaNEsD9MrmyBlQWU1dDpI2w/fB7TmB2MxQQzXP9N1ey7/YVrKq0Oe7p HUOepkB1l5vOnKBHBbvMap9c9OW3lD8cyHoFjUTI58uREPfxUGsiXRAtfFVHPsvMmb/7eBeC2QG 8TKj9bAa1MXmNN13A4DDl/C X-Gm-Gg: AZuq6aLcoO+a0+y4ojU2XY84kD1rOoI+xsl4I1WaaFgrHKW3DqRilgA1TqsWszfN3F6 VSr908/PMrBTkeHg0MIQa4Yy2qu5lovvd/7bDFDWSwk9B5E1csimEvItxSF876HcZ5yKEFNsi2j s6+DUn+STFUZI2CLyP+2mx6GQr1CCVY9aroCetk8A7MGvbd7XTN6YmZU8Siltghdh6PjfGhvOZu Bl/+B4wqcBO+cdGPX5WqsRH/8S7pKy57JYBfcd/3g0r3pbTPvGwAU6T/rFrgJKPUmSXZf2N8x5s v8T7huOCWxTXXlTUj/xIDIFIonzGz5jLEV7qLrfaHrKjoTO8OuFdjkbyLtS8TWqBh58aBcLixvV w7a8QeTGa62KsW75aK9Ec50vD4guMr+Zr5RPIlv/TPJwepMBE+u9s9P+490Fp9AhtSIzxV9eUHz x/DjkiYObfGjt/IOYEdawi13P1w2O0BhIlXaA5vuMa88lSDmBpVWYEy2zqALuEag== X-Received: by 2002:a05:7301:608:b0:2b8:261a:fbdf with SMTP id 5a478bee46e88-2bac97da825mr6478916eec.39.1771354047647; Tue, 17 Feb 2026 10:47:27 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-94.dlp.protect.broadcom.com. [144.49.247.94]) by smtp-relay.gmail.com with ESMTPS id 5a478bee46e88-2bacb591c49sm1443404eec.4.2026.02.17.10.47.27 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Feb 2026 10:47:27 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c70d16d5a9so2456650085a.3 for ; Tue, 17 Feb 2026 10:47:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1771354046; x=1771958846; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=bsx/C/z6cBL786ltmFv1u8SmaC8UkSjwOZGPBi68EIc=; b=dm5U4vKcfZYbh1g+yIGUBgcoDGP/xvJXlz4UMcMOk5PYjfhcrdmwoGiLaYLp3GhOFz BFcvkJelIoZCpMZBbae47l47U/Pr6+dnY+xBil520jmev5FB9rcwB3W8QubC84V06Dj0 SLLg7WM3CjFsnrq5yKhwjvZkHpqGZFtms+VBQ= X-Forwarded-Encrypted: i=1; AJvYcCU5opPF6EH8vjWWFTx61iJHBxDgihyX+1KMEkEfiSR2Vkq2oRmKJg4lqjzkFe+mNU4bRL0dA2M4A7YEIt4=@vger.kernel.org X-Received: by 2002:a05:620a:1711:b0:8ca:457f:a1f with SMTP id af79cd13be357-8cb4c03c2acmr1626746185a.90.1771354045922; Tue, 17 Feb 2026 10:47:25 -0800 (PST) X-Received: by 2002:a05:620a:1711:b0:8ca:457f:a1f with SMTP id af79cd13be357-8cb4c03c2acmr1626743185a.90.1771354045401; Tue, 17 Feb 2026 10:47:25 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cb2b0ce73fsm1714775685a.11.2026.02.17.10.47.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Feb 2026 10:47:24 -0800 (PST) Message-ID: Date: Tue, 17 Feb 2026 10:47:22 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mmc: sdhci-brcmstb: use correct register offset for V1 pin_sel restore To: Kamal Dasu , adrian.hunter@intel.com, ulf.hansson@linaro.org, florian.fainelli@broadcom.com Cc: bcm-kernel-feedback-list@broadcom.com, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260216191543.2514647-1-kamal.dasu@broadcom.com> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20260216191543.2514647-1-kamal.dasu@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 2/16/26 11:15, Kamal Dasu wrote: > The restore path for SDIO_CFG_CORE_V1 was incorrectly using > SDIO_CFG_SD_PIN_SEL (offset 0x44) instead of SDIO_CFG_V1_SD_PIN_SEL > (offset 0x54), causing the wrong register to be written on resume. > The save path already uses the correct V1-specific offset. This > affects BCM7445 and BCM72116 platforms which use the V1 config core. > > Fixes: b7e614802e3f ("mmc: sdhci-brcmstb: save and restore registers during PM") > Signed-off-by: Kamal Dasu Late to the party but: Tested-by: Florian Fainelli Reviewed-by: Florian Fainelli -- Florian