From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 122B91A5BBB; Tue, 25 Feb 2025 23:03:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740524610; cv=none; b=XRELpxldrzldHG/PIwke0udp4NfA6O2WzK9x8WTIYVsCkk8CUjUj5le8f85dDZMsfOYHwOTX+c6G1h90zeNAZ0ru90bgPcCmRw5mLGtG3XYRjaBLtuImOt5bYuJaXraWKwtxaZY5Cx4tgYTx5+9JGe8ffNky/oekr//lYtY/t0g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740524610; c=relaxed/simple; bh=ewP6ODZkMhs7hGc1QB5TrPbuQUEkuRzB9VfGrj2jKw8=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=MAPnSlGr8J/Z9EJ2eXWbP9cMRrpQcQJB5QOgPlvb976uMKPGsMfNwzPCi9Gouru/B6jAhDdvRz9H1CXBM7sYT4T4oizYMEA9dxuH3UEuvwJMlembEuqUdma/E8UtZFM7Pv6wfayz4Zauxt+7o/Vdf39bhxIlW/GVLKjCX/M1a+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=SjZkHExh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="SjZkHExh" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51PMWrai023826; Tue, 25 Feb 2025 23:03:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vzTbpIQHeO/NQvneOetGfXYw+iaT57eRWGCj9DIDnSM=; b=SjZkHExha3huMzTM c6FUj5iLu7U9mWhAyXj1lSrAxnL1eowl3tnP9kmTnIBG8SBFAnThyYOU0yU4UgsF NnkiH0RpzwHT/kQvhTcdmPlOSOZL4lxELs1yk2klfVKKL1xxA6xA6QzDGUsipfce 4BA6DVVQBSqU8xpTISa0wiYUGzueidGNWu3ceQUKci9d/vOKD+Rka237u9dFGq42 +lRcanD+MJjddelvi+5tSjpprrZnSsbxwaXWL4s0iRtwhPjwZA2lGcfD6j5AvuA5 XufNgJ0dVKFC8Nu+MEpu9S0vtg/aSuzhLB7VXqb+L2W5/wGkunXEJZMLpf5kIhWv nQgiOA== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 451prmg1t3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Feb 2025 23:03:17 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 51PN3GmS025432 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Feb 2025 23:03:16 GMT Received: from [10.110.101.220] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Tue, 25 Feb 2025 15:03:16 -0800 Message-ID: Date: Tue, 25 Feb 2025 15:03:16 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH next] drm/msm/dpu: fix error pointer dereference in msm_kms_init_aspace() To: Dan Carpenter CC: Rob Clark , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , "Simona Vetter" , Jessica Zhang , , , , , References: <3221e88c-3351-42e6-aeb1-69f4f014b509@stanley.mountain> Content-Language: en-US From: Abhinav Kumar In-Reply-To: <3221e88c-3351-42e6-aeb1-69f4f014b509@stanley.mountain> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: nxPbVw4LaHUfcyUv3F-1fAKLkVzQfzZy X-Proofpoint-ORIG-GUID: nxPbVw4LaHUfcyUv3F-1fAKLkVzQfzZy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-25_08,2025-02-25_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 phishscore=0 bulkscore=0 malwarescore=0 mlxscore=0 priorityscore=1501 adultscore=0 spamscore=0 mlxlogscore=873 lowpriorityscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2502250136 On 2/24/2025 11:30 PM, Dan Carpenter wrote: > If msm_gem_address_space_create() fails, then return right away. > Otherwise it leads to a Oops when we dereference "aspace" on the next > line. > > Fixes: 2d215d440faa ("drm/msm: register a fault handler for display mmu faults") > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/msm/msm_kms.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Abhinav Kumar