From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CD2F1A9FA8 for ; Tue, 25 Aug 2026 06:08:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787638085; cv=none; b=i3GZ4LLTHE82LFUaCWHsGPXro43VoA/XPiGDcXWGqJLBnsZd+ARRSl87FL4G3lVLoI1XQPKnT0qFbxNqPkUSOJEClYsyxe5Gv8uAL7X+IHBivtfTXEnhdG3aCooXLjKxCpEDExuaKMiPtGjurJWiAjVZBreYBG8x+yKAmzZzfTg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787638085; c=relaxed/simple; bh=RLEloRLuD+ixdMI2Y1Po84LFsDM/JIJXlVNhL8C4hrc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y2AYEyXMB0L8pe3qyCqWaLPg+uhpQI7BGZksasfbvw35qWrogZfxC1bnliYgs731W/HMPwfB78f3e87aaQbZKEKNgsvwaoP3PEQwE7CyHMMrPhM7phA3XOwyiD3wduFugpyiGzvm544e3reI2XWVjlbWrJVsO7TYfBLprR6+fQc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bwzApbAV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KtfETq9o; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bwzApbAV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KtfETq9o" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67P4LNWC3987527 for ; Tue, 25 Aug 2026 06:08:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5hD4rH1wbx/QvdxTxVE2CBG63Z9YbrYWbrM76H+HcC8=; b=bwzApbAVBYYkcvtu UCekxB1/01Mecax2Q7Q0GCEl89PG4fGiB6QSRLG6YzoX/ayTW5O4cy7qQJeoULkc uL/wZKaE4XrrSNmX4HAmZLmeoKtO+wVUN1a6tOAgvMn0cEOGK2XT1YEgHIhKiewR 5aFGwFUGDsRB5Er0IdMLvDexg7DbelL519EA4AKQMWMDRGMSL16BRwXcWHy4D8Kj u8T90pHbjvyuE6upKJehDFRYGeaAAo3tNZgRJaPHQz1welghjhocfYXC1tJKxbFd 3F8eTfMlUc1stA1y1o8juFiyi9YSTWaaKrJJhhdnDEvdKUbRtaT+mzzeZ/O7PqXx Hl/oWA== Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g93xxrahc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 25 Aug 2026 06:08:03 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-737d2f02d2fso3828171137.1 for ; Mon, 24 Aug 2026 23:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787638082; x=1788242882; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=5hD4rH1wbx/QvdxTxVE2CBG63Z9YbrYWbrM76H+HcC8=; b=KtfETq9oZPYy84E6V39QEkODe5C8p235VlYAgtpUSgDbl1UnGxrmKA5H/VfGM5laIJ iIiNWOUaLErjNIZBz1peGdX6CidBcOqounTiroGOGtQjXRDVTUOIA1xxj/6b4pMnfcWa g1m4rSKa4qgUjhsXwVEu7azA5KZp4NiJOUl78lfjJwy93AZhiXKFA46DPTk8+m/4TAgE 5A2oYnFX+ywK4trge3F1fj8Qt8k8h1gRnm7q6Ti5b9EvU3UStHTRQ60A/n33kawlaUG1 AcgKThzthUZuRN8sxcnSxUeRXzTbsJUHfgcLpS8vbUaj2hDzOJSa35t1E+1vPnE6mFTA G6PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787638082; x=1788242882; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5hD4rH1wbx/QvdxTxVE2CBG63Z9YbrYWbrM76H+HcC8=; b=Xwy2Mg+L4l2NPBhuG8k2pR8RuCofGOU7w/bjE9A+VvvSpITdNPvyTJjwOoXjySeCBK yHbhLpOfHDJhWer0FhDbtk0avA8/vizZPBx4bUYJAmsff/O9SmHHlnQ5IF5Rq3xpriUh Rpj59VpjRnlL5EqJq/BdD9O7cugsihibsjO/WsivkCSWEDL3uwzXmZYqCNHTeUH2pv8m jH+Zm2dhcv/X43sNNWG4iWwCi6hq3ImKfng7Wo42zPXu2+OyWAdo7+TaA+Iqe2O/s+LG 2XDh1yhNQupqVtcHTvVMhpRyKct7Bx6lb1c7gUJAHI3B6FNexPFx/tggLtnQ/pZ8TVsg owuw== X-Forwarded-Encrypted: i=1; AHgh+RqyXKTPcUHzzyg36eIYsNas4I+vmvLt6m/GRbRiJvwrQaSwhPjCBZ7iNlsmoPyl8E2qoKEqApC/9w8G4ts=@vger.kernel.org X-Gm-Message-State: AFuF++lx57nxBsyQ590m/wumZ2lW9lkyroWF4ooBcnTt9o7QrRFGhkPu REsHuOCtLHuABCp4tF2eoLXGoVPNRIEIIonZChl8A0h5sjFJQ4nki1DEmvGVD04gxfHDFkQr+JV Spw6FFKL+3EI4+7INkeSXAL0ya8csZGt2wLWb1gugJIWneiNHfYrB8+jx+WQHhK8okzk= X-Gm-Gg: AR+sD13TAAntIfOdYXFUzcCW2hJfamJtjOb5qd/vQRe21Gxbn+9QAyZgo7en59oLT0y FWdr3n30XZOn2vjgZ+229TYtXvY+Jxmg9xGj8u7cLlruvmw16e5LpMhlhflmk8pxX2Ylemn6xDY RiE51U1PBjNlQlO4syB674Y1aijP5VnWseKtGPoa+zCigsABtgXu5iFGwR11qgog3H/01EZyujn c13Xl//W+zCtngUof6wq9Nl9rYvlV0tZ0aMYuGHDWySCbPI4px9Hdmw3sCZxPlukdw65F4zfOyJ nMSl0DbsCfeKXD/AYhiqvcScymTp+wwTbs4vvqnk8gvOT9Ai1pAK1ytF4k1Pr7SuBK7P7stL1TP ytkTO06FPnOtkJefowHg1EU41otDY X-Received: by 2002:a05:6102:a18c:10b0:77f:fb50:8820 with SMTP id ada2fe7eead31-77ffb5090a4mr904689137.11.1787638082296; Mon, 24 Aug 2026 23:08:02 -0700 (PDT) X-Received: by 2002:a05:6102:a18c:10b0:77f:fb50:8820 with SMTP id ada2fe7eead31-77ffb5090a4mr904668137.11.1787638081946; Mon, 24 Aug 2026 23:08:01 -0700 (PDT) Received: from [192.168.1.110] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a59e00108asm18214296a12.2.2026.08.24.23.08.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2026 23:08:01 -0700 (PDT) Message-ID: Date: Tue, 25 Aug 2026 08:07:59 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 6/9] ASoC: qcom: Add QAIF PCM operations To: Harendra Gautam Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Srinivas Kandagatla , LKML , Conor Dooley , Jaroslav Kysela , Krzysztof Kozlowski , Kumar Anurag Singh , Liam Girdwood , Mark Brown , Mohammad Rafi Shaik , Prasad Kumpatla , Rob Herring , Sarath Ganapathiraju , Takashi Iwai References: <20260824063627.3595610-7-harendra.gautam@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODI1MDA1MCBTYWx0ZWRfX3n1L288WJZvY R3gDPoHsOaZvi3/dckKcKpVyP77ylIkIQZNenkoFQq9DecNjryVujOJ/lfzqYmlgD46Vd9xZIsa KhWcmW1UiksrSrr0AkV0VbNUR3jIYjo= X-Authority-Analysis: v=2.4 cv=EOg2FVZC c=1 sm=1 tr=0 ts=6a8d3143 cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=P-IC7800AAAA:8 a=L9GsOlX-8J4CZk4H7QYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=crWF4MFLhNY0qMRaF8an:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-GUID: HTfWGe4MP5n5M5z0FTbJE2LnJ-JP2osk X-Proofpoint-ORIG-GUID: HTfWGe4MP5n5M5z0FTbJE2LnJ-JP2osk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI1MDA1MCBTYWx0ZWRfXwKioYEw0+YPs UZFoH75lczZChFBeBDkurDDKgdLzWj15B5eNWU8TDJOD/mSdHb9qKNuzFSMt4ugw/bt0JVF3HNH Cc621TUzXGkVjmFnpbJr0S94us41EGXHCsiRuJbUr2o1LPA4NUpsYrFMFmvqadKDrm50sqnMlig v/KqWvUB4WKcwSAC8VUbwG8GQM4PjFCC4EddAbFtNftz5UknOfO3ZgyzFHtZLDaOwvjQudT33bw C8QFV0V34LPmrW1q2JUYg35qKpq5qOGmfDlzvmYNTY+FxJr5ZV6Hk45kAfOwW3Azlp4mRYNe9HW PCZoNu7oi0vvrM/b569Et8aSyD3DJjp3SB7inXu62zXABXzAmyvz8OH3UXjl0A0dY6jk+EEOQ/1 rqcolJ6SSOyn4/cKKztTsD3CMNOcMKdpVyO8FIpJAGIg2gBpI5insnKDMAAsQLk5X+5x1sJywyW rRT4Qzgpqsseqtsf1Ug== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-25_01,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 clxscore=1015 impostorscore=0 bulkscore=0 phishscore=0 suspectscore=0 priorityscore=1501 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608250050 On 24/08/2026 12:10, Harendra Gautam wrote: > On Mon, Aug 24, 2026 at 2:55 PM Markus Elfring wrote: >> >> … >>> +++ b/sound/soc/qcom/qaif-platform.c >>> @@ -0,0 +1,544 @@ >> … >>> +static int qaif_platform_pcmops_close(struct snd_soc_component *component, >>> + struct snd_pcm_substream *substream) >>> +{ >> … >>> + mutex_lock(&drvdata->stream_lock); >>> + if (v->free_stream_dma_idx) >>> + v->free_stream_dma_idx(drvdata, data->stream_dma_idx, dai_id); >>> + mutex_unlock(&drvdata->stream_lock); >> … >> >> Under which circumstances would you become interested to apply a statement >> like “guard(mutex)(&drvdata->stream_lock);”? >> https://elixir.bootlin.com/linux/v7.2/source/include/linux/mutex.h#L253 >> >> Regards, >> Markus > Thanks for the pointer. I believe guard() can be used across all > stream_lock. I Will address it in the next version. No, not really. Obvious code is replaced with more complicated one.
Feel free to ignore all comments from Markus, regardless whether the suggestion is reasonable or not. Several maintainers ignore Markus' feedback, because it is just a waste of time.
Best regards, Krzysztof