From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751751AbbE0PBn (ORCPT ); Wed, 27 May 2015 11:01:43 -0400 Received: from mta02.ornl.gov ([128.219.177.12]:27087 "EHLO mta02.ornl.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751087AbbE0PBj convert rfc822-to-8bit (ORCPT ); Wed, 27 May 2015 11:01:39 -0400 X-SG: RELAYLIST X-IronPort-AV: E=Sophos;i="5.13,506,1427774400"; d="scan'208";a="80850731" From: "Simmons, James A." To: "'Dan Carpenter'" , James Simmons CC: "devel@driverdev.osuosl.org" , "Greg Kroah-Hartman" , Linux Kernel Mailing List , Oleg Drokin , "HPDD-discuss@ml01.01.org" , "lustre-devel@lists.lustre.org" Subject: RE: [lustre-devel] [PATCH 5/6] staging:lustre: style cleanups for lib-socket.c Thread-Topic: [lustre-devel] [PATCH 5/6] staging:lustre: style cleanups for lib-socket.c Thread-Index: AQHQlL3V3/z0UUFYW0yv6+JMbo7il52MtnIAgAM63OA= Date: Wed, 27 May 2015 15:01:37 +0000 Message-ID: References: <1432319552-10479-6-git-send-email-jsimmons@infradead.org> <20150525093737.GS4150@mwanda> In-Reply-To: <20150525093737.GS4150@mwanda> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [128.219.12.132] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>On Fri, May 22, 2015 at 02:32:31PM -0400, James Simmons wrote: >> @@ -167,13 +164,14 @@ lnet_ipif_enumerate (char ***namesp) >> if (nalloc * sizeof(*ifr) > PAGE_CACHE_SIZE) { >> toobig = 1; >> nalloc = PAGE_CACHE_SIZE/sizeof(*ifr); >> - CWARN("Too many interfaces: only enumerating first %d\n", >> - nalloc); >> + CWARN("Too many interfaces: only enumerating " >> + "first %d\n", nalloc); >> } > >Don't split string literals, it makes them hard to grep for. Will fix. The CWARN will go over 80 characters but from the recent emails that is more acceptable. If this is the only problem then this patch set it ready. I have more patch series that are dependent on this first one. Should I push the other patch series with a note that it is dependent on the tcpip cleanup or wait until it is merged? Also how does one find out when the patch has been merged?