From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCF104BC00F for ; Fri, 5 Jun 2026 11:42:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780659776; cv=none; b=utG2hnNn+dZqPKz96J6k7PD/Bs9KH43oDwDKDh50nvGjYCZCkYUT047+ne0z7cF9ATENtXO1l1Sw2J1sDtHfHTfEzBa9lfDElmIQd983ndc8LzpBfbiSh3UC88RwGkMFhWd66eiJIvtG902SWy7GmgRYbjyMlEfLgLGtUsyPgeU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780659776; c=relaxed/simple; bh=ZOxNwcAxgJuwesTTu4Buf77BKR829ICvZ5T7AoOiC/4=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=Qf3tZS/Njlqy8K2xkV8azlCdFdU4ndTJOoMyMsFvbwYlLMwP0VkMsLdAhwFKffPXXkDfOsKTkF8TtaqVNdy19CQ2GkUzYzlmD5FbkQbMTc12BEpsn/wtDDCcgTrjxzW8S40HR4TRweayPCxxk1V16vYrdKGVRjBJWgU0Ar0mezU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fLRWRQnb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eU5ymAlK; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fLRWRQnb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eU5ymAlK" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6558i51A3604043 for ; Fri, 5 Jun 2026 11:42:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uPBjwVOd2SfO6t7DyDLUX6jVgyApWKoQB7ymLnNgC9g=; b=fLRWRQnb9uIqRpAG ukdjTNqg1UK7czTwaZSftrfDWsVB4gOyOdssKev1BBTfCexObDS8sotAf8pye4ux osNO1Mqnkuf6NsdLDpMiVdcxm4iXidfVr5H5gWaAYgqZdGpPnyA6FP0XhTeNiXm1 7HO9UCVVKSkhxD2dhg2CIv3v81wcftZqrU3SwYf2cScfUdBQ4qyw71ambXkltgtB EygTpxaq343wGgFyAR4V/fHPgacc4AMsbfFQ0d/M68T83X1PzC1+N/WZqNlQs2x7 lidThsVtAjAPTGU48miKRyrI/tyksrVkbSQRPcrC1i757E960PJv6At4Uqh0ItDF Fyzfxg== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ekmhfa67d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 05 Jun 2026 11:42:54 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51772325a64so25350471cf.2 for ; Fri, 05 Jun 2026 04:42:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780659773; x=1781264573; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=uPBjwVOd2SfO6t7DyDLUX6jVgyApWKoQB7ymLnNgC9g=; b=eU5ymAlKQQZnsFZi5MxwOnslMd79bhBIE7fWpSD0emoNO16BewOg6h1fczzzxp8D+p 5f5kEn4X9D6xuyUqu06iTiQeOjGLoO4/Ym00b0Ypqb+mOMiN2b83wLpczXClOFrhIfe5 w1XiX9kA92wDpWB0nBqkf2VBVcbhVPMM926qnmruxxtrgjvYwL8nIT5aNH7EQT/gME2x ALHx8vH1egl8r0P9WN/g/efjVMRP7uZc56JNehnqyaDC4dxFCrRamXCWqqkrNiatDl1f EkD28ZCTCbT0NRZc/G0k0MP009Mn48Amw/u0EtGq7ym3IUbaU0uZUYOsrGyRaQtdGX4i 0OQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780659773; x=1781264573; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uPBjwVOd2SfO6t7DyDLUX6jVgyApWKoQB7ymLnNgC9g=; b=aJRLmk/6nIv+bf0F2/otq6kuIC+rWWZPvqSkaxg/OzFOldmIeyB34M6YpXz4ceqZz4 O+zin8pvvGHfZ1AD1DUCBZP01NDYIspwKqXrxz2Wo4SFNGjh73ex24FbMrOdfPNGeNJf u6sELg0Wnym5fZbDYquhHMtYlawCU0t+ATq+6msKpBKUxHpeVPJwJHRstRIPAZrJJf+t gwyiNYvXMTER7xLboK+zzlNDoAB2ww0Av56+oSJn+qfOAHnkvRPziJaiCXFPkGG7jtSc 7a43cd1Z6teSXt20+QON2a6bXJa/V8PpDacnjkUcAKWcoyAxqz3a1oQRCSY7/Eg2R+I9 dcTg== X-Forwarded-Encrypted: i=1; AFNElJ/ftfLT11bYRCNCHEMiEpZWGXEa7wO6Ft36UWJGtY2cTBcy16oWE3MEsK7MPxBTfZt4pVeY9cd+7r7tJ9I=@vger.kernel.org X-Gm-Message-State: AOJu0YzVb8RGJPNxPmmSLogXR9Feh2GDtp14Ge+P+Jgb2YkbcXqTqlge B+yHDd723ue4rkeoXcFDa1qa/738ErhilrEBVpIe7GyRG0/brDcLmo/ppBTyjVz36Lmw5yYDjhE LrgGxF5mpLjwXzXghAIaFka6GOkqIh/dT2UM4hcg6RB4S2dssoMKAhEDOUnx7sz6OgGA= X-Gm-Gg: Acq92OF24FKBq2aHO7F0KU7bCl5U2c/AKbvJjF0LlgmRd0u8LWdKC2zJiG8UnPnHzNe WM5Ci1P6x+2eEwZr6Lkq+af2wp5C+3Q4q42s1foNB2UWqoBKLsJvzIebEW8e5CKMbEhPkvYKQoR tvM3GglyjJMxmS1Rpm9graq+Aq/9NitsOuvjcU4AYbzx17rxSNWPXc6f4L7M7tVVnJwFDS9bGYU F1vP41dIMJ1pt2ey13E0dFQAPSQMDdqabjmGfmBljQ9MkCKcv7FG2H6WnVaO6vj036lYybC1117 2GYaRD+G2Al+5/W295ph9z58dxKxMFg6vlVyrT7T5CmOkUUduBQid+EvUzcAruNk7Yug81/dkdA 5Ap5CuU7kTd9s6Tj46gkQa36mWhQVju++NClVASuIfITENh6XXtxvzK4zgp0= X-Received: by 2002:a05:622a:155:b0:516:cee1:4727 with SMTP id d75a77b69052e-51795aeb96bmr46253051cf.14.1780659773105; Fri, 05 Jun 2026 04:42:53 -0700 (PDT) X-Received: by 2002:a05:622a:155:b0:516:cee1:4727 with SMTP id d75a77b69052e-51795aeb96bmr46252631cf.14.1780659772606; Fri, 05 Jun 2026 04:42:52 -0700 (PDT) Received: from [192.168.68.125] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-4601f351ac0sm41760570f8f.27.2026.06.05.04.42.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jun 2026 04:42:51 -0700 (PDT) Message-ID: Date: Fri, 5 Jun 2026 12:42:50 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Srinivas Kandagatla Subject: Re: [PATCH v2 00/10] Expand SoundWire enumeration helper coverage To: Charles Keepax , broonie@kernel.org, vkoul@kernel.org, lee@kernel.org Cc: lgirdwood@gmail.com, pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com, oder_chiou@realtek.com, jack.yu@realtek.com, shumingf@realtek.com, srini@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com References: <20260605084810.1575539-1-ckeepax@opensource.cirrus.com> Content-Language: en-US In-Reply-To: <20260605084810.1575539-1-ckeepax@opensource.cirrus.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA1MDExMyBTYWx0ZWRfX8a8bX/2aXGjg BQE96FALcJ/J2sqYjqE7fuzBjGPhAQsgPq5SV16+vmA8CpavnDv/nn31oJWgrHkFwmDoE2bv/12 6Vw3wOsG+XvZJbDueTDrSYm5nNgE8TbNaL/dabxcA9r1JkWgysmIFjk7jcZ2qBiUTB5e+pNQ+g3 APn2/xKCwecxh0ZVnzx2fGzVBlZH0tBZYHu/vgFlTa091po8Eg+/sspLpmRkjP3+iIMREALflz7 l6QwUVVhtOBTm+hIg8BWgfB3Lro1eVCn1w4Lz2c0+IFIUCEV0Bvmd6q7hGh3ty3Kde4vunVBAfQ Mq6wuMHnOMtDnteOFpOT2tsDvsRjjhxk/5yrAqYVi8EOPRuUcyT5HypWqK6q4Y+vUQbT4jPSc2R vNrZ4f4Fd10w4fdt1aMk3vXgM0leNf5limclBi389ovpIAln9uScdRv7c3pqMUPavCAZ89XHKfk OiG8agXD5gJdVwR4rYw== X-Proofpoint-ORIG-GUID: QVW8qGp8sEdevtieqNYoQaDnPNURdrH3 X-Authority-Analysis: v=2.4 cv=dfmwG3Xe c=1 sm=1 tr=0 ts=6a22b63e cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=w1d2syhTAAAA:8 a=EUspDBNiAAAA:8 a=EjvMs8CsDyu3LpJ9lXEA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: QVW8qGp8sEdevtieqNYoQaDnPNURdrH3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-05_01,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 adultscore=0 impostorscore=0 phishscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606050113 On 6/5/26 9:48 AM, Charles Keepax wrote: > The patch series in [1] added a new helper to remove common boiler plate > waiting for a device to enumerate on SoundWire, however, many devices > also wait for enumeration during probe. This series updates things to be > suitable such that we can call the same helper at probe time when the > unattach_request is not valid. > > There is one final step outstanding which is to add a core helper > that waits for a device to drop off the bus. This is not include > in this series and should be the last step of this process. > > Thanks, > Charles > > [1] https://lore.kernel.org/linux-sound/20260512103022.1154645-1-ckeepax@opensource.cirrus.com/ > > Changes since v1: > - Completely remove the attached flag from cs42l43 > > Charles Keepax (10): > soundwire: Always wait for initialisation of unattached devices > ASoC: wsa881x: Use new SoundWire enumeration helper > mfd: cs42l43: Use new SoundWire enumeration helper > ASoC: rt5682: Use new SoundWire enumeration helper > ASoC: pm4125: Use new SoundWire enumeration helper > ASoC: wcd937x: Use new SoundWire enumeration helper > ASoC: wcd938x: Use new SoundWire enumeration helper > ASoC: wcd939x: Use new SoundWire enumeration helper > ASoC: SDCA: Use new SoundWire enumeration helper > ASoC: cs35l56: Remove unnecessary conditionals waiting for enumeration > > drivers/mfd/cs42l43-i2c.c | 2 -- > drivers/mfd/cs42l43-sdw.c | 7 ----- > drivers/mfd/cs42l43.c | 15 ++++------ > drivers/soundwire/bus.c | 3 -- > include/linux/mfd/cs42l43.h | 2 -- > sound/soc/codecs/cs35l56-sdw.c | 47 +++++++----------------------- > sound/soc/codecs/cs35l56.h | 1 - Thanks for the cleanup, For all below Qualcomm codecs: tested on Lenovo T14s. > sound/soc/codecs/pm4125.c | 11 ++----- > sound/soc/codecs/wcd937x.c | 11 ++----- > sound/soc/codecs/wcd938x.c | 11 ++----- > sound/soc/codecs/wcd939x.c | 11 ++----- > sound/soc/codecs/wsa881x.c | 10 +++---- Reviewed-by: Srinivas Kandagatla Tested-by: Srinivas Kandagatla --srini > sound/soc/sdca/sdca_class.c | 53 ++++------------------------------ > sound/soc/sdca/sdca_class.h | 3 -- > 15 files changed, 41 insertions(+), 160 deletions(-) >