Re: nfs4 hang regression

["Bret Towe" <magnade@gmail.com>]

On 9/5/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> > On Wed, 22 Aug 2007 15:41:18 -0700 "Bret Towe" <magnade@gmail.com> wrote:
>
> More than two weeks, you've bisected it and there's no sign of any action?
>
> I don't see this on Michal's list so perhaps it already got fixed in a different
> thread.  Have you tested current mainline?

It's been fixed, this thread was never replied to since I replied to
another thread
someone else started that was the same issue

Thanks for keeping watch tho :)

> > as of commit 3d39c691ff486142dd9aaeac12f553f4476b7a62
> > I got a hang on my clients after something around 26 minutes of uptime
> > the keyboard would stop accepting input
> > mouse would work still, plugging in a spare usb keyboard made no difference
> > another couple odd bits is shutting down would hang, below is a trace
> > of that hang
> > also if your logged into that machine via ssh when you log out it would hang
> > and would require a force terminate
> >
> > I'm seeing this on 2 machines 1 a g4 mac mini and 2 a athlon64
> > both have a home directory mounted via nfs4
> > reverting the commit above found via bisecting on both machines allows me
> > to use the computers for several hours with no issues
> >
> > and here is the trace from the athlon64 taken during its hang on shutdown
> > as you can tell from the dates in the trace ive been a bit busy and just
> > now got around to sending this email
> > I'm surprised tho I hadn't seen anyone hitting it
> > let me know what else is needed I'll do what I can and get it out quickly
> >
> > Aug 12 17:06:35 ghoststar kernel: [ 4791.801262] SysRq : Show State
> > Aug 12 17:06:35 ghoststar kernel: [ 4791.801325]   task
> >         PC stack   pid father
> > Aug 12 17:06:35 ghoststar kernel: [ 4791.801327] init          S
> > 00000000ffffffff     0     1      0
> > Aug 12 17:06:35 ghoststar kernel: [ 4791.801331]  ffff81003ff879b8
> > 0000000000000086 0000000000000008 ffff81003ff84000
>
> I really wish that hadn't been wordwrapped.
>
> As a random stab-in-the-dark, does this help?
>
> --- a/fs/nfs/nfs4renewd.c~a
> +++ a/fs/nfs/nfs4renewd.c
> @@ -133,9 +133,7 @@ nfs4_renewd_prepare_shutdown(struct nfs_
>  void
>  nfs4_kill_renewd(struct nfs_client *clp)
>  {
> -       down_read(&clp->cl_sem);
>         cancel_delayed_work_sync(&clp->cl_renewd);
> -       up_read(&clp->cl_sem);
>  }
>
>  /*
> _
>
>