mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marek Vasut <marex@nabladev.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
	Frank Li <Frank.Li@nxp.com>, Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH spi-next 10/11] spi: spi-fsl-lpspi: fsl_lpspi_set_cmd(): use mode from (struct fsl_lpspi_data::config::mode
Date: Mon, 16 Mar 2026 12:51:06 +0100	[thread overview]
Message-ID: <ddad0944-3ec2-4443-bb01-9140d48c5ae7@nabladev.com> (raw)
In-Reply-To: <20260316-spi-fsl-lpspi-cleanups-v1-10-1b695607702d@pengutronix.de>

On 3/16/26 9:39 AM, Marc Kleine-Budde wrote:
> Commit 7ae4d097b752 ("spi: spi-fsl-lpspi: Handle clock polarity and phase")
> enhances the driver with clock polarity and phase handling. That commit
> adds a 2nd argument ("struct spi_device *spi") to the fsl_lpspi_set_cmd()
> function.
> 
> The "spi" pointer is used to access the "mode" of the current transfer.
> However the mode is already available via "fsl_lpspi->config.mode".
> 
> To simplify the driver remove the 2nd argument and use
> "fsl_lpspi->config.mode" to access the mode.

Reviewed-by: Marek Vasut <marex@nabladev.com>

Thanks

  reply	other threads:[~2026-03-16 11:51 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16  8:39 [PATCH spi-next 00/11] spi: spi-fsl-lpspi: various cleanup and enhancement patches Marc Kleine-Budde
2026-03-16  8:39 ` [PATCH spi-next 01/11] spi: spi-fsl-lpspi: adapt to kernel coding style Marc Kleine-Budde
2026-03-16  8:39 ` [PATCH spi-next 02/11] spi: spi-fsl-lpspi: fsl_lpspi_probe(): use FIELD_GET to decode Parameter register Marc Kleine-Budde
2026-03-17  1:05   ` Frank Li
2026-03-17  9:04     ` Marc Kleine-Budde
2026-03-16  8:39 ` [PATCH spi-next 03/11] spi: spi-fsl-lpspi: fsl_lpspi_set_cmd(): use FIELD_PREP to encode Transmit Command register Marc Kleine-Budde
2026-03-16  8:39 ` [PATCH spi-next 04/11] spi: spi-fsl-lpspi: fsl_lpspi_set_watermark(): use FIELD_PREP() to encode FIFO Status register Marc Kleine-Budde
2026-03-16 14:39   ` Mark Brown
2026-03-16 16:49     ` Marc Kleine-Budde
2026-03-16 17:37       ` Mark Brown
2026-03-16 17:59         ` Marc Kleine-Budde
2026-03-16 18:16           ` Mark Brown
2026-03-16 18:31             ` Marc Kleine-Budde
2026-03-16 18:49               ` Mark Brown
2026-03-17  9:44                 ` Marc Kleine-Budde
2026-03-19 18:17                   ` Marc Kleine-Budde
2026-03-16  8:39 ` [PATCH spi-next 05/11] spi: spi-fsl-lpspi: fsl_lpspi_setup_transfer(): remove useless spi_transfer NULL pointer check Marc Kleine-Budde
2026-03-16  8:39 ` [PATCH spi-next 06/11] spi: spi-fsl-lpspi: fsl_lpspi_can_dma(): directly assign return value to fsl_lpspi->usedma Marc Kleine-Budde
2026-03-16  8:39 ` [PATCH spi-next 07/11] spi: spi-fsl-lpspi: fsl_lpspi_reset(): convert to void Marc Kleine-Budde
2026-03-16  8:39 ` [PATCH spi-next 08/11] spi: spi-fsl-lpspi: fsl_lpspi_write_tx_fifo(): simplify while() loop check Marc Kleine-Budde
2026-03-16  8:39 ` [PATCH spi-next 09/11] spi: spi-fsl-lpspi: make struct lpspi_config::mode u32 Marc Kleine-Budde
2026-03-16  8:39 ` [PATCH spi-next 10/11] spi: spi-fsl-lpspi: fsl_lpspi_set_cmd(): use mode from (struct fsl_lpspi_data::config::mode Marc Kleine-Budde
2026-03-16 11:51   ` Marek Vasut [this message]
2026-03-16  8:39 ` [PATCH spi-next 11/11] spi: spi-fsl-lpspi: fsl_lpspi_set_bitrate(): don't treat devtype_data->prescale_max == 0 as a special case Marc Kleine-Budde
2026-03-16  9:57   ` James Clark
2026-03-16 11:19     ` Marc Kleine-Budde
2026-03-16 12:08       ` James Clark
2026-03-16 12:11         ` Marc Kleine-Budde
2026-04-07 16:45 ` [PATCH spi-next 00/11] spi: spi-fsl-lpspi: various cleanup and enhancement patches Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ddad0944-3ec2-4443-bb01-9140d48c5ae7@nabladev.com \
    --to=marex@nabladev.com \
    --cc=Frank.Li@nxp.com \
    --cc=broonie@kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®