From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B565DC388F7 for ; Wed, 11 Nov 2020 01:15:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69830221F1 for ; Wed, 11 Nov 2020 01:15:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732874AbgKKBPv (ORCPT ); Tue, 10 Nov 2020 20:15:51 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:7203 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732799AbgKKBPq (ORCPT ); Tue, 10 Nov 2020 20:15:46 -0500 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CW6H82fw2zkY6p; Wed, 11 Nov 2020 09:15:32 +0800 (CST) Received: from [127.0.0.1] (10.74.149.191) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Wed, 11 Nov 2020 09:15:34 +0800 Subject: Re: [PATCH V2 net-next 01/11] net: hns3: add support for configuring interrupt quantity limiting To: Jakub Kicinski CC: , , , , , References: <1604892159-19990-1-git-send-email-tanhuazhong@huawei.com> <1604892159-19990-2-git-send-email-tanhuazhong@huawei.com> <20201110171312.66a031a6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: tanhuazhong Message-ID: Date: Wed, 11 Nov 2020 09:15:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20201110171312.66a031a6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.74.149.191] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/11/11 9:13, Jakub Kicinski wrote: > On Mon, 9 Nov 2020 11:22:29 +0800 Huazhong Tan wrote: >> + if (rx_vector->tx_group.coal.ql_enable) > ^^^^^^^^ > > Is this supposed to be rx_group, not tx? > yes, will fix it. thanks. >> + hns3_set_vector_coalesce_rx_ql(rx_vector, >> + rx_vector->rx_group.coal.int_ql); > > . >