From: Vasant Hegde <vasant.hegde@amd.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Ankit Soni <Ankit.Soni@amd.com>,
iommu@lists.linux.dev, suravee.suthikulpanit@amd.com,
joro@8bytes.org, will@kernel.org, robin.murphy@arm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iommu/amd: Add efr[HATS] max v1 page table level
Date: Wed, 7 May 2025 11:54:05 +0530 [thread overview]
Message-ID: <ddb0fd72-41a6-47b1-80f2-b336365a75d4@amd.com> (raw)
In-Reply-To: <20250506152755.GK2260621@ziepe.ca>
On 5/6/2025 8:57 PM, Jason Gunthorpe wrote:
> On Wed, Apr 30, 2025 at 05:27:10PM +0530, Vasant Hegde wrote:
>>> + efr_hats = FIELD_GET(FEATURE_HATS, amd_iommu_efr);
>>> + if (efr_hats != 0x3) {
>>> + /*
>>> + * efr[HATS] bits specify the maximum host translation level
>>> + * supported, with LEVEL 4 being initial max level.
>>> + */
>>> + amd_iommu_hpt_level = efr_hats + PAGE_MODE_4_LEVEL;
>>> + } else {
>>> + pr_warn_once("Disable host address translation due to invalid max level (%#x).\n",
>>
>> s/invalid max level/invalid translation level/
>
> This should have a FW_BUG annotation too?
Ack. We can add FW_BUG.
-Vasant
prev parent reply other threads:[~2025-05-07 6:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 6:50 [PATCH 0/2] iommu/amd: Support for HATdis and HATS features Ankit Soni
2025-04-23 6:50 ` [PATCH 1/2] iommu/amd: Add HATDis feature support Ankit Soni
2025-04-24 12:19 ` Joao Martins
2025-04-25 16:25 ` Ankit Soni
2025-04-30 11:41 ` Joao Martins
2025-05-06 5:12 ` Ankit Soni
2025-05-08 17:03 ` Joao Martins
2025-05-12 6:30 ` Ankit Soni
2025-05-28 12:19 ` Vasant Hegde
2025-05-30 4:32 ` Ankit Soni
2025-04-30 11:52 ` Vasant Hegde
2025-04-30 11:35 ` Vasant Hegde
2025-05-05 6:30 ` Ankit Soni
2025-04-23 6:50 ` [PATCH 2/2] iommu/amd: Add efr[HATS] max v1 page table level Ankit Soni
2025-04-30 11:57 ` Vasant Hegde
2025-05-06 15:27 ` Jason Gunthorpe
2025-05-07 6:24 ` Vasant Hegde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddb0fd72-41a6-47b1-80f2-b336365a75d4@amd.com \
--to=vasant.hegde@amd.com \
--cc=Ankit.Soni@amd.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®