From: Max Staudt <max@enpas.org>
To: Eslam Khafagy <eslam.medhat1993@gmail.com>,
roderick.colenbrander@sony.com, jikos@kernel.org,
bentiss@kernel.org
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org,
syzbot+4f5f81e1456a1f645bf8@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] HID: memory leak in dualshock4_get_calibration_data
Date: Sun, 16 Nov 2025 13:34:50 +0900 [thread overview]
Message-ID: <ddb16ea8-7588-4c0a-9e34-6bd8babd598f@enpas.org> (raw)
In-Reply-To: <20251116022723.29857-1-eslam.medhat1993@gmail.com>
On 11/16/25 11:27 AM, Eslam Khafagy wrote:
> function dualshock4_get_calibration_data allocates memory to pointer
> buf. however the function may exit prematurely due to transfer_failure
> in this case it does not handle freeing memory.
>
> this patch handles memory deallocation at exit.
Reviewed-by: Max Staudt <max@enpas.org>
One minor thing that I forgot: I see that the commit message is all
lower case. Proper capitalisation helps readability and matches the
kernel style. No need to resend this time, but in case you're sending a
v3 for any other reason, it'd be great if you picked this up as well :)
Thanks for your patch!
Max
next prev parent reply other threads:[~2025-11-16 4:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-16 2:27 Eslam Khafagy
2025-11-16 4:34 ` Max Staudt [this message]
2025-11-16 15:09 ` Eslam Khafagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddb16ea8-7588-4c0a-9e34-6bd8babd598f@enpas.org \
--to=max@enpas.org \
--cc=bentiss@kernel.org \
--cc=eslam.medhat1993@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roderick.colenbrander@sony.com \
--cc=stable@vger.kernel.org \
--cc=syzbot+4f5f81e1456a1f645bf8@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®