From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Alexandre Mergnat <amergnat@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Qii Wang <qii.wang@mediatek.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-i2c@vger.kernel.org, Rob Herring <robh@kernel.org>,
Fabien Parent <fparent@baylibre.com>,
linux-arm-kernel@lists.infradead.org,
Kevin Hilman <khilman@baylibre.com>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/4] arm64: dts: mediatek: add i2c support for mt8365 SoC
Date: Tue, 17 Jan 2023 13:52:19 +0100 [thread overview]
Message-ID: <ddb81fcb-b353-ce7f-8b12-9cdcbfcacb8e@collabora.com> (raw)
In-Reply-To: <20221122-mt8365-i2c-support-v1-2-4aeb7c54c67b@baylibre.com>
Il 17/01/23 09:49, Alexandre Mergnat ha scritto:
> There are four I2C master channels in MT8365 with a same HW architecture.
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8365.dtsi | 60 ++++++++++++++++++++++++++++++++
> 1 file changed, 60 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8365.dtsi b/arch/arm64/boot/dts/mediatek/mt8365.dtsi
> index a32f2b7507be..3c2819bd32af 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8365.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8365.dtsi
> @@ -282,6 +282,66 @@ pwm: pwm@11006000 {
> clock-names = "top", "main", "pwm1", "pwm2", "pwm3";
> };
>
> + i2c0: i2c@11007000 {
> + compatible = "mediatek,mt8365-i2c",
> + "mediatek,mt8168-i2c";
> + reg = <0 0x11007000 0 0xa0>,
> + <0 0x11000080 0 0x80>;
Compatibles fit in one line (83 columns is fine);
regs fit in one line, reaching 76 columns.
Same comments for the other nodes that you're adding.
Regards,
Angelo
next prev parent reply other threads:[~2023-01-17 12:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 8:49 [PATCH 0/4] Add MediaTek MT8365 I2C support Alexandre Mergnat
2023-01-17 8:49 ` [PATCH 1/4] dt-bindings: i2c: i2c-mt65xx: add binding for MT8365 SoC Alexandre Mergnat
2023-01-17 12:50 ` AngeloGioacchino Del Regno
2023-01-17 8:49 ` [PATCH 2/4] arm64: dts: mediatek: add i2c support for mt8365 SoC Alexandre Mergnat
2023-01-17 12:52 ` AngeloGioacchino Del Regno [this message]
2023-01-17 8:49 ` [PATCH 3/4] arm64: dts: mediatek: enable i2c0 for mt8365-evk board Alexandre Mergnat
2023-01-17 8:49 ` [PATCH 4/4] i2c: i2c-mt65xx: add MT8365 SoC support Alexandre Mergnat
2023-01-17 12:49 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddb81fcb-b353-ce7f-8b12-9cdcbfcacb8e@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=amergnat@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=fparent@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=qii.wang@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®