From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3569E810D2 for ; Wed, 27 Sep 2023 11:27:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231516AbjI0L1Z (ORCPT ); Wed, 27 Sep 2023 07:27:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231612AbjI0L1L (ORCPT ); Wed, 27 Sep 2023 07:27:11 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3304C10E2 for ; Wed, 27 Sep 2023 04:26:36 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D3D1C433C8; Wed, 27 Sep 2023 11:26:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695813995; bh=3/kJu0BAtwkj3xJ9fdAbiBLvvVYc2eBsWVfENf9O048=; h=Date:Subject:To:References:Cc:From:In-Reply-To:From; b=PUT96mbnyi935kDaCn6iWqoadw2bcA5kl4k5iOwiWGVd430pk0xIrzndkmBat8MT6 0kgG86LdZn0mBlaK6ESrTrJL4oEBfAmtN+6LE0S/RzPiHrbxol7GaPi7XJmmildsqY eBhXOFzT2JHo6zduNlkR7dzPza1YNVJNYB7DB0wmVK0aFOi21/xgo01VOCxRzWNATC 9Po9tWszGFN4QfmCVi7LcZjj3wx1uAMUzFDb/Kw5aXfc1Cejc/oc0Nj3D9ix7OTS08 lOFDjKx2BHGWP/mUcw+Xegt+mYMeu+CljZ6q9LBOrum31vCHoJW8oJaWD0lD6lfyMS 1zHLK7RyC+Mww== Message-ID: Date: Wed, 27 Sep 2023 13:26:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/8] hugetlb: restructure pool allocations Content-Language: en-US To: Mike Kravetz References: <20230925234837.86786-3-mike.kravetz@oracle.com> Cc: Anshuman Khandual , Xiongchun Duan , Barry Song <21cnbao@gmail.com>, David Rientjes , Miaohe Lin , Matthew Wilcox , linux-mm@kvack.org, Andrew Morton , Naoya Horiguchi , Joao Martins , David Hildenbrand , Michal Hocko , Oscar Salvador , linux-kernel@vger.kernel.org From: Konrad Dybcio In-Reply-To: <20230925234837.86786-3-mike.kravetz@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26.09.2023 01:48, Mike Kravetz wrote: > Allocation of a hugetlb page for the hugetlb pool is done by the routine > alloc_pool_huge_page. This routine will allocate contiguous pages from > a low level allocator, prep the pages for usage as a hugetlb page and > then add the resulting hugetlb page to the pool. > > In the 'prep' stage, optional vmemmap optimization is done. For > performance reasons we want to perform vmemmap optimization on multiple > hugetlb pages at once. To do this, restructure the hugetlb pool > allocation code such that vmemmap optimization can be isolated and later > batched. > > The code to allocate hugetlb pages from bootmem was also modified to > allow batching. > > No functional changes, only code restructure. > > Signed-off-by: Mike Kravetz > Reviewed-by: Muchun Song > --- Hi, looks like this patch prevents today's next from booting on at least one Qualcomm ARM64 platform. Reverting it makes the device boot again. Konrad