From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBF44C83F19 for ; Mon, 28 Aug 2023 19:42:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233461AbjH1Tlx (ORCPT ); Mon, 28 Aug 2023 15:41:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233132AbjH1Tlg (ORCPT ); Mon, 28 Aug 2023 15:41:36 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEE65123 for ; Mon, 28 Aug 2023 12:41:33 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-3fef34c33d6so34357235e9.3 for ; Mon, 28 Aug 2023 12:41:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693251692; x=1693856492; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VVVU3xEelEp+/RsI5JfEyIwW02b+82orcIdT+6JDihk=; b=PhIZ5bfCavvRSNfXrDZHhkG2X9Aoao/IijcU4P3RlcRAK8puuwllH0En7keHO2nAma LgR5mIgJ/Dz771ARHbjHnVWEhpC7RrIX4BgFLBXygT4ilqUMLfe1BZ0A48yEyP8zXUx+ 3qsXQTDClUVVPz78w3FqK0sa5njERp0CDdfph4ET+7a9/tF1zk00IFvVpi1O/2NC1Bm2 qFgNAmQJJtpf/rU684NyVTVYyrKPXIz/aJVpfBwZclYa/dOzDXHVAY2+jKh1RlM9rcyd WgQkvhz9PCb68bNWAYtwn8Zr3RYkY7RpWlNP2AnpDvGiYHBFy2mMnki6V2e9T2pDcpNm BC5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693251692; x=1693856492; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VVVU3xEelEp+/RsI5JfEyIwW02b+82orcIdT+6JDihk=; b=Gj4XcN8lTWjE80eQRBNkqUyJv8RW5i2F44QUAlB0ojicxJ7xaV+c4luKppxO7qAtNi 0FjgoeTfjUb7HcsdLMY4pMm3XHjBV3x6NPY0tUC08GgNoOx6h/KaSBBsT3msP/7g7OQJ NO1BilsRBc7LDJoF/5fWu/FuJnsPGt/o2l6qVeljO5us1miOQhJMI7xrtv3siQGmaecA J+vEbLdi5UugYdThdtOrli8AEZ22UvNdN+dQ/0ntY1pkNe49Z9ZHdYnkFAz+WhVKaPsk vVx2k9MTpgAlC2NsC1NSh7FVBNAj9T/wtZoKOhaiMVYuu53/dM5oXf/JQMp18gYVQEmI +PPA== X-Gm-Message-State: AOJu0YxRHZ+xdh0y+yfxVo50AmRI0/KQEwcDQkaiE+KKtOlZ8BJj7McV Hwg8DZ2mfkvYpNS8UdRLvA8y1w== X-Google-Smtp-Source: AGHT+IElK01TSrLEb2DvEcfcFpvHpE6ke2T6VhR4gTKJwH7eSku8DjCZsRumovR5fTbe5Gk9RRmvww== X-Received: by 2002:adf:e802:0:b0:317:e68d:f862 with SMTP id o2-20020adfe802000000b00317e68df862mr20872947wrm.37.1693251692242; Mon, 28 Aug 2023 12:41:32 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id n8-20020a5d6608000000b0031c5b380291sm11364474wru.110.2023.08.28.12.41.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Aug 2023 12:41:31 -0700 (PDT) Message-ID: Date: Mon, 28 Aug 2023 20:41:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 07/15] media: qcom: camss: Capture VFE CSID dependency in a helper function Content-Language: en-US To: Laurent Pinchart Cc: rfoss@kernel.org, todor.too@gmail.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, sakari.ailus@linux.intel.com, andrey.konovalov@linaro.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230823104444.1954663-1-bryan.odonoghue@linaro.org> <20230823104444.1954663-8-bryan.odonoghue@linaro.org> <20230828184716.GM14596@pendragon.ideasonboard.com> <9fb41649-b4fb-d652-3207-7c8ff8b32f24@linaro.org> <20230828194010.GF17083@pendragon.ideasonboard.com> From: Bryan O'Donoghue In-Reply-To: <20230828194010.GF17083@pendragon.ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/08/2023 20:40, Laurent Pinchart wrote: > On Mon, Aug 28, 2023 at 08:37:44PM +0100, Bryan O'Donoghue wrote: >> On 28/08/2023 19:47, Laurent Pinchart wrote: >>> Hi Bryan, >>> >>> Thank you for the patch. >>> >>> On Wed, Aug 23, 2023 at 11:44:36AM +0100, Bryan O'Donoghue wrote: >>>> From sdm845 onwards we need to ensure the VFE is powered on prior to >>>> switching on the CSID. >>> >>> Based on the discussions with Konrad in the mail thread, I would record >>> here the reason for this requirement. >>> >>> What happens if you unconditionally power up the VFE prior to switching >>> the CSID on ? Will this break something on platforms older than SDM845 ? >> >> vfe->power_count will bump and you will be fine. > > Then maybe that would be a simpler solution than having a > device-specific power sequence ? > A fair point. Worth a try. --- bod