From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753809AbdGJLd2 (ORCPT ); Mon, 10 Jul 2017 07:33:28 -0400 Received: from mail-lf0-f52.google.com ([209.85.215.52]:36784 "EHLO mail-lf0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753224AbdGJLd1 (ORCPT ); Mon, 10 Jul 2017 07:33:27 -0400 Subject: Re: [PATCH] nvmem: include linux/err.h from header To: Arnd Bergmann , Alexandre Belloni Cc: linux-kernel@vger.kernel.org References: <20170710112300.958195-1-arnd@arndb.de> From: Srinivas Kandagatla Message-ID: Date: Mon, 10 Jul 2017 12:33:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170710112300.958195-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/07/17 12:22, Arnd Bergmann wrote: > The new support for nvmem devices from the rtc layer caused a build > error in some configurations: > > include/linux/nvmem-provider.h: In function 'nvmem_register': > include/linux/nvmem-provider.h:51:9: error: implicit declaration of function 'ERR_PTR' [-Werror=implicit-function-declaration] > > This adds the missing include to ensure we can always include > the header. > > Fixes: 697e5a47aa12 ("rtc: add generic nvmem support") > Signed-off-by: Arnd Bergmann > --- > I'd suggest adding this patch in the rtc tree on top of the > nvmem support there. Thanks for the patch, we would need similar patch for include/linux/nvmem-consumer.h too. Acked-by: Srinivas Kandagatla > --- > include/linux/nvmem-provider.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h > index cd93416d762e..497706f5adca 100644 > --- a/include/linux/nvmem-provider.h > +++ b/include/linux/nvmem-provider.h > @@ -12,6 +12,9 @@ > #ifndef _LINUX_NVMEM_PROVIDER_H > #define _LINUX_NVMEM_PROVIDER_H > > +#include > +#include > + > struct nvmem_device; > struct nvmem_cell_info; > typedef int (*nvmem_reg_read_t)(void *priv, unsigned int offset, >