From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84729168C4; Wed, 20 Dec 2023 06:49:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="CpwZpYqj" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=CLJcevJg8ePh6WU3ddptLA4N7F3zd833b6TMvJ3Gz4o=; b=CpwZpYqjLJSEUWoJzmtt/m5BTK ZzcaZe9X0HGRtBtlP11C0DiUVPgr2IQ0lXpJ2cbYyBLSJEJuttvlArFm9SvZ2xpwwrhKFhQrTrCRP SAx2xkjsFSZPS/x37e5gI+bDjwNZUXGjHjXZuyn7yyfjLya29GSW7oU7TPlAYi/7m01Bi+KRqGkk9 HTvL6ZiCG45+jOTWLBWExjjuIm5hUdyPBLkcLyvMUIjU/0FHofjB/jOym4AxtlWCE/aEyifBYzZqG bkeKuP7afS7OZqRDoEt4pkh2uvlc4+EKoc2H6dcXAe4Bf3wTn0KilgOsqotFyUIpftLhND8ZuUdCN WeSKKtlg==; Received: from [50.53.46.231] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rFqOw-00GKeE-1R; Wed, 20 Dec 2023 06:49:54 +0000 Message-ID: Date: Tue, 19 Dec 2023 22:49:54 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] scripts: kernel-doc: Bug fixed for erroneous warning Content-Language: en-US To: Muhammad Muzammil Cc: corbet@lwn.net, gustavoars@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20231220062446.14511-1-muzammil@dreambigsemi.com> <4155c90e-cdb1-4645-8bcc-fed4ea01ac83@infradead.org> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 12/19/23 22:35, Muhammad Muzammil wrote: > HI, > > 1) I already have the below patch but it does not work. > https://lore.kernel.org/linux-doc/20231215001347.work.151-kees@kernel.org/ > > 2) When I applied the below patch. It works. > https://lore.kernel.org/linux-doc/87le9rjb4y.fsf@meer.lwn.net/ Thanks! > On Wed, Dec 20, 2023 at 11:29 AM Randy Dunlap wrote: >> >> Hi, >> >> On 12/19/23 22:24, Muhammad Muzammil wrote: >>> From: Muzammil Ashraf >>> >>> kernel-doc: fixed erroneous warning generated by '__counted_by' >>> >>> Signed-off-by: Muzammil Ashraf >>> --- >>> scripts/kernel-doc | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/scripts/kernel-doc b/scripts/kernel-doc >>> index 1484127db104..ea9688df0e93 100755 >>> --- a/scripts/kernel-doc >>> +++ b/scripts/kernel-doc >>> @@ -1661,6 +1661,7 @@ sub check_sections($$$$$) { >>> } >>> elsif (($decl_type eq "struct") or >>> ($decl_type eq "union")) { >>> + next if (index("@_", "__counted_by") != -1); >>> emit_warning("${file}:$.", >>> "Excess $decl_type member " . >>> "'$sects[$sx]' " . >> >> One of both of these patches should be enough. Can you test these >> instead of your patch, please? >> >> https://lore.kernel.org/linux-doc/20231215001347.work.151-kees@kernel.org/ >> >> https://lore.kernel.org/linux-doc/87le9rjb4y.fsf@meer.lwn.net/ >> >> Thanks. >> >> -- >> #Randy >> https://people.kernel.org/tglx/notes-about-netiquette >> https://subspace.kernel.org/etiquette.html -- #Randy https://people.kernel.org/tglx/notes-about-netiquette https://subspace.kernel.org/etiquette.html