From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751702AbdJBW7d (ORCPT ); Mon, 2 Oct 2017 18:59:33 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:52974 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751236AbdJBW7b (ORCPT ); Mon, 2 Oct 2017 18:59:31 -0400 Subject: Re: [PATCH] drivers: of: increase MAX_RESERVED_REGIONS to 32 To: Stewart Smith , Rob Herring Cc: devicetree@vger.kernel.org, Frank Rowand , linux-kernel@vger.kernel.org, obh+dt@kernel.org, linuxppc-dev@lists.ozlabs.org References: <20170926084000.29105-1-stewart@linux.vnet.ibm.com> From: Mauricio Faria de Oliveira Date: Mon, 2 Oct 2017 19:58:30 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20170926084000.29105-1-stewart@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17100222-0008-0000-0000-000008A7A096 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007831; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000233; SDB=6.00925617; UDB=6.00465542; IPR=6.00705816; BA=6.00005616; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017369; XFM=3.00000015; UTC=2017-10-02 22:59:28 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17100222-0009-0000-0000-00004434C5A4 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-02_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710020333 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/26/2017 05:40 AM, Stewart Smith wrote: > The simple fix is to bump the length of the array to 32 which "should be > enough for everyone(TM)". Tested-by: Mauricio Faria de Oliveira # uname -r 4.14.0-rc3 # dmesg [ 0.000000] opal: OPAL detected ! [ 0.000000] crashkernel: memory value expected [ 0.000000] OF: reserved mem: not enough space all defined regions. [ 0.000000] OF: reserved mem: not enough space all defined regions. [ 0.000000] OF: reserved mem: not enough space all defined regions. [ 0.000000] OF: reserved mem: not enough space all defined regions. [ 0.000000] Allocated 2883584 bytes for 2048 pacas at c00000000fd40000 <...> # uname -r 4.14.0-rc3.of32maxrsvdmemregions # dmesg | head [ 0.000000] opal: OPAL detected ! [ 0.000000] crashkernel: memory value expected [ 0.000000] Allocated 2883584 bytes for 2048 pacas at c00000000fd40000 <...> -- Mauricio Faria de Oliveira IBM Linux Technology Center