From: "Zhijian Li (Fujitsu)" <lizhijian@fujitsu.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: "linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH for-next v2] selftests/Makefile: override the srctree for out-of-tree builds
Date: Wed, 15 Jan 2025 01:45:59 +0000 [thread overview]
Message-ID: <ddd74a74-3415-4dd4-8cf8-718a8241cc26@fujitsu.com> (raw)
In-Reply-To: <CAEf4BzYOOnR8k3WNKGKOUnfs_8VXk5Xh5J7Zrstix+bEciyCcg@mail.gmail.com>
Hi Andrii
I am delighted to hear from you.
I will rebase and resent it to bpf soon.
On 15/01/2025 06:35, Andrii Nakryiko wrote:
> On Mon, Dec 23, 2024 at 12:33 AM Li Zhijian<lizhijian@fujitsu.com> wrote:
>> Fixes an issue where out-of-tree kselftest builds fail when building
>> the BPF and bpftools components. The failure occurs because the top-level
>> Makefile passes a relative srctree path to its sub-Makefiles, which
>> leads to errors in locating necessary files.
>>
>> For example, the following error is encountered:
>>
>> ```
>> $ make V=1 O=$build/ TARGETS=hid kselftest-all
>> ...
>> make -C ../tools/testing/selftests all
>> make[4]: Entering directory '/path/to/linux/tools/testing/selftests/hid'
>> make -C/path/to/linux/tools/testing/selftests/../../../tools/lib/bpf OUTPUT=/path/to/linux/O/kselftest/hid/tools/build/libbpf/ \
>> EXTRA_CFLAGS='-g -O0' \
>> DESTDIR=/path/to/linux/O/kselftest/hid/tools prefix= all install_headers
>> make[5]: Entering directory '/path/to/linux/tools/lib/bpf'
>> ...
>> make[5]: Entering directory '/path/to/linux/tools/bpf/bpftool'
>> Makefile:127: ../tools/build/Makefile.feature: No such file or directory
>> make[5]: *** No rule to make target '../tools/build/Makefile.feature'. Stop.
>> ```
>>
>> To resolve this, override the srctree in the kselftests's top Makefile
>> when performing an out-of-tree build. This ensures that all sub-Makefiles
>> have the correct path to the source tree, preventing directory resolution
>> errors.
>>
>> Signed-off-by: Li Zhijian<lizhijian@fujitsu.com>
>> ---
>> Cc: Masahiro Yamada<masahiroy@kernel.org>
>>
>> V2:
>> - handle srctree in selftests itself rather than the linux' top Makefile # Masahiro Yamada<masahiroy@kernel.org>
>>
>> V1:https://lore.kernel.org/lkml/20241217031052.69744-1-lizhijian@fujitsu.com/
>> ---
>> tools/testing/selftests/Makefile | 8 ++++++--
>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>
> Is this intended to go through the bpf-next tree? I don't see it in
> our patchworks, so please rebase and resend (unless this was routed
> through some other tree already)
prev parent reply other threads:[~2025-01-15 1:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-23 8:33 Li Zhijian
2025-01-02 12:03 ` Quentin Monnet
2025-01-14 22:35 ` Andrii Nakryiko
2025-01-15 1:45 ` Zhijian Li (Fujitsu) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddd74a74-3415-4dd4-8cf8-718a8241cc26@fujitsu.com \
--to=lizhijian@fujitsu.com \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®