From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 451EA3914E1 for ; Mon, 16 Mar 2026 11:44:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773661468; cv=none; b=Hie8sBUqJ7eNCLTrDHLkeI+1ZxS/GTDfti3ia5kqvr8nqELWxA8RJtIEhwTN9RdMT5sVAYg324FhgPcV3K263Fp5cZS8uy1HNStAvombUnBYe6dco/eOFQQQfgztrL1EsRsRA4RjOSmp3lwEI0FnH5/CcnKCJ/qi3Z3jUAPXwLA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773661468; c=relaxed/simple; bh=XYZ/Z8E6vtXI8ekr+HAC+mYeXCVml7M5yCUGxNj3tfQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GQKwDn+qMCBDWnhVBifciQCahUjXrpXHs0n2XvWoNrOryagKB1jNf2qBIStOE36epm2oGl2xYv9giJMLJa9pxCyB69rabz8n37vdnhbT24sors7Rdq7b/ulFc9SfeAOgBxzCLPPQHyk7fvcD3ukYUgGMDq3+TgLLpQfLWS7wNpc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WLdiH2iA; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=sH39Iz7J; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WLdiH2iA"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="sH39Iz7J" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773661466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BjOWdH9YOd3q5jDpZy3h9DKwR4CFECAPPaRdY128lqI=; b=WLdiH2iA1Fj30KikWqsTr882TlmQNJPxWsd0yhTZuWtCrsmTWGoe98gePWbWrQ62SYG6x0 VQGKKM1la8NrwjL/yG5UQzFfbbI/xKgbkJB1xQT0r5ntW+WkifUQzM/MX5IhIpbXwo2b5C Ls4NSIj5HCfVsA39eD/a2Dpf0JKsyYQ= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-369-v6RH9eGTNgWn4NpVlG91tw-1; Mon, 16 Mar 2026 07:44:25 -0400 X-MC-Unique: v6RH9eGTNgWn4NpVlG91tw-1 X-Mimecast-MFC-AGG-ID: v6RH9eGTNgWn4NpVlG91tw_1773661464 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-b9768f1d12cso301183966b.2 for ; Mon, 16 Mar 2026 04:44:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773661464; x=1774266264; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BjOWdH9YOd3q5jDpZy3h9DKwR4CFECAPPaRdY128lqI=; b=sH39Iz7JhqEO7BE2yyd3VoO8NN5Sf/SVeBsxg/KeAiRczBZfWz91QuEltU0LeIBgph wXACfytY2IJTtBDn8D46ZjhbvqVecAcVtWCf9Tmcwk/k5PODKOMw72hprMQVMsI4LJrk YgDZ3kc1ljHr72WiKVDDv1fHqJajN3+gzQJNsFuJKkSXrzrnNF3K3uOMrg94aC7kD8ST aV69KkCmXxsB9+028EkCEzcYVkWHxFYad9gU9SzDLkE1SE3zTviemydUaozDx4gBRol/ Urb6qZmgEnwiOaJgKS1sldpEqiu9Jl2ESxN4ppP379pJSTgTNRq590ou3jlrndb9sHgA xEmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773661464; x=1774266264; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BjOWdH9YOd3q5jDpZy3h9DKwR4CFECAPPaRdY128lqI=; b=nya9NMddfa7XzknbpqPuln1ZMRSD0w+17ueMQKq63W6CXHiOlqeYKdMq6NJY7v7vhU JJOc2UbWbJ/7VRhtirF159B5mLFgCGsMGOgx4jhW9RhXWgMe4fXO63MlXuWJAukjUXDB AGXtVV6XBIfXb0bI1yQvg4wZtACggxoFNKwhw3vevuQ2Jch/ZqWJLSSyWnf07CkyXj4y Pw0sTtu+q7360qzp9D3d4D7D0Z0WW4b3PWHkv7NU4Xr+yW7VahAERA5xHmhVpaeczWj4 q8AAT4yzCrkqvpyV5LedL9AvJT2ngd6soGCHyYaUh6QQZ0eurtkTTG4KRBAT67BLqBe2 sR4Q== X-Gm-Message-State: AOJu0YxfesqsxgL0gNE0n0o//FaQyOeSPmyDKjlt3cM6HBThj/mFAdz3 mzKqikX9MZ02B7ZdeqEzr6kEbRJvgMbSloI8xiQ2vAvxGNyqBqHpbWnbhT7hIEQ4zy/ugTAfQ5c EdSGyRaoEUnnWMkgVLj29dc54sEAKi8AdmB2bQLHHcVtNBzSuYPHUsS9tjzSphIESzg== X-Gm-Gg: ATEYQzwaRaBtLrkJAFr0CCziMXb397ymhyCEIzWMA8ObOzmnNSBRsVgPaIGRtfTbBiV sV93JOEoMc2xJOr99NGBDGIfFNtY3jwsNM0FZcALtqstztocBYzczxLk7FQhnA+HL7GOnvlzigr QZye7ShWHFY8snRNr/DaKmg4B+XJco73ZXFasY/5Kz91hmoK5MbTJYaDcXGvZ5+qIvsPqRBNm1c 5G0m9Qg/dFMC/LbJnNY04BCc0vrONr9FcmlX5wBx6ce5jHTqlCp1hvisjfKB+RWYcIn/iYE2rRo hS5BNOeR9Rek3F3P1JkOLdzfI77QcaOznfvskNhOiyg1+0g2hzputCYk2WodxynedHZ+i63HQ4k Efvf78RnAiZWwwkuy5tL3GYxuj9JeV2/Jk5Kxx4cuvAMPDnPZWIRiwUA= X-Received: by 2002:a17:907:3c90:b0:b97:acca:fcf4 with SMTP id a640c23a62f3a-b97accb064dmr285765866b.11.1773661463843; Mon, 16 Mar 2026 04:44:23 -0700 (PDT) X-Received: by 2002:a17:907:3c90:b0:b97:acca:fcf4 with SMTP id a640c23a62f3a-b97accb064dmr285762266b.11.1773661463375; Mon, 16 Mar 2026 04:44:23 -0700 (PDT) Received: from [192.168.88.32] ([216.128.11.95]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b976d096d58sm533417666b.62.2026.03.16.04.44.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 04:44:22 -0700 (PDT) Message-ID: Date: Mon, 16 Mar 2026 12:44:20 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 07/14] tcp: honor the maximum advertised window after live retraction To: atwellwea@gmail.com, netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, edumazet@google.com, ncardwell@google.com Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-trace-kernel@vger.kernel.org, mptcp@lists.linux.dev, dsahern@kernel.org, horms@kernel.org, kuniyu@google.com, andrew+netdev@lunn.ch, willemdebruijn.kernel@gmail.com, jasowang@redhat.com, skhan@linuxfoundation.org, corbet@lwn.net, matttbe@kernel.org, martineau@kernel.org, geliang@kernel.org, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, 0x7f454c46@gmail.com References: <20260314201348.1786972-1-atwellwea@gmail.com> <20260314201348.1786972-8-atwellwea@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260314201348.1786972-8-atwellwea@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/14/26 9:13 PM, atwellwea@gmail.com wrote: > +/* Sender-visible window rescue does not relax hard receive-memory admission. > + * If growth did not make room, fall back to the established prune/collapse > + * path. > + */ > static int tcp_try_rmem_schedule(struct sock *sk, const struct sk_buff *skb, > unsigned int size) > { > - if (!tcp_can_ingest(sk, skb) || > - !sk_rmem_schedule(sk, skb, size)) { > + bool can_ingest = tcp_can_ingest(sk, skb); > + bool scheduled = can_ingest && sk_rmem_schedule(sk, skb, size); > + > + if (!scheduled) { > + int pruned = tcp_prune_queue(sk, skb); > > - if (tcp_prune_queue(sk, skb) < 0) > + if (pruned < 0) > return -1; > > while (!sk_rmem_schedule(sk, skb, size)) { > - if (!tcp_prune_ofo_queue(sk, skb)) > + bool pruned_ofo = tcp_prune_ofo_queue(sk, skb); > + > + if (!pruned_ofo) > return -1; > } > } The above chunk is AFAICS pure noise. Please have a more careful local review of this series before any next revision. /P