From: "Paul E. McKenney" <paulmck@kernel.org>
To: Joel Fernandes <joelagnelf@nvidia.com>
Cc: linux-kernel@vger.kernel.org,
Lai Jiangshan <jiangshanlai@gmail.com>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Neeraj Upadhyay <Neeraj.Upadhyay@amd.com>,
rcu@vger.kernel.org
Subject: Re: [PATCH v2 -rcu] srcu: Use rcu_seq_done_exact() for polling API
Date: Wed, 19 Feb 2025 05:22:21 -0800 [thread overview]
Message-ID: <dde0f073-c3d9-44c9-bd85-cf0e8a0fd628@paulmck-laptop> (raw)
In-Reply-To: <20250219124309.463702-1-joelagnelf@nvidia.com>
On Wed, Feb 19, 2025 at 07:43:08AM -0500, Joel Fernandes wrote:
> poll_state_synchronize_srcu() uses rcu_seq_done() unlike
> poll_state_synchronize_rcu() which uses rcu_seq_done_exact().
>
> The rcu_seq_done_exact() makes more sense for polling API, as with
> this API, there is a higher chance that there is a significant delay
> between the get_state..() and poll_state..() calls since a cookie
> can be stored and reused at a later time. During such a delay, if
> the gp_seq counter progresses more than ULONG_MAX/2 distance, then
> poll_state..() may return false for a long time unwantedly.
>
> Fix by using the more accurate rcu_seq_done_exact() API which is
> exactly what straight RCU's polling does.
>
> It may make sense, as future work, to add debug code here as well, where
> we compare a physical timestamp between get_state..() and poll_state()
> calls and yell if significant time has past but the grace period has
> still not progressed.
>
> Reviewed-by: Neeraj Upadhyay <Neeraj.Upadhyay@amd.com>
> Signed-off-by: Joel Fernandes <joelagnelf@nvidia.com>
Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
But we should also run this by Kent Overstreet, given that bcachefs
uses this. Should be OK, given that bcachefs uses this API in the same
way that it does poll_state_synchronize_rcu(), but still...
Thanx, Paul
> ---
> v1->v2: Resend with Neeraj review tag. Rebased on rcu/dev.
>
> kernel/rcu/srcutree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c
> index d2a694944553..591371d62e89 100644
> --- a/kernel/rcu/srcutree.c
> +++ b/kernel/rcu/srcutree.c
> @@ -1589,7 +1589,7 @@ EXPORT_SYMBOL_GPL(start_poll_synchronize_srcu);
> bool poll_state_synchronize_srcu(struct srcu_struct *ssp, unsigned long cookie)
> {
> if (cookie != SRCU_GET_STATE_COMPLETED &&
> - !rcu_seq_done(&ssp->srcu_sup->srcu_gp_seq, cookie))
> + !rcu_seq_done_exact(&ssp->srcu_sup->srcu_gp_seq, cookie))
> return false;
> // Ensure that the end of the SRCU grace period happens before
> // any subsequent code that the caller might execute.
> --
> 2.34.1
>
next prev parent reply other threads:[~2025-02-19 13:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 12:43 Joel Fernandes
2025-02-19 13:22 ` Paul E. McKenney [this message]
2025-02-19 13:29 ` Joel Fernandes
2025-02-19 21:07 ` Kent Overstreet
2025-02-19 23:45 ` Joel Fernandes
2025-02-20 0:32 ` Kent Overstreet
2025-03-05 16:46 ` Boqun Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dde0f073-c3d9-44c9-bd85-cf0e8a0fd628@paulmck-laptop \
--to=paulmck@kernel.org \
--cc=Neeraj.Upadhyay@amd.com \
--cc=jiangshanlai@gmail.com \
--cc=joelagnelf@nvidia.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®