From: bot+bpf-ci@kernel.org
To: mkoutny@suse.com,linux-block@vger.kernel.org,linux-kernel@vger.kernel.org,cgroups@vger.kernel.org,linux-trace-kernel@vger.kernel.org,bpf@vger.kernel.org,netfilter-devel@vger.kernel.org,coreteam@netfilter.org,netdev@vger.kernel.org
Cc: mkoutny@suse.com,yukuai@fnnas.com,axboe@kernel.dk,tj@kernel.org,josef@toxicpanda.com,hannes@cmpxchg.org,rostedt@goodmis.org,mhiramat@kernel.org,mathieu.desnoyers@efficios.com,ast@kernel.org,daniel@iogearbox.net,andrii@kernel.org,martin.lau@linux.dev,eddyz87@gmail.com,song@kernel.org,yonghong.song@linux.dev,john.fastabend@gmail.com,kpsingh@kernel.org,sdf@fomichev.me,haoluo@google.com,jolsa@kernel.org,pablo@netfilter.org,kadlec@netfilter.org,fw@strlen.de,phil@nwl.cc,davem@davemloft.net,edumazet@google.com,kuba@kernel.org,pabeni@redhat.com,horms@kernel.org,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,clm@meta.com,ihor.solodrai@linux.dev
Subject: Re: [PATCH 2/4] cgroup: Introduce cgroup_level() helper
Date: Wed, 17 Dec 2025 16:46:08 +0000 (UTC) [thread overview]
Message-ID: <dde17339701c8159c58f57d58e5e815b39d7bb22b8ea96ba1f63cfd1a25b94ce@mail.kernel.org> (raw)
In-Reply-To: <20251217162744.352391-3-mkoutny@suse.com>
[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]
> diff --git a/block/blk-iocost.c b/block/blk-iocost.c
> index a0416927d33d..b4eebe61dca7 100644
> --- a/block/blk-iocost.c
> +++ b/block/blk-iocost.c
[ ... ]
> @@ -3003,7 +3003,7 @@ static void ioc_pd_init(struct blkg_policy_data *pd)
> init_waitqueue_head(&iocg->waitq);
> hrtimer_setup(&iocg->waitq_timer, iocg_waitq_timer_fn, CLOCK_MONOTONIC, HRTIMER_MODE_ABS);
>
> - iocg->level = blkg->blkcg->css.cgroup->level;
> + iocg->level = cgroup_level(blkg->blkcg->css.cgroup)
^
Is this missing a semicolon? The line should end with a semicolon to
make this valid C syntax. This will prevent the kernel from building
in the ioc_pd_init() function.
>
> for (tblkg = blkg; tblkg; tblkg = tblkg->parent) {
> struct ioc_gq *tiocg = blkg_to_iocg(tblkg);
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/20310204023
next prev parent reply other threads:[~2025-12-17 16:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 16:27 [PATCH 0/4] Use __counted_by for ancestor arrays Michal Koutný
2025-12-17 16:27 ` [PATCH 1/4] cgroup: Eliminate cgrp_ancestor_storage in cgroup_root Michal Koutný
2026-01-06 7:06 ` Gustavo A. R. Silva
2026-01-06 18:03 ` Tejun Heo
2025-12-17 16:27 ` [PATCH 2/4] cgroup: Introduce cgroup_level() helper Michal Koutný
2025-12-17 16:46 ` bot+bpf-ci [this message]
2025-12-20 14:59 ` kernel test robot
2025-12-20 21:49 ` kernel test robot
2025-12-17 16:27 ` [PATCH 3/4] cgroup: Use __counted_by for cgroup::ancestors Michal Koutný
2025-12-18 7:09 ` Chen Ridong
2025-12-18 16:09 ` Tejun Heo
2025-12-18 16:32 ` Michal Koutný
2026-01-06 6:53 ` Gustavo A. R. Silva
2025-12-19 8:33 ` Kees Cook
2025-12-17 16:27 ` [PATCH 4/4] blk-iocost: Correct comment ioc_gq::level Michal Koutný
2025-12-17 16:57 ` Tejun Heo
2025-12-17 19:02 ` Michal Koutný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dde17339701c8159c58f57d58e5e815b39d7bb22b8ea96ba1f63cfd1a25b94ce@mail.kernel.org \
--to=bot+bpf-ci@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=axboe@kernel.dk \
--cc=bpf@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=clm@meta.com \
--cc=coreteam@netfilter.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=hannes@cmpxchg.org \
--cc=haoluo@google.com \
--cc=horms@kernel.org \
--cc=ihor.solodrai@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=josef@toxicpanda.com \
--cc=kadlec@netfilter.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=martin.lau@linux.dev \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mkoutny@suse.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=rostedt@goodmis.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=tj@kernel.org \
--cc=yonghong.song@linux.dev \
--cc=yukuai@fnnas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®